Hello.

In my mod I need run method after all mods have been loaded, the reason is EntityType.byKey method.

Briefly, mod is rendering mob's icons, where and why doesn't matter. Generation of these icons is not the fastest thing, so mod generate them once and save as files, and using IResourcePack implementation then.

For rendering icons im using hashmap with EntityType as a key (to check should I render it or not), I tested and it is faster than using some sort of EntityType string as a key.

So, I was trying to load all those icons in init state, but EntityTypes doesn't exists until mod is loaded (we are talking about external mods), I can't add mods in dependecies because it is a dynimic thing (excepts there is a way to add dependecies in mod constructor).

 

My solution is not perfect at all, but it works at least, and I'm trying to find something better. (As I said before: way to add dependecies in constructor, for example).

 

My solution:

public class FirstMainMenuOpenEvent {
    @SubscribeEvent
    public void onGuiOpen(GuiOpenEvent event){
        if(event.getGui()instanceof MainMenuScreen){
            HeadUtils.loadModHeads();
            MinecraftForge.EVENT_BUS.unregister(this);
        }
    }
}

 

So I register it once in init state, then it runs once and remove itself.

Edited March 3, 20214 yr by DmitryLovin

Maybe try using FMLLoadCompleteEvent

10 hours ago, lupicus said:

Maybe try using FMLLoadCompleteEvent

As I know, it calls when fml (forge mod loader) finish to load itself, so even before mods start to load.

23 hours ago, DmitryLovin said:

On 3/4/2021 at 4:18 AM, lupicus said:

Maybe try using FMLLoadCompleteEvent

As I know, it calls when fml (forge mod loader) finish to load itself, so even before mods start to load.

Sorry I was wrong.

 

13 hours ago, diesieben07 said:

Do not use this method. Use ForgeRegistries.ENTITIES to access the entity type registry

This thing works fine, thanks, but now my IResourcePack implementation method doesn't work. I guess I do it absolutely wrong:

 

for(HeadPack pack:ipack){
    ((SimpleReloadableResourceManager) Minecraft.getInstance().getResourceManager()).addResourcePack(pack);
}
((SimpleReloadableResourceManager) Minecraft.getInstance().getResourceManager()).addReloadListener((s,rM,pP,rP,bE,gE)->{
    return CompletableFuture.
            supplyAsync(() ->{return null;}, bE).
            thenCompose(s::markCompleteAwaitingOthers).
            thenAcceptAsync((p_215269_3_) -> {reloadPack(rM);}, gE);});

Edited March 5, 20214 yr by DmitryLovin

Well, I kinda fixed it:

for(HeadPack pack:ipack){
    Minecraft.getInstance().getResourcePackList().addPackFinder(
            (infoConsumer, infoFactory) -> {
                infoConsumer.accept(infoFactory.create(pack.getName(), true,()->pack,pack, new PackMetadataSection(new StringTextComponent(pack.getName()),6),ResourcePackInfo.Priority.BOTTOM,IPackNameDecorator.BUILTIN));
            }
    );
}

But it works only after I reload packs or something, keep looking what I did wrong.

 

upd:

I guess I still need to add it in ResourceManager manually like before as well:

((SimpleReloadableResourceManager) Minecraft.getInstance().getResourceManager()).addResourcePack(pack);

because minecraft do it only when you reload resourcepacks or change them.

Can be closed.

Edited March 5, 20214 yr by DmitryLovin