[1.15.2] How to add block loots into a players inventory?

[NindyBun]

So I am at a loss on how to get the item drops of a block into the players inventory. Say I mined a coal ore block with fortune, I want the drops to appear in my inventory rather than in the world. How do I get that to work?

[Luis_ST]

40 minutes ago, NindyBun said:

So I am at a loss on how to get the item drops of a block into the players inventory. Say I mined a coal ore block with fortune, I want the drops to appear in my inventory rather than in the world. How do I get that to work?

use Block#getDrop to get the drops of the block.

Then create a for each loop to put the items in the player's inventory with ItemHandlerHelper#giveItemToPlayer

 

Note: that would be the explanation for 1.16 I'm sure that it works in 1.15 too,

but it could be that some methods are not available or that they have a different name

[NindyBun]

7 hours ago, Luis_ST said:

use Block#getDrop to get the drops of the block.

Then create a for each loop to put the items in the player's inventory with ItemHandlerHelper#giveItemToPlayer

 

Note: that would be the explanation for 1.16 I'm sure that it works in 1.15 too,

but it could be that some methods are not available or that they have a different name

The Block#getDrop has a parameter of Builder, what would go into that?

[Draco18s]

Look at existing calls to the method.

[NindyBun]

1 hour ago, Draco18s said:

Look at existing calls to the method.

So I practically took the LootContext#Builder from vanilla but I get a Null pointer exception from it

 @Override
    public ActionResultType onItemUse(ItemUseContext context) {
        refuel(context.getItem(), context.getPlayer());

        int fuelValue = 0;
        int fortune = 0;
        int silkTouch = 0;
        if (context.getItem().hasTag()) {
            if (context.getItem().getTag().contains("FuelValue")) {
                fuelValue = context.getItem().getTag().getInt("FuelValue");
            }
            if (context.getItem().getTag().contains("SilkTouch")) {
                silkTouch = context.getItem().getTag().getInt("SilkTouch");
            }else if (context.getItem().getTag().contains("Fortune")) {
                fortune = context.getItem().getTag().getInt("Fortune");
            }

        }

        World world = context.getWorld();
        ItemStack stack = context.getItem();
        BlockPos pos = context.getPos();
        BlockState state = context.getWorld().getBlockState(pos);
        PlayerEntity player = context.getPlayer();
        Block block = world.getBlockState(pos).getBlock();

        stack.addEnchantment(Enchantments.FORTUNE, 3);

        if (fuelValue >= use){
            //context.getWorld().destroyBlock(context.getPos(), true);
            if (block.removedByPlayer(state, world, pos, player, true, state.getFluidState())){
                //BlockEvent.BreakEvent event = new BlockEvent.BreakEvent(world, pos, state, player);
                block.dropXpOnBlockBreak(world, pos, block.getExpDrop(state, world, pos, fortune, silkTouch));
                block.harvestBlock(world, player, pos, state, world.getTileEntity(pos), stack);

                LootContext.Builder lootcontext = (new LootContext.Builder(world.getServer().getWorld(world.getDimension().getType()))).withRandom(world.rand).withParameter(LootParameters.POSITION, pos).withParameter(LootParameters.TOOL, stack).withNullableParameter(LootParameters.THIS_ENTITY, player).withNullableParameter(LootParameters.BLOCK_ENTITY, world.getTileEntity(pos));
                LOGGER.info(state.getDrops(lootcontext));

                //event.getWorld().destroyBlock(pos, false);
                //event.getWorld().playSound(context.getPlayer(), event.getPos(), event.getState().getSoundType().getBreakSound(), SoundCategory.BLOCKS, event.getState().getSoundType().getVolume(), event.getState().getSoundType().getPitch());
                //context.getWorld().setBlockState(context.getPos(), Blocks.AIR.getDefaultState());
            }
            fuelValue -= use;
            context.getItem().getTag().putInt("FuelValue", context.getItem().getTag().getInt("FuelValue")-use);
        }
        stack.getEnchantmentTagList().clear();
        return ActionResultType.SUCCESS;
    }

 

[NindyBun]

1 minute ago, diesieben07 said:

Post the stacktrace.

LootContext.Builder lootcontext = (new LootContext.Builder(world.getServer().getWorld(world.getDimension().getType()))).withParameter(LootParameters.POSITION, pos).withParameter(LootParameters.BLOCK_STATE, state).withParameter(LootParameters.TOOL, stack).withNullableParameter(LootParameters.THIS_ENTITY, player).withNullableParameter(LootParameters.BLOCK_ENTITY, world.getTileEntity(pos));
                LOGGER.info(state.getDrops(lootcontext));

[10:52:01] [Render thread/FATAL] [minecraft/Minecraft]: Unreported exception thrown!
java.lang.NullPointerException: null
	at com.nindybun.miningtool.test_item.ItemTestItem.onItemUse(ItemTestItem.java:219) ~[main/:?] {re:classloading}
	at net.minecraft.item.ItemStack.lambda$onItemUse$0(ItemStack.java:174) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:189) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:174) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.client.multiplayer.PlayerController.func_217292_a(PlayerController.java:319) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1334) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:1601) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1434) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:942) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:559) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:177) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251] {}
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251] {}
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251] {}
	at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:102) [forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {}

 

[NindyBun]

5 minutes ago, NindyBun said:

 

[10:52:02] [Render thread/INFO] [STDOUT/]: [net.minecraft.util.registry.Bootstrap:printToSYSOUT:110]: ---- Minecraft Crash Report ----
// Hi. I'm Minecraft, and I'm a crashaholic.

Time: 3/11/21 10:52 AM
Description: Unexpected error

java.lang.NullPointerException: Unexpected error
	at com.nindybun.miningtool.test_item.ItemTestItem.onItemUse(ItemTestItem.java:219) ~[main/:?] {re:classloading}
	at net.minecraft.item.ItemStack.lambda$onItemUse$0(ItemStack.java:174) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:189) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:174) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading}
	at net.minecraft.client.multiplayer.PlayerController.func_217292_a(PlayerController.java:319) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1334) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:1601) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1434) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:942) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:559) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:177) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251] {}
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251] {}
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251] {}
	at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55) ~[forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65) [modlauncher-5.0.0-milestone.4.jar:?] {}
	at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:102) [forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar:?] {}


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at com.nindybun.miningtool.test_item.ItemTestItem.onItemUse(ItemTestItem.java:219)
	at net.minecraft.item.ItemStack.lambda$onItemUse$0(ItemStack.java:174)
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:189)
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:174)
	at net.minecraft.client.multiplayer.PlayerController.func_217292_a(PlayerController.java:319)
	at net.minecraft.client.Minecraft.rightClickMouse(Minecraft.java:1334)
	at net.minecraft.client.Minecraft.processKeyBinds(Minecraft.java:1601)

-- Affected level --
Details:
	All players: 1 total; [ClientPlayerEntity['Dev'/62, l='MpServer', x=-534.87, y=64.00, z=134.57]]
	Chunk stats: Client Chunk Cache: 841, 140
	Level dimension: DimensionType{minecraft:overworld}
	Level name: MpServer
	Level seed: 8179760609708042029
	Level generator: ID 00 - default, ver 1. Features enabled: false
	Level generator options: {}
	Level spawn location: World: (-160,63,-16), Chunk: (at 0,3,0 in -10,-1; contains blocks -160,0,-16 to -145,255,-1), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,0,-512 to -1,255,-1)
	Level time: 370469 game time, 1144 day time
	Known server brands: 
	Level was modded: false
	Level storage version: 0x00000 - Unknown?
	Level weather: Rain time: 0 (now: true), thunder time: 0 (now: false)
	Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
	Server brand: forge
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.client.world.ClientWorld.fillCrashReport(ClientWorld.java:457)
	at net.minecraft.client.Minecraft.addGraphicsAndWorldToCrashReport(Minecraft.java:1840)
	at net.minecraft.client.Minecraft.run(Minecraft.java:578)
	at net.minecraft.client.main.Main.main(Main.java:177)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:55)
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37)
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54)
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72)
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:81)
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)
	at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:102)

-- System Details --
Details:
	Minecraft Version: 1.15.2
	Minecraft Version ID: 1.15.2
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_251, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 755686792 bytes (720 MB) / 2043674624 bytes (1949 MB) up to 3803185152 bytes (3627 MB)
	CPUs: 16
	JVM Flags: 1 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump
	ModLauncher: 5.0.0-milestone.4+67+b1a340b
	ModLauncher launch target: fmluserdevclient
	ModLauncher naming: mcp
	ModLauncher services: 
		/eventbus-2.0.0-milestone.1-service.jar eventbus PLUGINSERVICE 
		/forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-launcher.jar object_holder_definalize PLUGINSERVICE 
		/forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-launcher.jar runtime_enum_extender PLUGINSERVICE 
		/accesstransformers-2.0.0-milestone.1-shadowed.jar accesstransformer PLUGINSERVICE 
		/forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-launcher.jar capability_inject_definalize PLUGINSERVICE 
		/forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-launcher.jar runtimedistcleaner PLUGINSERVICE 
		/forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-launcher.jar fml TRANSFORMATIONSERVICE 
	FML: 31.1
	Forge: net.minecraftforge:31.1.0
	FML Language Providers: 
		javafml@31.1
		minecraft@1
	Mod List: 
		client-extra.jar Minecraft {minecraft@1.15.2 DONE}
		main Mining Tool {miningtool@1.15.2-1.0.0 DONE}
		forge-1.15.2-31.1.0_mapped_snapshot_20200507-1.15.1-recomp.jar Forge {forge@31.1.0 DONE}
	Launched Version: MOD_DEV
	Backend library: LWJGL version 3.2.2 build 10
	Backend API: GeForce GTX 1050 Ti/PCIe/SSE2 GL version 4.6.0 NVIDIA 456.71, NVIDIA Corporation
	GL Caps: Using framebuffer using OpenGL 3.0
	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'forge'
	Type: Client (map_client.txt)
	Resource Packs: 
	Current Language: English (US)
	CPU: 16x AMD Ryzen 7 1700X Eight-Core Processor 
[10:52:02] [Render thread/INFO] [STDOUT/]: [net.minecraft.util.registry.Bootstrap:printToSYSOUT:110]: #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\ANDY\Desktop\Minecraft Modding\MiningTool\run\.\crash-reports\crash-2021-03-11_10.52.02-client.txt
AL lib: (EE) alc_cleanup: 1 device not closed

Process finished with exit code -1

 

[NindyBun]

Actually, I just put it into a try catch block and it's fine now. But the number of drops are different from the actual drops in the world. Is that because both statements use a different random?

 

Edited March 11, 2021 by NindyBun

[NindyBun]

 try{
                    List list = state.getDrops(new LootContext.Builder(world.getServer().getWorld(world.getDimension().getType()))
                            .withParameter(LootParameters.TOOL, stack)
                            .withParameter(LootParameters.POSITION, pos)
                            .withParameter(LootParameters.BLOCK_STATE, state)
                    );
                    String string = list.get(0).toString();
                    int count = Integer.parseInt(string.substring(0, string.indexOf(" ")));
                    LOGGER.info(count);
                    ItemStack stackHandler = ItemStackHelper.getAndRemove(list, 0);
                    Item item = stackHandler.getItem();
                    for (int i = 0; i < count; i++){
                        player.inventory.addItemStackToInventory(new ItemStack(item.getItem().asItem()));
                    }

                }catch (Exception e){

                }

I got it working now

[Draco18s]

1 hour ago, NindyBun said:

String string = list.get(0).toString();

What.

1 hour ago, NindyBun said:

catch (Exception e)

This is not how you catch exceptions.

[NindyBun]

6 minutes ago, diesieben07 said:

LMFAO.

Exception handling with NindyBun:

it do be like that. As long as it works I guess ¯\_(ツ)_/¯

[NindyBun]

2 minutes ago, diesieben07 said:

But it doesn't work! An exception by definition means that something didn't work.

Your code just goes "oh, something didn't work? Oh well, carry on."

You don't see the thing that didn't work, doesn't mean it's not there.

I mean, the only thing I seem to be getting is a null pointer exception, and Idk why. It still gives me the result right before throwing an error so...if I just catch the error to prevent my game from crashing then all is fine right?

[NindyBun]

Just now, diesieben07 said:

No, it's definitely not fine.

A NullPointerException means your code is broken. Fix your code.

I would if I knew why the LootContext#Builder is throwing an error.

[NindyBun]

Just now, diesieben07 said:

It is your code that is throwing the error. This is what this stacktrace means.

 

I assume this is the line mentioned in the stacktrace?

That's what I'm assuming as well.

[NindyBun]

Just now, diesieben07 said:

What do you mean "assume"... You have the code in front of you! Look at the line numbers.

I know it's that line, but why is it wrong? What is making it null.

[NindyBun]

34 minutes ago, diesieben07 said:

I don't know. Use the debugger. Put a breakpoint there. Use "Evaluate Expression" to see what is null.

So it's saying to insert @NotNull for BlockState and World.

[NindyBun]

1 minute ago, diesieben07 said:

That ... that has nothing to do with what I asked you to do.

oh...give me a while then, I've never done anything with Intellij Debugger before so I'm wandering about.

[NindyBun]

Ah, the null is coming from

world.getServer().getWorld(world.getDimension().getType())

where 

world.getServer()

is null

[NindyBun]

19 minutes ago, diesieben07 said:

You are on the client then. Check World#isRemote and only do things on the server.

I see it works now but why does checking that do things on the server?