My Nether Ore isnt generating

[MGHader]

Hello, im creating a Titanium Ore that is planned to generate in the nether, but it seems to not generate, this is my main class and ore generation class.

Main class: ShiningRubies.java

Ore generation class: OreGeneration.java

Thanks.
 

[Luis_ST]

14 minutes ago, MGHader said:

Hello, im creating a Titanium Ore that is planned to generate in the nether, but it seems to not generate, this is my main class and ore generation class.

@EventBusSubscriber and @SubscribeEvent are missing in the Ore generation class

[MGHader]

1 hour ago, Luis_ST said:

@EventBusSubscriber and @SubscribeEvent are missing in the Ore generation class

Added it, but it isnt generating.
The Overworld ore, works, but the Nether one no.

[ChampionAsh5357]

Vein sizes using OreFeatureConfig should never be below 6. Otherwise, the ore might not spawn. Vein sizes of 2 and below will most likely never spawn. This is not to mention an ore that spawns at the lowest levels of the nether will probably never spawn because lava is not a valid candidate block to replace.

[MGHader]

6 hours ago, ChampionAsh5357 said:

Vein sizes using OreFeatureConfig should never be below 6. Otherwise, the ore might not spawn. Vein sizes of 2 and below will most likely never spawn. This is not to mention an ore that spawns at the lowest levels of the nether will probably never spawn because lava is not a valid candidate block to replace.

Changed that, but i dont see any difference.

OreGeneration.java

Edited March 14, 2021 by MGHader

[ChampionAsh5357]

Ah wait, I just saw the if statement. You're checking if the world is not the nether or end when executing the code. And then you check within that if you are not in the nether. So basically you're just saying spawn both of these in the overworld.

[MGHader]

So, i deleted the event.getCategory().equals(Biome.Category.NETHER), but sadly this didnt solved it.

[Beethoven92]

Show the updated code

[MGHader]

18 hours ago, Beethoven92 said:

Show the updated code

OreGeneration.java

[ChampionAsh5357]

The if statements are still nested. Nothing has changed.

[Beethoven92]

Yep, the logic of your if statements is pretty flawed. I think you should clarify a bit your ideas about some programming basics. So, the logical flow of the code you need here is very simple:

"is the current biome an End one?" ---> do nothing.

"or is the current biome a Nether one?" ----> generate you Nether ore.

"or (no End or Nether so the biome belongs to the Overworld)" ----> generate your Overworld ore.

I leave it up to you to translate this into java code.