Jump to content

Recommended Posts

Posted (edited)

I really need help with Forge 1.16.4 in using gradlew genEclipseRun as it gets stuck at 88%, but the time continues. I have assigned about 2GBs to it and it does use that much, as well as all of my CPU usage, it is such a pig, XD. But it is stuck on 88%, even while using all of those resourced. I even left it for 7 Hours and no go, it is annoying and don't know what to do.

The main reason why I am trying to run it is for the Forge Source as I heard that creates it, I think anyways. Unless anyone know where to get the forge source at, please say. I have tried looking at this post in how but doesn't exactly answer my question, actually, I don't know if it does answer my question as it hinted to running the command.

Any help that leads to fixing the genEclipseRun command or help with getting the forge source in for attached docs to help with modding is very, very, very greatly appreciated. 

This has been solved. Click here to see what solved my problem.

Edited by jonathanpecany
My question has been solved. Reserve 3GBs of RAM for Java
Posted (edited)
7 minutes ago, diesieben07 said:

Decompiling Minecraft needs at least 3GB of RAM.

Wait, 3 full Gbs, now I have to say that that might just restrict a lot of people from modding.

But I will try it, it might throw a heap error though.

Edited by jonathanpecany
Posted
2 minutes ago, diesieben07 said:

Decompiling is hard, especially if you want at least half-decent code to come out of it.

Minecraft is a big codebase.

Ergo: Decompiling Minecraft takes a lot of memory.

Well, alright then. I'll report back with what will happen.

Also, what is the main purpose of gradlew genEclipseRun?

Posted (edited)
17 minutes ago, diesieben07 said:

It generates the run configurations for eclipse so you can start the game.

If the game is not decompiled yet, it will do so.

Well, your suggestion works. My computer run 3GBs of it quite easy. Guess I underestimated my computer, lol.
Thanks again.

Now, how do I get the forge source?

Edited by jonathanpecany
Posted (edited)
12 minutes ago, diesieben07 said:

It tells you how to set up a Forge modding workspace in Eclipse.

Well, yeah. I have already done all of that. I have it open in eclipse and there are no errors. Only problem is, it will be hard to mod without some sort of docs. I have attached source to Forge in the Referenced Libraries from the .gradle cache (caches\forge_gradle\minecraft_user_repo\net\minecraftforge\forge\1.16.4-35.1.4), I attached the decomp one. But problem is that there seems to be no comment docs inside any of them, making it harder to mod it.

 

I did all of this right after running gradlew genEclipseRuns from cmd within the folder. I also did gradlew eclipse before that. Now, it is both build successful, I open it in eclipse and looked in reference libraries and in Forge snapshot, noticed no attached source so I added one that I think was it, which I think it was as it was working.

And that was the full steps in what I did. I tried to be as specific as I can. I really want to mod Minecraft, but I don't want it to be a lot harder to find what it does exactly, that will take forever and I want to customize Minecraft to the full expense of my imagination.

Edited by jonathanpecany
Posted
1 minute ago, diesieben07 said:

Minecraft is not open source. In fact it is not even visible source. All we get from Mojang is the compiled jar file, which obviously does not contain any comments. On top of that the code is also obfuscated. In very recent versions Forge has switched to using Mojang's official mappings by default, so at least now fields and methods will have the same name as in Mojang's code. However you still don't get parameter names or comments.

There is nothing you can do about this, although in theory you could ask Mojang for documentation... ;)

So how does other madders that create awesome mods like GalacticCraft mod? I used GalacticCraft as an example as it uses a lot of neat features, like flag design, rocket, UI, Space UI, custom armor, adding tabs in Player Inventory, and more.

What steps did they take to look at how they do this and that? That is what confuses me, like if it doesn't have any sort of comments then how do people mod? That always confused me.

I could always ask Mojang for documentation, but why would they, lol. If it was that simple, I am about certain that if that was that easy, Forge would have access, but who knows though, they probably only asked once, so it might just work. Never hurts to ask, they can't sue you or anything for asking, lol. That would take away my first amendment of the USA.

Posted
26 minutes ago, diesieben07 said:

You look at the code and understand what it's doing.

Really? That is way to much, to do that would take months. There has to be an easier way that doesn't make someone discourage.

Posted (edited)
16 minutes ago, jonathanpecany said:

Really? That is way to much, to do that would take months. There has to be an easier way that doesn't make someone discourage.

you don't need to read ALL the code, just the parts that concern your needs

 

plus the forge docs has information on all the fundamentals that you need, such as registries, events, capabilities...

from there you kind of have to figure things out for yourself... by reading the minecraft source code, or other mods source codes

there are a lot of example mods out there aimed at helping begginers

this is one that helped me a lot: https://github.com/TheGreyGhost/MinecraftByExample

 

and if you can't figure out how to do something, you can always ask for help in the forum or in the discord

Edited by kiou.23
Posted
7 minutes ago, kiou.23 said:

you don't need to read ALL the code, just the parts that concern your needs

 

plus the forge docs has information on all the fundamentals that you need, such as registries, events, capabilities...

from there you kind of have to figure things out for yourself... by reading the minecraft source code, or other mods source codes

there are a lot of example mods out there aimed at helping begginers

this is one that helped me a lot: https://github.com/TheGreyGhost/MinecraftByExample

 

and if you can't figure out how to do something, you can always ask for help in the forum or in the discord

Alright, thanks. I will do that. Still probably going to be a pain though, but I will. Can I add my own custom comments to the source, I really hope so. But I think I can do it.

Also, what is the proper forge source at, I seen that forge decomp didn't include every source?

Posted (edited)
3 minutes ago, jonathanpecany said:

Alright, thanks. I will do that. Still probably going to be a pain though

it's not that bad, modding felt impossible when I started too, but the modularity that it has makes it much easier to handle

 

3 minutes ago, jonathanpecany said:

Can I add my own custom comments to the source, I really hope so. But I think I can do it.

nope, those classes are read-only, you can add comments to your own code tho

plus lots of the methods have javadocs too

Edited by kiou.23

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.