Jump to content

Recommended Posts

Posted

This is my code:

package com.Geilomaticer.Geilomaticers.items;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraft.world.World;
import java.util.List;

public class ender_staff {



    public void addInformation(ItemStack itemstack, World world, List<ITextComponent> list,
        ITooltipFlag flag) {
        super.addInformation(itemstack, world, list, flag);
        if (Screen.hasShiftDown() || Screen.hasControlDown()) {
            list.add(new StringTextComponent("Shifted and Controlled Tooltip"));
        } else {
            list.add(new TranslationTextComponent("tooltip.ender_staff.geilomaticers.staff_tooltip"));
        }
    }
}

I'm new to forge and programming so i don't know what to fix i just watched a tutorial and looked in a forum trying to match the code but still didn't help.

Posted
1 hour ago, Geilomaticer said:

I'm new to forge and programming so i don't know what to fix i just watched a tutorial and looked in a forum trying to match the code but still didn't help.

is this complete code of your item class?
if so, then an important part is missing

Posted
Just now, Geilomaticer said:

thats the complete class

if the class posted above is your complete class, it is clear that it is not working

your class has to expand the item class
in this class is the method that you have to overwrite (Item#addInformation)

 

And Please follow Java naming conventions.

Posted (edited)
38 minutes ago, Geilomaticer said:

Like i said I'm new to the Development side of Forge and programming in general, so I don't really know Java

"Help with modding goes in here, however, please keep in mind that this is not a Java school. You are expected to have basic knowledge of Java before posting here."

Edit (after reading the post of @Soft-fur dragon: if you want to start with the moding read the forge doc

Edited by Luis_ST
Posted

You have to change your class declaration to "public class ender_staff extends Item"
You also have to register your item. I'm not sure if you do it, since your class had wrong signature and you just won't be able to register item that looks like in first post
I also understand that you may want to hide you code for personal purposes (I'm not judging you), but if you want to get help then you should know that people here are not telepaths

Posted

Well, if you want to see all the code main class:

package com.Geilomaticer.Geilomaticers;

import com.Geilomaticer.Geilomaticers.init.Iteminit;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.eventbus.api.IEventBus;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

@Mod(Geilomaticer.MOD_ID)
public class Geilomaticer {
    public static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "geilomaticers";
    public static final ItemGroup M_GROUP = new MGroup("geilomaticerstab");

    public Geilomaticer() {
        final IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
        bus.addListener(this::setup);

        Iteminit.ITEMS.register(bus);

        MinecraftForge.EVENT_BUS.register(this);
    }

    private void setup(final FMLCommonSetupEvent event) {

    }

    public static class MGroup extends ItemGroup {

        public MGroup(String label) {
            super(label);
        }

        @Override
        public ItemStack makeIcon() {
            return Iteminit.TELE_STICK.get().getDefaultInstance();
        }
    }
}

register class:

package com.Geilomaticer.Geilomaticers.init;

import com.Geilomaticer.Geilomaticers.Geilomaticer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

import java.rmi.registry.Registry;

public class Iteminit {
    public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
            Geilomaticer.MOD_ID);

    public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",
            () -> new Item(new Item.Properties().tab(Geilomaticer.M_GROUP)));
}

and the Item one:

package com.Geilomaticer.Geilomaticers.items;

        import net.minecraft.client.Minecraft;
        import net.minecraft.client.gui.screen.Screen;
        import net.minecraft.client.util.ITooltipFlag;
        import net.minecraft.item.Item;
        import net.minecraft.item.ItemStack;
        import net.minecraft.util.text.ITextComponent;
        import net.minecraft.util.text.StringTextComponent;
        import net.minecraft.util.text.TranslationTextComponent;
        import net.minecraft.world.World;
        import java.util.List;

public class ender_staff extends item{



    public void addInformation(ItemStack itemstack, World world, List<ITextComponent> list,
                               ITooltipFlag flag) {
        super.addInformation(itemstack, world, list, flag);
        if (Screen.hasShiftDown() || Screen.hasControlDown()) {
            list.add(new StringTextComponent("Shifted and Controlled Tooltip"));
        } else {
            list.add(new TranslationTextComponent("tooltip.ender_staff.geilomaticers.staff_tooltip"));
        }
    }
}

those are all the classes I have.

Posted (edited)

ok, thx. Well, I see some things that confuses me. First of all, try to add "@Override" right above "public void addInformation..."

Next, your class should extend Item, not item. For compiler they are two different classes. Does it compile, actually?

Also I don't see the constructor for your staff. You should add

	public ender_staff(Properties properties) {
		super(properties);
	}

right between "public class ender_staff extends Item {" and added "@Override"

Edited by Soft-fur dragon
Posted
24 minutes ago, Geilomaticer said:

those are all the classes I have.

your code looks good only that your item class does not contain a constructor,
and your item that you register creates a normal item and not your "ender_staff" item

Posted
public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",
            () -> new Item(new Item.Properties().tab(Geilomaticer.M_GROUP)));

should be replaced with

public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",
            () -> new ender_staff(new Item.Properties().tab(Geilomaticer.M_GROUP)));

 

Posted

In the console it says 7 errors:

error: cannot find symbol
    public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
public class ender_staff extends item{

error: cannot find symbol
        Iteminit.ITEMS.register(bus);


error: cannot find symbol
    public static final RegistryObject<ender_staff> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
            () -> new ender_staff(new Item.Properties().tab(Geilomaticer.M_GROUP)));
 

error: cannot find symbol
    public static final RegistryObject<Item> TELE_STICK = ITEMS.register("ender_staff",

error: cannot find symbol
        super.addInformation(itemstack, world, list, flag);
 

Posted (edited)

I can see the item in the game and the custom tab etc, but after that tooltip I couldn't launch it.

after the import and the @Override it got more errors.

Edited by Geilomaticer

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.