Event "setSecondsOnFire" won't connect to SwordItem

[Draco18s]

20 minutes ago, eggpasta said:

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos

Hence giving it an intelligible name.

[Skullblade]

26 minutes ago, eggpasta said:

For the iteminit error get rid of

() ->

so it's just

FlamingSword::new

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos

Well, I got rid of () ->, but I have no typos. I've typed it correctly, but I still have this:

[eggpasta]

 

2 minutes ago, Skullblade said:

Well, I got rid of () ->, but I have no typos. I've typed it correctly, but I still have this:

You have an extra unnecessary bracket after p_22045_0_ 

also you still dont need the the check if it's embercleave because the method can only fire if it's embercleave so remove the check

Edited May 6, 2021 by eggpasta

[Skullblade]

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

[Skullblade]

14 minutes ago, eggpasta said:

 

You have an extra unnecessary bracket after p_22045_0_ 

also you still dont need the the check if it's embercleave because the method can only fire if it's embercleave so remove the check

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

[poopoodice]

Why do you have your "on-hit effect" code located in the lambda? It will only be triggered upon item break.

Also the easiest way to do it is just set the target on fire and then return super, two lines of code.

 

[eggpasta]

 

remove event.getEntity() from it and change it to p_77644_3_ and also as @poopoodice said , move the fire code out of the lambda like so

      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
      });
      p_77644_3_.setSecondsOnFire(10);

 

 

Edited May 6, 2021 by eggpasta

[eggpasta]

14 minutes ago, Skullblade said:

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

 

Just now, eggpasta said:

 

remove event.getEntity() from it and change it to p_77644_3_ and also as @poopoodice said , move the fire code out of the lambda like so

      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
      });
      p_77644_3_.setSecondsOnFire(10);

 

 

 

[Skullblade]

Nice! (I didn't really know how Lambda worked before, so that was really helpful.)

Well, I tested it, as all the errors were fixed (i figured out the last few on their own, they were either in the wrong place or were no longer necessary). I ran the client, and Embercleave didn't set anything on fire...

[eggpasta]

26 minutes ago, Skullblade said:

Nice! (I didn't really know how Lambda worked before, so that was really helpful.)

Well, I tested it, as all the errors were fixed (i figured out the last few on their own, they were either in the wrong place or were no longer necessary). I ran the client, and Embercleave didn't set anything on fire...

Hmm ok well it's a start. so we can know if the method is triggering, add System.out.println("Triggered") Under the fire code and then run the code and check the logs for Tr

[Skullblade]

42 minutes ago, eggpasta said:

Hmm ok well it's a start. so we can know if the method is triggering, add System.out.println("Triggered") Under the fire code and then run the code and check the logs for Tr

I created a new world, spawned a Vindicator, and hit it with Embercleave. It took the right amount of damage, but it wasn't set on fire. Also, I checked the logs and there was nothing.

[poopoodice]

Post your code.

[Skullblade]

3 minutes ago, poopoodice said:

Post your code.

How much and what parts?

[poopoodice]

All parts that are related to the item.

[Skullblade]

12 hours ago, poopoodice said:

All parts that are related to the item.

Ok, here it is. Keep in mind that I renamed FlamingSword.java to Embercleave.java for 1, troubleshooting, and 2, I don't intend to reuse the exact code for any other item, so I gave it its final name and I'll just take pieces of it I need for other items later.

[Skullblade]

19 hours ago, poopoodice said:

All parts that are related to the item.

I could still use your help...

[poopoodice]

Well.. I have no idea why it doesn't work, and I don't see any problems except you should set a max damage (durability) in your item properties, and your entity2 is in fact the attacker. Entity1 is the target.

[Skullblade]

22 minutes ago, poopoodice said:

Well.. I have no idea why it doesn't work, and I don't see any problems except you should set a max damage (durability) in your item properties, and your entity2 is in fact the attacker. Entity1 is the target.

You absolute genius. I had been testing in creative, so there was no way for me to get set on fire to know that. Thank you so much for all of the help. You too eggpasta.