[1.16] Entities won't detect right or left click

[kiou.23]

I have added some entities, and am trying to detect right/hit clicks, and left clicks. however none of them seem to trigger when I click the entity. I can confirm that I was clicking inside the entity hitbox

Interact Listener:

@SubscribeEvent
  public static void onEntityInteraction(PlayerInteractEvent.EntityInteract e) {
    if (e.getWorld().isRemote()) return;

    if (!(e.getTarget() instanceof DiceEntity)) return;
      
    DiceEntity dice = (DiceEntity)e.getTarget();
    ItemStack diceItem = dice.getItem().copy();

    dice.remove();
    
    e.getPlayer().addItemStackToInventory(diceItem);
  }

Hit Override:

@Override
  public boolean hitByEntity(Entity entity) {
    Main.LOGGER.info(this.getName().getString() + " was hit by " + entity.getName().getString());

    return super.hitByEntity(entity);
  }

 

repo: github.com/jvcmarcenes/dicehoard

[vemerion]

3 hours ago, kiou.23 said:

however none of them seem to trigger when I click the entity

Since you are registering an instance of the Main class to the event buss, you need to remove the static keyword on the onEntityInteraction() method. In addition to that, you also need to override canBeCollidedWith() in your entity class. This should resolve both your issues.

 

[kiou.23]

6 hours ago, vemerion said:

Since you are registering an instance of the Main class to the event buss, you need to remove the static keyword on the onEntityInteraction() method. In addition to that, you also need to override canBeCollidedWith() in your entity class. This should resolve both your issues.

That did it, thanks!

[vemerion]

3 hours ago, kiou.23 said:

That did it, thanks!

No problem, glad I could help

Interesting mod idea, adding dice to Minecraft! Do you have any plans to add functionality/some effect when the dice lands on different numbers?

[kiou.23]

8 hours ago, vemerion said:

No problem, glad I could help

Interesting mod idea, adding dice to Minecraft! Do you have any plans to add functionality/some effect when the dice lands on different numbers?

I wasn't thinking of it! cool idea, it could be like lucky blocks