[1.16.5] Creating custom damage source to allow custom death messages

[Novality]

@Override
	public boolean onLeftClickEntity(ItemStack stack, PlayerEntity player, Entity entity) {
		float health = ((LivingEntity) entity).getMaxHealth();
		return entity.hurt(DamageSource.OUT_OF_WORLD, health);
	}

I have this current code above ^

I know there is a way to create my own damage source, but I couldn't find a way to have it deal void damage. Also, how would I go about specifying in the lang file to add a new death message?

If anyone could point me in the right direction that would be great.

[Luis_ST]

  On 7/22/2021 at 2:42 PM, Novality said:

I know there is a way to create my own damage source,

Expand  

just create a new DamageSource with:

 new DamageSource(name)

 

  On 7/22/2021 at 2:42 PM, Novality said:

but I couldn't find a way to have it deal void damage.

Expand  

what did you mean by "deal void damage"?
-> you already damage the Entity via Void

 

  On 7/22/2021 at 2:42 PM, Novality said:

Also, how would I go about specifying in the lang file to add a new death message?

Expand  

use this for the death message without player:

"death.attack.name": "%1$s message", -> %1$s, will replace with the player name

and this with player:

"death.attack.name.player": "%1$s message %2$s", -> %1$s, target and %2$s is the attacker

 

Note: DamageSource are not namespaced save so add your mod id to name of a DamageSource to prevent problems with other mods

[Novality]

  On 7/22/2021 at 2:58 PM, Luis_ST said:

what did you mean by "deal void damage"?
-> you already damage the Entity via Void

Expand  

If I create my own damagesource i no longer will need to damage it with "entity.hurt(DamageSource.OUT_OF_WORLD, health);" right? Otherwise that'll kill the entity and I wont get the death message I want. Using "new DamageSource(name)" how can I specify that it should deal OUT_OF_WORLD damage?

[Novality]

  On 7/22/2021 at 3:17 PM, diesieben07 said:

What? Either it's out of world damage or it's not. It cannot be both.

What do you want to achieve?

Expand  

I want to deal void damage to an entity (which I've already done).
If it's a player that is killed, I want to override the "Player fell out of the world." death message and implement my own.

[uSkizzik]

  On 7/22/2021 at 3:20 PM, Novality said:

I want to deal void damage to an entity (which I've already done).
If it's a player that is killed, I want to override the "Player fell out of the world." death message and implement my own.

Expand  

If you want to deal void damage (it's important because some entities like the wither check for it) and you want a custom death message, then you can just add the two lines below to your language file and customize them however you want. I'm not sure if this is really a good idea but it does work.

"death.attack.outOfWorld": "%1$s fell out of the world",
"death.attack.outOfWorld.player": "%1$s didn't want to live in the same world as %2$s"

As Luis_ST said, %1$s is the player's name and %2$s is the attacker entity's name.

[Luis_ST]

  On 7/22/2021 at 3:20 PM, Novality said:

I want to deal void damage to an entity (which I've already done).
If it's a player that is killed, I want to override the "Player fell out of the world." death message and implement my own.

Expand  

the best way would be to create your own DamageSource like:

DamageSource VOID = new DamageSource(MOD_ID + "_void");

and add your own death message, e.g.:

"death.attack.mod_id_void": "%1$s killed with void",
"death.attack.mod_id_void.player": "%1$s killed himself with void whilst fighting %2$s"

 

[Novality]

  On 7/22/2021 at 6:08 PM, Luis_ST said:

the best way would be to create your own DamageSource like:

DamageSource VOID = new DamageSource(MOD_ID + "_void");

and add your own death message, e.g.:

"death.attack.mod_id_void": "%1$s killed with void",
"death.attack.mod_id_void.player": "%1$s killed himself with void whilst fighting %2$s"

 

Expand  

Thank you. Disappointed though that this won't deal OUT_OF_WORLD damage but it's still pog.