[1.16.5] What is proper way to set up custom loot table

[CatGray]

Hello!

That topic was discussed a lot there but I still can't find a solution.
I have searched through a lot of topics here and even more links in google but I still can't get how to set up custom loot table.

I have tried to change loot in bonus chest as a training before realizing an initial idea but without success. 

I have tried some ways I have found in my searches:
1) set up new loot table on LootTableLoadEvent: chest spawned empty; after some searches I have found that way is kind of deprecated and unwelcome;
2) some answers was like "just put json in right folder"; I have put my json (I will paste it lower) at src\main\resources\data\cupiditas\loot_tables\chests\spawn_bonus_chest.json - that did nothing, the chest was neither empty nor filled with desired items.
3) I guess most proper way to do that is mightly Loot Modification. I have pretty clearely got how to use it with items, but it's not clear for me how to use it with chests and I haven't found any examples with chests.

My JSON:

Spoiler

{
  "pools": [{
    "rolls": 1,
    "entries": [{
      "type": "item",
      "name": "minecraft:diamond_block",
      "weight": 15,
      "functions": [{
        "function": "set_count",
        "count": {
          "min": 11,
          "max": 25
        }
      }
      ]
    }, {
      "type": "item",
      "name": "minecraft:diamond",
      "weight": 2,
      "functions": [{
        "function": "set_count",
        "count": {
          "min": 8,
          "max": 19
        }
      }
      ]
    }
    ]
  }
  ]
}

 

I would really appreciate if you point me to the right direction.

Thank you in advance!

[Draco18s]

19 minutes ago, CatGray said:

) some answers was like "just put json in right folder"; I have put my json (I will paste it lower) at src\main\resources\data\cupiditas\loot_tables\chests\spawn_bonus_chest.json - that did nothing, the chest was neither empty nor filled with desired items.

You still need to reference the loot table somewhere in your code.

Blocks are automatically linked to a loot table with the correct name, but chest and chest contents are special and need to be explicitly mention where to find their loot table.

Edited September 10, 2021 by Draco18s

[CatGray]

Well, could you please share some example or more detailed explanation?

I have done some research after I had read your answer. And I have found that there are exist data providers but I have not found any examples of using that mechanism for changing chest loot tables.

I have tried to implement it by myself but then I struggled. In ChestLootTables class which I have tried to extend that use resource location (path to loot table file I suppose) but it also build that loot table by that own with some kind of builder. So I can't get wheter I should use loot table json file or just built it in code in some way.

I don't understand anything at all now.

[Luis_ST]

is the chest a custom one or the vanilla?

[CatGray]

I'm currently trying to change vanilla's bonus chest loot.

[Luis_ST]

you can replace the LootTable using a datapack (for vanilla),
use the following path in your data folder of your mod:
data/minecraft/loot_tables/chests/spawn_bonus_chest.json

[CatGray]

OMG! That worked! Thank you! That was so simple and stupid... I have spent a day for searches...

Thank you so much!

Well, what if I want to change not vanilla chest? Like, chest of another mod? Or if I even want to make my own chest? 

Edited September 11, 2021 by CatGray

[Luis_ST]

37 minutes ago, CatGray said:

Well, what if I want to change not vanilla chest? Like, chest of another mod?

i think you can use the same way, but i have no idea whats happen when the other mod is not installed

38 minutes ago, CatGray said:

Or if I even want to make my own chest?

if you extends the vanilla chest you can set the loot table via setLootTable

[Draco18s]

1 hour ago, CatGray said:

Like, chest of another mod?

Put the correctly named loot table in the correct folder.

In this case the reason your attempts didn't work was because you put the loot table in {your_mod_id} directory not the {minecraft} directory.

1 hour ago, CatGray said:

Or if I even want to make my own chest? 

You have to make your chest block return the correct Resource Location. Look at the vanilla chest for examples.

[CatGray]

Thank you all so much!