max2461 Posted November 3, 2021 Posted November 3, 2021 It has been a long time since I have modded for Minecraft, and despite my research I cannot find methods to replace the ones I used back in 1.14.4. I know the mappings have changed and everything, so its a bit of a learning curve. _________________________________________________________________________________________________________ Quick 'functionality' summary: _________________________________________________________________________________________________________ [On Item Right Click] If Player is sneaking: - Store Players Position in NBT. - Store Players Dimension ID in NBT. - Changes Item's Display Name + Color Depending on Dimension ID. - Adds Stored Information to Items Tooltip. If Player is not sneaking: If Item has Stored Data & Player is in the same Dimension as the items stored Dimension ID: - Teleport the player to the coordinates stored. - Item 'Breaks' and is replaced with a different item. _________________________________________________________________________________________________________ Old Code _________________________________________________________________________________________________________ @Override public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ){ if(playerIn.isSneaking()){ if(stack.getTagCompound() == null){ stack.setTagCompound(new NBTTagCompound()); } } NBTTagCompound nbt = new NBTTagCompound(); nbt.setInteger("dim", playerIn.dimension); nbt.setInteger("posX", pos.getX()); nbt.setInteger("posY", pos.getY()+1); nbt.setInteger("posZ", pos.getZ()); stack.getTagCompound().setTag("coords", nbt); // TO-DO: Different ChatFormatting for each Dimension stack.setStackDisplayName(EnumChatFormatting.DARK_RED + "Teleport Device"); } return false; } @Override public ItemStack onItemRightClick(ItemStack stack, World worldIn, EntityPlayer playerIn){ if(!playerIn.isSneaking()){ if(stack.getTagCompound() != null){ NBTTagCompound nbt = (NBTTagCompound) stack.getTagCompound().getTag("coords"); int posX = nbt.getInteger("posX"); int posY = nbt.getInteger("posY"); int posZ = nbt.getInteger("posZ"); playerIn.setPosition(posX, posY, posZ); stack.getTagCompound().removeTag("coords"); stack.clearCustomName(); playerIn.addPotionEffect(new PotionEffect(Potion.regeneration.id,30,60)); playerIn.addPotionEffect(new PotionEffect(Potion.blindness.id,90,60)); playerIn.addPotionEffect(new PotionEffect(Potion.confusion.id,90,60)); playerIn.addPotionEffect(new PotionEffect(Potion.resistance.id,50,500)); if(!playerIn.capabilities.isCreativeMode){ playerIn.inventory.setInventorySlotContents(playerIn.inventory.currentItem,new ItemStack(ModItems.defectiveHistory)); } } } return stack; } @Override @SideOnly(Side.CLIENT) public void addInformation(ItemStack stack, EntityPlayer playerIn, List toolTip, boolean advanced) { if(stack.getTagCompound() != null){ if(stack.getTagCompound().hasKey("coords")){ NBTTagCompound nbt = (NBTTagCompound) stack.getTagCompound().getTag("coords"); int dim = nbt.getInteger("dim"); int posX = nbt.getInteger("posX"); int posY = nbt.getInteger("posY"); int posZ = nbt.getInteger("posZ"); toolTip.add(EnumChatFormatting.DARK_GREEN + "Dim: " + dim + " X: " + posX + " Y: " + posY + " Z: " + posZ); } } } _________________________________________________________________________________________________________ New [In Progress] Code _________________________________________________________________________________________________________ public void NullCheck(ItemStack stack){ if(stack.getTag() == null){ stack.setTag(new CompoundTag()); } } public CompoundTag GetOrCreateData(ItemStack s){ NullCheck(s); if (s.getTag().contains("LocationData")) { return s.getTag().get("LocationData"); } return new CompoundTag(); } public CompoundTag DataTag(ItemStack s, Vec3 p, String w){ CompoundTag data = GetOrCreateData(s); data.putDouble("x", p.x); data.putDouble("y", p.y); data.putDouble("z", p.z); data.putString("world", w); return data; } /* TEST FUNCTION */ public String Test_GetDimension(Player player){ return player.level.dimension().location().toString() } @Override public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { ItemStack stack = pPlayer.getItemInHand(pUsedHand); Vec3 Pos = pPlayer.position(); if (pPlayer.isCrouching()){ CompoundTag data = DataTag(stack, Pos, Test_GetDimension(pPlayer)); stack.getTag().put("LocationData", data); stack.setHoverName((new TextComponent("Teleport Device")).withStyle(ChatFormatting.DARK_RED)); } return super.use(pLevel, pPlayer, pUsedHand); } _________________________________________________________________________________________________________ Summary _________________________________________________________________________________________________________ [ Dimension ID ] I know that the Dimension ID is no longer stored in the Entity, so I'm looking for a new way to get what Dimension the player is in. The original idea was to teleport the player to the Dimension as well as the coordinates, but I couldn't get that to work out. So now, it's to prevent the device from teleporting you to the stored coordinates unless you're in that Dimension. In the old code, i would use the Number ID of the Dimension, in the attempted new code, I was trying to use the folder / location path name. { "overworld", "the_nether", "the_end' }. But all it did was return blank for me. [Tooltip / Hover Text] I know I tried using "Item#appendHoverText" and using List<Component>, but it didn't work at all and I can't find the Test_Function for it in my notes. From memory, it was something like: this.appendHoverText(stack, pLevel, new ArrayList<Component>().add(new TextComponent("Test")), TooltipFlag.Default.NORMAL); _________________________________________________________________________________________________________ I hope that all made sense lol. If you happen to know how i could get around this, I would be very grateful. Quote
MFMods Posted November 5, 2021 Posted November 5, 2021 for tooltip, override appendHoverText in your item class. override, don't call. Quote
max2461 Posted November 5, 2021 Author Posted November 5, 2021 14 minutes ago, MFMods said: for tooltip, override appendHoverText in your item class. override, don't call. Oh, wow i feel like an idiot. That makes so much more sense lol. Thanks! Quote
Draco18s Posted November 5, 2021 Posted November 5, 2021 Also, you should use Capabilities. And key your NBT tags with your mod ID. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
max2461 Posted November 5, 2021 Author Posted November 5, 2021 7 minutes ago, Draco18s said: Also, you should use Capabilities. Don't think I have heard of 'Capabilities', what exactly are they? Quote And key your NBT tags with your mod ID. True, true. Quote
Luis_ST Posted November 5, 2021 Posted November 5, 2021 43 minutes ago, max2461 said: Don't think I have heard of 'Capabilities', what exactly are they? https://mcforge.readthedocs.io/en/latest/datastorage/capabilities/ https://forge.gemwire.uk/wiki/Capabilities Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.