Jump to content

[1.17.1] Need help with 'remaking / updating' one of my old items from 1.14.4


Recommended Posts

Posted

It has been a long time since I have modded for Minecraft, and despite my research I cannot find methods to replace the ones I used back in 1.14.4. I know the mappings have changed and everything, so its a bit of a learning curve.
_________________________________________________________________________________________________________

                                                                      Quick 'functionality' summary:
_________________________________________________________________________________________________________

[On Item Right Click]

   If Player is sneaking:
      - Store Players Position in NBT.
      - Store Players Dimension ID in NBT.
      - Changes Item's Display Name + Color Depending on Dimension ID.
      - Adds Stored Information to Items Tooltip.

   If Player is not sneaking:
      If Item has Stored Data & Player is in the same Dimension as the items stored Dimension ID:
         - Teleport the player to the coordinates stored.
         - Item 'Breaks' and is replaced with a different item.

_________________________________________________________________________________________________________

                                                                                             Old Code
_________________________________________________________________________________________________________

	@Override
	public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ){
    	if(playerIn.isSneaking()){
			if(stack.getTagCompound() == null){
    		   stack.setTagCompound(new NBTTagCompound());
    	   }
        }
    	NBTTagCompound nbt = new NBTTagCompound();
    	nbt.setInteger("dim", playerIn.dimension);
    	nbt.setInteger("posX", pos.getX());
    	nbt.setInteger("posY", pos.getY()+1);
    	nbt.setInteger("posZ", pos.getZ());
    	stack.getTagCompound().setTag("coords", nbt);
		// TO-DO: Different ChatFormatting for each Dimension
    	stack.setStackDisplayName(EnumChatFormatting.DARK_RED + "Teleport Device");
       }
		return false;
    }
	
	@Override
    public ItemStack onItemRightClick(ItemStack stack, World worldIn, EntityPlayer playerIn){
		if(!playerIn.isSneaking()){
		if(stack.getTagCompound() != null){
			NBTTagCompound nbt = (NBTTagCompound) stack.getTagCompound().getTag("coords");
			int posX = nbt.getInteger("posX");
			int posY = nbt.getInteger("posY");
			int posZ = nbt.getInteger("posZ");
			playerIn.setPosition(posX, posY, posZ);
			stack.getTagCompound().removeTag("coords");
			stack.clearCustomName();
			playerIn.addPotionEffect(new PotionEffect(Potion.regeneration.id,30,60));
			playerIn.addPotionEffect(new PotionEffect(Potion.blindness.id,90,60));
			playerIn.addPotionEffect(new PotionEffect(Potion.confusion.id,90,60));
			playerIn.addPotionEffect(new PotionEffect(Potion.resistance.id,50,500));
			if(!playerIn.capabilities.isCreativeMode){
			   playerIn.inventory.setInventorySlotContents(playerIn.inventory.currentItem,new ItemStack(ModItems.defectiveHistory));
			}
			
		}
		}
        return stack;
    }
	
	@Override
	@SideOnly(Side.CLIENT)
    public void addInformation(ItemStack stack, EntityPlayer playerIn, List toolTip, boolean advanced) {
		if(stack.getTagCompound() != null){
			if(stack.getTagCompound().hasKey("coords")){
				NBTTagCompound nbt = (NBTTagCompound) stack.getTagCompound().getTag("coords");
				int dim = nbt.getInteger("dim");
				int posX = nbt.getInteger("posX");
				int posY = nbt.getInteger("posY");
				int posZ = nbt.getInteger("posZ");
				toolTip.add(EnumChatFormatting.DARK_GREEN + "Dim: " + dim + " X: " + posX + " Y: " + posY + " Z: " + posZ);
			}
		}
	}

_________________________________________________________________________________________________________

                                                                                   New [In Progress] Code
_________________________________________________________________________________________________________

public void NullCheck(ItemStack stack){
  if(stack.getTag() == null){ stack.setTag(new CompoundTag()); }
}

public CompoundTag GetOrCreateData(ItemStack s){
  NullCheck(s);
  if (s.getTag().contains("LocationData")) {
    return s.getTag().get("LocationData");
  }
  return new CompoundTag();
}

public CompoundTag DataTag(ItemStack s, Vec3 p, String w){
  CompoundTag data = GetOrCreateData(s);
  data.putDouble("x", p.x);
  data.putDouble("y", p.y);
  data.putDouble("z", p.z);
  data.putString("world", w);
  return data;
}

/*  TEST FUNCTION  */
public String Test_GetDimension(Player player){
  return player.level.dimension().location().toString()
}

@Override
public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) {
  ItemStack stack = pPlayer.getItemInHand(pUsedHand);
  Vec3 Pos = pPlayer.position();
  
  if (pPlayer.isCrouching()){
    CompoundTag data = DataTag(stack, Pos, Test_GetDimension(pPlayer));
    stack.getTag().put("LocationData", data);
    stack.setHoverName((new TextComponent("Teleport Device")).withStyle(ChatFormatting.DARK_RED));
  }
  
  return super.use(pLevel, pPlayer, pUsedHand);
}


 

_________________________________________________________________________________________________________

                                                                                           Summary
_________________________________________________________________________________________________________

[ Dimension ID ]
I know that the Dimension ID is no longer stored in the Entity, so I'm looking for a new way to get what
Dimension the player is in. The original idea was to teleport the player to the Dimension as well as
the coordinates, but I couldn't get that to work out. So now, it's to prevent the device from teleporting you
to the stored coordinates unless you're in that Dimension.

In the old code, i would use the Number ID of the Dimension, in the attempted new code, I was trying to use
the folder / location path name. { "overworld", "the_nether", "the_end' }. But all it did was return blank for me.

[Tooltip / Hover Text]
I know I tried using "Item#appendHoverText" and using List<Component>, but it didn't work at all and I can't
find the Test_Function for it in my notes.

From memory, it was something like:

this.appendHoverText(stack, pLevel, new ArrayList<Component>().add(new TextComponent("Test")), TooltipFlag.Default.NORMAL);

_________________________________________________________________________________________________________

 

I hope that all made sense lol. If you happen to know how i could get around this, I would be very grateful.

Posted
14 minutes ago, MFMods said:

for tooltip, override appendHoverText in your item class. override, don't call.

Oh, wow i feel like an idiot. That makes so much more sense lol. Thanks! :)

Posted

Also, you should use Capabilities. And key your NBT tags with your mod ID.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
7 minutes ago, Draco18s said:

Also, you should use Capabilities.

Don't think I have heard of 'Capabilities', what exactly are they?
 

Quote

And key your NBT tags with your mod ID.

True, true.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • that happens every time I enter a new dimension.
    • This is the last line before the crash: [ebwizardry]: Synchronising spell emitters for PixelTraveler But I have no idea what this means
    • What in particular? I barely used that mod this time around, and it's never been a problem in the past.
    • Im trying to build my mod using shade since i use the luaj library however i keep getting this error Reason: Task ':reobfJar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. So i try adding reobfJar.dependsOn shadowJar  Could not get unknown property 'reobfJar' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. my gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'com.github.johnrengelman.shadow' version '7.1.2' id 'org.spongepowered.mixin' version '0.7.+' } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'org.spongepowered.mixin' apply plugin: 'com.github.johnrengelman.shadow' version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) //jarJar.enable() println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: mapping_channel, version: mapping_version copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' arg "-mixin.config=derp.mixin.json" mods { "${mod_id}" { source sourceSets.main } } } client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { workingDirectory project.file('run-data') args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { flatDir { dirs './libs' } maven { url = "https://jitpack.io" } } configurations { shade implementation.extendsFrom shade } dependencies { minecraft "net.minecraftforge:forge:${minecraft_version}-${forge_version}" implementation 'org.luaj:luaj-jse-3.0.2' implementation fg.deobf("com.github.Virtuoel:Pehkui:${pehkui_version}") annotationProcessor 'org.spongepowered:mixin:0.8.5:processor' minecraftLibrary 'luaj:luaj-jse:3.0.2' shade 'luaj:luaj-jse:3.0.2' } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"), "TweakClass" : "org.spongepowered.asm.launch.MixinTweaker", "TweakOrder" : 0, "MixinConfigs" : "derp.mixin.json" ]) } rename 'mixin.refmap.json', 'derp.mixin-refmap.json' } shadowJar { archiveClassifier = '' configurations = [project.configurations.shade] finalizedBy 'reobfShadowJar' } assemble.dependsOn shadowJar reobf { re shadowJar {} } publishing { publications { mavenJava(MavenPublication) { artifact jar } } repositories { maven { url "file://${project.projectDir}/mcmodsrepo" } } } my entire project:https://github.com/kevin051606/DERP-Mod/tree/Derp-1.0-1.20
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.