Jump to content

[1.16.5]Overriding vanilla Block doesn't work as expected


Cratthorax

Recommended Posts

Good Morning,

I tried overriding one of the vanilla rock blocks according to instructions in this old thread, but failed for the same reason the org TM did, even though I got a tiny bit farther than he did.

I can remove the original block entirely from world spawn, and replace it with custom version, which I want to prevent due to following up workload(adapting recipes etc. to custom block).

What I tried solving the issue/actually making replacing(partially) work:

1. I had to use the original Forge variant of registering the block in main class, like that:

which actually did use the custom granite block as replacer(not exactly illustrated in the old thread), but didn't consider it on world feature generation...

 
    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        
        @SubscribeEvent
        public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegEvt) {
            blockRegEvt.getRegistry().register(new BlockGranite(null).setRegistryName(new ResourceLocation("minecraft", "granite")));
        }
        
    }

 

2. I then believed it was due to not using correct path variables for assets texture/models/blockstates etc., so I created missing asset packets for both, vanilla asset path, and my mod path. This also did not fix the issue with creating holes filled up with Items.AIR on world feature generation.

3. I then tried to remove the vanilla granite block during feature generation, and reimported it after with my replacement set up, during feature generation as well(according to @Luis_ST advice). But the holes were still there, only this time I got my replaced granite block spawned as well.

What do I want to achieve(asking myself and you in hope maybe there's a better solution)?

Mojang found it a good idea, to give one of the hardest rock materials on this planet, the .harvestLevel(soft as a pillow), so I can harvest it with a wooden pickaxes(which technically is even worth, but doesn't matter since wooden "pickaxe" tools do not exist in my mod). I really just want to compare harvestLevel of any of my tools, against the harvestLevel of the targetBlock, so I can automatically disallow harvesting it, if the tool doesn't match the harvestLevel(which for whatever reason does not work as intended in 1.16.5 Minecraft).

Edit: and before you shout "doPlayerHarvestCheck". Yes, I do that!

 
    @SubscribeEvent
    public static void doPlayerHarvestCheck(PlayerEvent.HarvestCheck event) {
        
       ...
            
        int toolLevel = itemRef.getHarvestLevel(heldItems, blockTool, playerRef, blockState);
    	int blockLevel = targetBlock.getHarvestLevel(blockState);
       
            if((toolLevel < blockLevel) && (toolLevel >= 0)) {
                event.setCanHarvest(false);
                playerRef.sendStatusMessage(new TranslationTextComponent("This Material is to hard for your Tool!"), true);
            } else {
                event.setCanHarvest(true);
            }
        }
    }

 

Edit2: Also, why are there Manga Comic Girls, on the right upper corner of my Monitor, stating how can it be that big?(whatever "it" is?)

Edited by Cratthorax
Link to comment
Share on other sites

2 hours ago, Cratthorax said:

3. I then tried to remove the vanilla granite block during feature generation, and reimported it after with my replacement set up, during feature generation as well(according to @Luis_ST advice). But the holes were still there, only this time I got my replaced granite block spawned as well.

What do I want to achieve(asking myself and you in hope maybe there's a better solution)?

show the code your use for this

2 hours ago, Cratthorax said:

Mojang found it a good idea, to give one of the hardest rock materials on this planet, the .harvestLevel(soft as a pillow), so I can harvest it with a wooden pickaxes(which technically is even worth, but doesn't matter since wooden "pickaxe" tools do not exist in my mod). I really just want to compare harvestLevel of any of my tools, against the harvestLevel of the targetBlock, so I can automatically disallow harvesting it, if the tool doesn't match the harvestLevel(which for whatever reason does not work as intended in 1.16.5 Minecraft).

Edit: and before you shout "doPlayerHarvestCheck". Yes, I do that!

is the Event called?, use debugger to check the values in the condition

  • Like 1
Link to comment
Share on other sites

The final solution was to learn how to register and use a loot serializer, like this:

 
        @SubscribeEvent
        public static void onModifierSerializersRegistry(final RegistryEvent.Register<GlobalLootModifierSerializer<?>> evt) {
            evt.getRegistry().register(new RelEqtLootModifier.Serializer().setRegistryName(new ResourceLocation(MODID, "stone_replace")));
        }   

 

...and then extend on LootModifier like this:

 
	public class RelEqtLootModifier extends LootModifier {
    
    private final int numDropsToConvert;
    private final Item itemToCheck;
    private final Item itemReward;
    
    public RelEqtLootModifier(ILootCondition[] conditionsIn, int numDrops, Item itemCheck, Item reward) {
        super(conditionsIn);
        numDropsToConvert = numDrops;
        itemToCheck = itemCheck;
        itemReward = reward;
    }
	    @Nonnull
    @Override
    public List<ItemStack> doApply(List<ItemStack> generatedLoot, LootContext context) {
	        int numDrops = 0;
        for (ItemStack stack : generatedLoot) {
            if (stack.getItem() == itemToCheck)
                numDrops += stack.getCount();
        }
        if (numDrops >= numDropsToConvert) {
            generatedLoot.removeIf(x -> x.getItem() == itemToCheck);
            generatedLoot.add(new ItemStack(itemReward, (numDrops / numDropsToConvert)));
            numDrops = numDrops % numDropsToConvert;
            if (numDrops > 0)
                generatedLoot.add(new ItemStack(itemToCheck, numDrops));
        }
        return generatedLoot;
    }
	    public static class Serializer extends GlobalLootModifierSerializer<RelEqtLootModifier> {
	        @Override
        public RelEqtLootModifier read(ResourceLocation name, JsonObject object, ILootCondition[] conditionsIn) {
            int numDrops = JSONUtils.getInt(object, "numDrops");
            Item drop = ForgeRegistries.ITEMS.getValue(new ResourceLocation((JSONUtils.getString(object, "dropItem"))));
            Item stone = ForgeRegistries.ITEMS.getValue(new ResourceLocation(JSONUtils.getString(object, "replacement")));
            return new RelEqtLootModifier(conditionsIn, numDrops, drop, stone);
        }
	        @Override
        public JsonObject write(RelEqtLootModifier instance) {
            JsonObject json = makeConditions(instance.conditions);
            json.addProperty("numDrops", instance.numDropsToConvert);
            json.addProperty("dropItem", ForgeRegistries.ITEMS.getKey(instance.itemToCheck).toString());
            json.addProperty("replacement", ForgeRegistries.ITEMS.getKey(instance.itemReward).toString());
            return json;
        }
    }
}

 

The registration happens on the Mod bus(not Forge bus), in your main class's RegistryEvents.

I still can't get over the inconvenience, how cryptic the Forge Docs uses to be though.

Edited by Cratthorax
Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • During the start of my server, I get a couple of errors which I can't find the solution. The server if started Debug Log: https://paste.me/paste/e4053560-55d8-4665-778c-bcc46394a9de#07b5c63a9b61091b00182b427fe037034fd21da210d4a10c5fc5b33309cac175 Console Log: https://paste.me/paste/a63968df-f938-4360-65fa-b133e0470b7b#7decf3b6fd3e42de2376446df45fe9709144b28faaf1bd3c89299f343e78c77b   Main errors:  1: [Worker-Main-2/ERROR] [minecraft/TagLoader]: Couldn't load tag [dimensional_expansion:end_rose (from dimensional_expansion-0.7a.jar)] as it is missing following references: dimensional_expansion:end_rose (from dimensional_expansion-0.7a.jar) 2: [main/ERROR] [minecraft/RecipeManager]: Parsing error loading recipe deeperdarker:sculk_affinity
    • Guys I am really at my wits end with this stupid Forge Version I am TRYING to play the latest update of the FNaF Mod updated to 1.19.2. But for whatever reason, everytime I TRY to open the Forge Version, it keeps crashing, even if I have ABSOUTLETLY ZERO Mods Installed. It keeps giving me the Exit Code of 1 Someone on the FNaF Mod Discord Server states that Exit Code 1 relates to Memory issues, but I have ALOT of Storage on my Computer still I am at my witsend with what is causing this and how it can be fixed  this is what shows in the latest.log (If this isnt where you guys can find what is causing this, then tell me where I CAN find it)  [03Jun2023 16:36:35.256] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, grasshopperjb, --version, 1.19.2-forge-43.2.0, --gameDir, C:\Users\jbaut\AppData\Roaming\.minecraft, --assetsDir, C:\Users\jbaut\AppData\Roaming\.minecraft\assets, --assetIndex, 1.19, --uuid, c2896eae7c544faa9b7e0da7eb635b65, --accessToken, ????????, --clientId, NTMzN2Q0ZTctMjA2ZS00NzI1LTkzNGUtNDk0YzA4ZTY0Yzhj, --xuid, 2535428451400008, --userType, msa, --versionType, release, --launchTarget, forgeclient, --fml.forgeVersion, 43.2.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [03Jun2023 16:36:35.261] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.3 by Microsoft; OS Windows 10 arch amd64 version 10.0 [03Jun2023 16:36:35.359] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2397!/ Service=ModLauncher Env=CLIENT [03Jun2023 16:36:35.391] [main/WARN] [net.minecraftforge.fml.loading.FMLConfig/CORE]: Configuration file C:\Users\jbaut\AppData\Roaming\.minecraft\config\fml.toml is not correct. Correcting [03Jun2023 16:36:35.397] [main/WARN] [net.minecraftforge.fml.loading.FMLConfig/CORE]: Incorrect key [disableOptimizedDFU] was corrected from null to true [03Jun2023 16:36:35.573] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\fmlcore\1.19.2-43.2.0\fmlcore-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.578] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\javafmllanguage\1.19.2-43.2.0\javafmllanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.582] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\lowcodelanguage\1.19.2-43.2.0\lowcodelanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.587] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\jbaut\AppData\Roaming\.minecraft\libraries\net\minecraftforge\mclanguage\1.19.2-43.2.0\mclanguage-1.19.2-43.2.0.jar is missing mods.toml file [03Jun2023 16:36:35.655] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: No dependencies to load found. Skipping! [03Jun2023 16:36:36.504] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeclient' with arguments [--version, 1.19.2-forge-43.2.0, --gameDir, C:\Users\jbaut\AppData\Roaming\.minecraft, --assetsDir, C:\Users\jbaut\AppData\Roaming\.minecraft\assets, --uuid, c2896eae7c544faa9b7e0da7eb635b65, --username, grasshopperjb, --assetIndex, 1.19, --accessToken, ????????, --clientId, NTMzN2Q0ZTctMjA2ZS00NzI1LTkzNGUtNDk0YzA4ZTY0Yzhj, --xuid, 2535428451400008, --userType, msa, --versionType, release] [03Jun2023 16:36:39.314] [pool-3-thread-1/INFO] [net.minecraft.util.datafix.DataFixers/]: Building unoptimized datafixer [03Jun2023 16:36:40.660] [Render thread/WARN] [net.minecraft.server.packs.VanillaPackResources/]: Assets URL 'union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.19.2-20220805.130853/client-1.19.2-20220805.130853-srg.jar%23151!/assets/.mcassetsroot' uses unexpected schema [03Jun2023 16:36:40.662] [Render thread/WARN] [net.minecraft.server.packs.VanillaPackResources/]: Assets URL 'union:/C:/Users/jbaut/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.19.2-20220805.130853/client-1.19.2-20220805.130853-srg.jar%23151!/data/.mcassetsroot' uses unexpected schema [03Jun2023 16:36:40.675] [Render thread/INFO] [com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService/]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [03Jun2023 16:36:41.013] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Setting user: grasshopperjb [03Jun2023 16:36:41.096] [Render thread/INFO] [net.minecraft.client.Minecraft/]: Backend library: LWJGL version 3.3.1 build 7
    • So I've created a boss mob, whether it is naturally generated or spawned by the player, after some time it despawns, what can I do so that it doesn't despawn at all? Thanks in advance
    • Hello, I'm making a mod and everything was going well until I enabled accesstransformers. After that, every gradle build attempt fails. What I tried to do to solve the problem: Deleted the forge_gradle folder several times Deleted the caches folder several times Used ./gradlew build, ./gradlew genIntellijRuns and ./gradlew --refresh-dependencies I created a new mod project with only the main file and everything goes well until the inclusion of accesstransformers. Here is the error itself: https://pastebin.com/SQhrqpzr
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.