Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

1.18.1 Creating a enchantment like fortune!

X_ZombieSlayer_X

By X_ZombieSlayer_X
in Modder Support

 Share

Recommended Posts

X_ZombieSlayer_X Tree Puncher

X_ZombieSlayer_X

Posted
Posted

Hello all,

I have create an enchantment and have registered it. It is a copy of lootBonusEnchantment(fortune) from vanilla. However it does not seem to have fortune logic applied to it. How would I add this logic to it? My plan is to override the vanilla fortune enchantment to change the logic(server side) only, that way vanilla users can connect and play on my forge server with different fortune drop rates.

Thanks

X_ZombieSlayer_X Tree Puncher

X_ZombieSlayer_X

Posted
  • Author
Posted
22 hours ago, Luis_ST said:

You have to create your own logic, since vanilla only check if it's the Fortune Enchantment (they don't use a instanceof check).

For a custom logic I would recommend you to use Global Loot Modifier

Can I use the Global Loot Modifier to modify the logic of the vanilla fortune enchantment? If fortune uses a loot table to calculate drops can I just override it?

Luis_ST Reality Controller

Luis_ST

Posted
Posted (edited)
14 hours ago, X_ZombieSlayer_X said:

Can I use the Global Loot Modifier to modify the logic of the vanilla fortune enchantment? If fortune uses a loot table to calculate drops can I just override it?

You can't

14 hours ago, X_ZombieSlayer_X said:

Could I use ILootCondition instead of a lootmodifier json?

You can't the json file is required 

Edited by Luis_ST
Draco18s Reality Controller

Draco18s

Posted
Posted (edited)
10 hours ago, Luis_ST said:

You can't

What. Yes you can. GLM run after all vanilla logic.

10 hours ago, Luis_ST said:

You can't the json file is required 

...no, the two things are unrelated.

 

11 hours ago, X_ZombieSlayer_X said:

Is there anyway to use ILootCondition? The docs reference it, but don't have anything on it. Could I use ILootCondition instead of a lootmodifier json?

ILootConditions are things that need to be true for loot things to happen. They're conditions, not loot tables or modifiers.

And no, you must use a loot modifier to modify loot.

In theory you could create a fortune-like enchantment and its own ILootCondition and then overwrite every single loot table from every single mod to add your special condition block, but that seems like a lot more work to me. And a lot less compatible.

Quote

If fortune uses a loot table

It doesn't. Also, what if someone else does the same thing you're doing, but different?

Use GLM.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Luis_ST Reality Controller

Luis_ST

Posted
Posted
2 hours ago, Draco18s said:

What. Yes you can. GLM run after all vanilla logic.

I also noticed that I wanted to change my answer, but thanks for the correction😅,
but I also realized that this could get a bit complicated, depends on how much you want to change the logic

2 hours ago, Draco18s said:

...no, the two things are unrelated.

the global_loot_modifiers.json is required iirc

Draco18s Reality Controller

Draco18s

Posted
Posted

"Required" in the sense that it's the correct way to do things to maintain mod compatibility. But loot tables are still loot tables and can still be overridden with data packs. Forge won't stop you from doing it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      Unknown Crash, Exception Ticking World

      By TileEntity · Posted

      I have no idea
    • Pixel243
      Unknown Crash, Exception Ticking World

      By Pixel243 · Posted

      that happens every time I enter a new dimension.
    • TileEntity
      Unknown Crash, Exception Ticking World

      By TileEntity · Posted

      This is the last line before the crash: [ebwizardry]: Synchronising spell emitters for PixelTraveler But I have no idea what this means
    • Pixel243
      Unknown Crash, Exception Ticking World

      By Pixel243 · Posted

      What in particular? I barely used that mod this time around, and it's never been a problem in the past.
    • Azero
      Unable to build with shadow

      By Azero · Posted

      Im trying to build my mod using shade since i use the luaj library however i keep getting this error Reason: Task ':reobfJar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. So i try adding reobfJar.dependsOn shadowJar  Could not get unknown property 'reobfJar' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. my gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'com.github.johnrengelman.shadow' version '7.1.2' id 'org.spongepowered.mixin' version '0.7.+' } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'org.spongepowered.mixin' apply plugin: 'com.github.johnrengelman.shadow' version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) //jarJar.enable() println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: mapping_channel, version: mapping_version copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' arg "-mixin.config=derp.mixin.json" mods { "${mod_id}" { source sourceSets.main } } } client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { workingDirectory project.file('run-data') args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { flatDir { dirs './libs' } maven { url = "https://jitpack.io" } } configurations { shade implementation.extendsFrom shade } dependencies { minecraft "net.minecraftforge:forge:${minecraft_version}-${forge_version}" implementation 'org.luaj:luaj-jse-3.0.2' implementation fg.deobf("com.github.Virtuoel:Pehkui:${pehkui_version}") annotationProcessor 'org.spongepowered:mixin:0.8.5:processor' minecraftLibrary 'luaj:luaj-jse:3.0.2' shade 'luaj:luaj-jse:3.0.2' } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"), "TweakClass" : "org.spongepowered.asm.launch.MixinTweaker", "TweakOrder" : 0, "MixinConfigs" : "derp.mixin.json" ]) } rename 'mixin.refmap.json', 'derp.mixin-refmap.json' } shadowJar { archiveClassifier = '' configurations = [project.configurations.shade] finalizedBy 'reobfShadowJar' } assemble.dependsOn shadowJar reobf { re shadowJar {} } publishing { publications { mavenJava(MavenPublication) { artifact jar } } repositories { maven { url "file://${project.projectDir}/mcmodsrepo" } } } my entire project:https://github.com/kevin051606/DERP-Mod/tree/Derp-1.0-1.20

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept