Search the Forums BEFORE making a new post.

How to get block entity data?

Posted April 12, 20223 yr

How can I get block entity data by position (1.18.1)?

Edited April 13, 20223 yr by Gulg

Quote

April 12, 20223 yr

Blocks don't have NBT data.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

April 13, 20223 yr

Author

Оh, sorry I meant block entity data.

Quote

3 yr3 yr Gulg changed the title to How to get block entity data?

April 13, 20223 yr

what data are you talking about, since there is a lot of data in a BE?

Quote

April 13, 20223 yr

Author

I am talking about container items.

Quote

April 13, 20223 yr

you can use BaseContainerBlockEntity#getCapability with CapabilityItemHandler.ITEM_HANDLER_CAPABILITY as parameter
to get the Container of the BE as an IItemHandler

Quote

April 13, 20223 yr

Author

But I need to get BE before. I have only position.

Quote

April 13, 20223 yr

you can not get the data of a BE without having a Level,
where did you need the BE data? show your code

Quote

April 13, 20223 yr

Author

	public static <T extends BlockEntity> void tick(Level level, BlockPos pos, BlockState state, T be) {
        if (level.isClientSide()) return;
        // I want to get other BE by position which I have in other variable (otherPos)
    }

Quote

April 13, 20223 yr

you have there a Level, so you be able to get them via Level#getBlockEntity

Quote

April 13, 20223 yr

Author

It always returns null.

Quote

April 13, 20223 yr

29 minutes ago, Gulg said:

It always returns null.

what?

Quote

April 14, 20223 yr

Author

BlockEntity otherBE = level.getBlockEntity(blockEntityPos);

otherBE always null.

Edited April 14, 20223 yr by Gulg

Quote

April 14, 20223 yr

is the position load?

Quote

April 14, 20223 yr

Hi!

otherBE will return null in two cases:

1. as Luis_ST already said if the position is not loaded ( not in "render distance")

2. The block doesn't have a BlockEntitiy. You can find out if it has one by running the command /data get block <x> <y> <z> in-game. Blocks that have a BlockEntitiy are Containers, Command Blocks, Beehives, Signs and everything else that stores information without a blockstate

Sorry if my Posts are weird sometimes, I just try to help and learn as much as I can

Also: PLEASE use SPOILERS for logs!

Quote

April 14, 20223 yr

Author

The position is loaded and block has BlockEntity (chest). But it returns null.

Quote

April 14, 20223 yr

this is not possible, please show the full code

Quote

April 14, 20223 yr

Author

package com.gulgdev.mechanism.block.custom;

import com.gulgdev.mechanism.block.ModBlocks;
import net.minecraft.client.Minecraft;
import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.network.chat.TextComponent;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.Mob;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.BaseEntityBlock;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.ChestBlock;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.block.state.properties.BlockStateProperties;
import net.minecraft.world.phys.AABB;
import net.minecraft.world.phys.Vec3;
import net.minecraftforge.items.ItemStackHandler;
import oshi.util.tuples.Pair;

import java.lang.reflect.InvocationTargetException;
import java.util.*;

import static java.lang.Math.abs;

public class MotorBlockEntity extends BlockEntity {
    public static final int movingLimit = 8;
    public static final List<Block> nonMovable = Arrays.asList(
            Blocks.BEDROCK,
            Blocks.OBSIDIAN
    );

    public final ItemStackHandler items;

    public MotorBlockEntity(BlockPos pos, BlockState state) {
        super(ModBlocks.MOTOR_BLOCK_ENTITY.get(), pos, state);

        items = new ItemStackHandler(4) {
            @Override
            public ItemStack extractItem(int slot, int amount, boolean simulate) {
                return super.extractItem(slot, amount, simulate);
            }

            @Override
            public ItemStack insertItem(int slot, ItemStack stack, boolean simulate) {
                return super.insertItem(slot, stack, simulate);
            }
        };
    }

    public static <T extends BlockEntity> void tick(Level level, BlockPos pos, BlockState state, T be) {
        if (level.isClientSide()) return;
        new Thread(() -> {
            MotorBlockEntity entity = (MotorBlockEntity) be;

            Map<BlockPos, Pair<BlockState, BlockEntity>> blocks = FindStructureBlocks(level, pos, movingLimit);
            Map<BlockPos, BlockPos> moving = GetMovingMap(level, blocks, Direction.UP);//state.getValue(BlockStateProperties.FACING));
            if (moving == null) return;

            MoveStructure(level, pos, movingLimit, blocks, moving, true);
        }).start();
    }

    private static Map<BlockPos, Pair<BlockState, BlockEntity>> FindStructureBlocks(Level level, BlockPos start, int limit) {
        Map<BlockPos, Pair<BlockState, BlockEntity>> blocks = new HashMap<BlockPos, Pair<BlockState, BlockEntity>>();
        blocks.put(start, new Pair<BlockState, BlockEntity>(level.getBlockState(start), level.getBlockEntity(start)));
        for (Direction direction : Direction.values()) {
            FindingBranch(level, blocks, start, start, direction, limit);
        }
        return blocks;
    }
    private static void FindingBranch(Level level, Map<BlockPos, Pair<BlockState, BlockEntity>> blocks, BlockPos center, BlockPos start, Direction direction, int limit) {
        BlockPos pos = start.relative(direction);
        if (!(level.getBlockState(pos).isAir() || nonMovable.contains(level.getBlockState(pos).getBlock()) ||
                abs(center.getX() - pos.getX()) >= limit ||
                abs(center.getY() - pos.getY()) >= limit ||
                abs(center.getZ() - pos.getZ()) >= limit)) {
            try {
                Minecraft.getInstance().player.chat(level.getBlockEntity(pos).serializeNBT().toString());
            } catch (NullPointerException e) {
                Minecraft.getInstance().player.chat("no nbt at " + pos.toString());
            }
            blocks.put(pos, new Pair<BlockState, BlockEntity>(level.getBlockState(pos), level.getBlockEntity(pos)));
            for (Direction dir : Direction.values()) {
                if (!blocks.containsKey(pos.relative(dir))) {
                    FindingBranch(level, blocks, center, pos, dir, limit);
                }
            }
        }
    }

    private static Map<BlockPos, BlockPos> GetMovingMap(Level level, Map<BlockPos, Pair<BlockState, BlockEntity>> blocks, Direction direction) {
        Map<BlockPos, BlockPos> moving = new HashMap<BlockPos, BlockPos>();
        for (BlockPos position : blocks.keySet()) {
            BlockPos target = position.relative(direction);
            if (!level.getBlockState(target).isAir() && !blocks.containsKey(target)) return null;
            moving.put(position, target);
        }
        return moving;
    }

    private static void UpdateBlocks(Level level, BlockPos[] blocks) {
        for (BlockPos block : blocks) {
            BlockState state = level.getBlockState(block);
            if (state.getMaterial().isSolid())
                level.sendBlockUpdated(block, state, state, 0);
        }
        for (BlockPos block : blocks) {
            BlockState state = level.getBlockState(block);
            if (!state.getMaterial().isSolid())
                level.sendBlockUpdated(block, state, state, 0);
        }
    }
    private static void ClearStructure(Level level, Map<BlockPos, Pair<BlockState, BlockEntity>> blocks) {
        for (BlockPos pos : blocks.keySet()) {
            level.setBlock(pos, Blocks.AIR.defaultBlockState(), 0);
        }
        UpdateBlocks(level, blocks.keySet().toArray(new BlockPos[0]));
    }
    private static void MoveStructure(Level level, BlockPos center, int limit, Map<BlockPos, Pair<BlockState, BlockEntity>> blocks, Map<BlockPos, BlockPos> moving, boolean moveEntities) {
        ClearStructure(level, blocks);
        List<Entity> entities = null;
        if (moveEntities) {
            entities = level.getEntities(null, AABB.ofSize(new Vec3(center.getX(), center.getY(), center.getZ()), limit * 2 + 1, limit * 2 + 1, limit * 2 + 1));
        }
        for (Map.Entry<BlockPos, Pair<BlockState, BlockEntity>> entry : blocks.entrySet()) {
            BlockPos from = entry.getKey();
            BlockPos to = moving.get(from);
            BlockState blockState = entry.getValue().getA();
            BlockEntity blockEntity = entry.getValue().getB();

            if (moveEntities) {
                for (Entity entity : entities) {
                    if (to.getX() == entity.getBlockX() && from.getY() + 1 == entity.getBlockY() && to.getZ() == entity.getBlockZ()) {
                        entity.moveTo(new Vec3(to.getX(), to.getY() + 1, to.getZ()));
                    }
                }
            }

            if (blockState.getMaterial().isSolid()) {
                level.setBlock(to, blockState, 0);
                try {
                    BlockEntity be = blockEntity.getClass().getConstructor().newInstance(new Object[] { to, blockState });
                    be.deserializeNBT(blockEntity.serializeNBT());
                    level.setBlockEntity(be);
                } catch (InstantiationException | IllegalAccessException | InvocationTargetException | NoSuchMethodException | NullPointerException e) {
                    e.printStackTrace();
                }
            }
        }
        for (Map.Entry<BlockPos, Pair<BlockState, BlockEntity>> entry : blocks.entrySet()) {
            BlockPos from = entry.getKey();
            BlockPos to = moving.get(from);
            BlockState blockState = entry.getValue().getA();
            BlockEntity blockEntity = entry.getValue().getB();

            if (!blockState.getMaterial().isSolid()) {
                level.setBlock(to, blockState, 0);
                try {
                    BlockEntity be = blockEntity.getClass().getConstructor().newInstance(new Object[] { to, blockState });
                    Minecraft.getInstance().player.chat(blockEntity.serializeNBT().toString());
                    be.deserializeNBT(blockEntity.serializeNBT());
                    level.setBlockEntity(be);
                } catch (NullPointerException | InstantiationException | IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
                    e.printStackTrace();
                }
            }
        }
        UpdateBlocks(level, moving.values().toArray(new BlockPos[0]));
    }
}

Quote

April 14, 20223 yr

4 hours ago, Gulg said:

        new Thread(() -> {
			...
        }).start();

why on earth are you create there a new Thread,
the most vanilla code is not thread safe thats why your BlockEntity is null

4 hours ago, Gulg said:

            try {
                Minecraft.getInstance().player.chat(level.getBlockEntity(pos).serializeNBT().toString());
            } catch (NullPointerException e) {
                Minecraft.getInstance().player.chat("no nbt at " + pos.toString());
            }

this will also throw an Exception since you mix up server and client stuff, the Minecraft class is client only so you can not use it there,
if you want to debug your code (because it looks like it) you should use a Logger

last but not least you should use the Java Naming Conventions (method names)

Edited April 14, 20223 yr by Luis_ST

Quote

April 14, 20223 yr

Author

Ok, thank you very much.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/110328-how-to-get-block-entity-data/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 2 hours ago2 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 9 hours ago9 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 16 hours ago16 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 20 hours ago20 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

Classroom Companions

Sign In

How to get block entity data?

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)