Jump to content

Help to increase reach attack in version 1.18.2


Sokoly_

Recommended Posts

why did you not read the posts in the thread, like I told you (as a reminder here)?

first of all you need to add the ForgeMod.REACH_DISTANCE to all EntityTypes that you want to have your Attribute,
then you need to create a Multimap with the Attribute itself and it's AttributeModifier, note this map must be lazy initialized, you can use Lazy.of for this
and last but not least you need to return the Multimap in Item#getAttributeModifiers, if you want to add the Attribute to a vanilla Item you need to use ItemAttributeModifierEvent

Edited by Luis_ST
Link to comment
Share on other sites

2 minutes ago, Luis_ST said:

first of all you need to add the ForgeMod.REACH_DISTANCE to all EntityTypes that you want to have your Attribute,

    @SubscribeEvent
    public static void onEntityAttributeModificationEvent(final EntityAttributeModificationEvent event) {
		event.add(EntityType.PLAYER, ForgeMod.REACH_DISTANCE.get());
	}

 

Link to comment
Share on other sites

this is correct now you need to remaingin stuff

8 minutes ago, Luis_ST said:

then you need to create a Multimap with the Attribute itself and it's AttributeModifier, note this map must be lazy initialized, you can use Lazy.of for this
and last but not least you need to return the Multimap in Item#getAttributeModifiers, if you want to add the Attribute to a vanilla Item you need to use ItemAttributeModifierEvent

 

Link to comment
Share on other sites

13 minutes ago, Luis_ST said:

first of all you need to add the ForgeMod.REACH_DISTANCE to all EntityTypes that you want to have your Attribute,
then you need to create a Multimap with the Attribute itself and it's AttributeModifier, note this map must be lazy initialized, you can use Lazy.of for this
and last but not least you need to return the Multimap in Item#getAttributeModifiers, if you want to add the Attribute to a vanilla Item you need to use ItemAttributeModifierEvent

In the old thread I saw this way of doing it, but I think there is something wrong, could you tell me the fault

    public final Lazy<Multimap<Attribute, AttributeModifier>> LAZY = Lazy.of(() ->  {    
    	ImmutableMultimap.Builder<Attribute, AttributeModifier> builder = ImmutableMultimap.builder(); 
    	 builder.put(Attributes.ATTACK_DAMAGE, new AttributeModifier(BASE_ATTACK_DAMAGE_UUID, "Weapon modifier", damage, AttributeModifier.Operation.ADDITION));
         builder.put(Attributes.ATTACK_SPEED, new AttributeModifier(BASE_ATTACK_SPEED_UUID, "Weapon modifier", speed, AttributeModifier.Operation.ADDITION));
         
         if (ForgeMod.REACH_DISTANCE.isPresent()) {
             builder.put(ForgeMod.REACH_DISTANCE.get(), new AttributeModifier(ATTACK_REACH_MODIFIER, "Weapon modifier", reach, AttributeModifier.Operation.ADDITION));
         }
         builder.put(Attributes.ATTACK_KNOCKBACK, new AttributeModifier(ATTACK_KNOCKBACK_MODIFIER, "Weapon modifier", kb, AttributeModifier.Operation.ADDITION));
    	Multimap<Attribute, AttributeModifier> attributeModifiers = ArrayListMultimap.create();
    	attributeModifiers = builder.build();
    	return attributeModifiers;
    });

 

Link to comment
Share on other sites

this should work but there are a few unnecessary code lines:

11 minutes ago, Sokoly_ said:
    	Multimap<Attribute, AttributeModifier> attributeModifiers = ArrayListMultimap.create();
    	attributeModifiers = builder.build();
    	return attributeModifiers;

you can just return ImmutableMultimap.Builder#build

Link to comment
Share on other sites

14 minutes ago, Luis_ST said:

show your code

There is any error?

@EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.FORGE, value = {Dist.CLIENT})
public class AkuariumHelper {

    @SuppressWarnings("resource")
	@SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
	public static void mouseEvent(InputEvent.MouseInputEvent event) {
        if (Minecraft.getInstance().level == null || Minecraft.getInstance().screen == null || Minecraft.getInstance().isPaused())
            return; 
          KeyMapping keyAttack = Minecraft.getInstance().options.keyAttack;
          if (event.getButton() == keyAttack.getKey().getValue() && event.getAction() == 1 && ForgeMod.REACH_DISTANCE.isPresent())
	            checkForReachAttack();   
    }
    
	@SuppressWarnings("unused")
	private static HitResult getEntityMouseOverExtended(float reach) {
        BlockHitResult blockRayTraceResult = null;
        HitResult result = null;
        Minecraft mc = Minecraft.getInstance();
        Entity viewEntity = mc.crosshairPickEntity;
        if (viewEntity != null) {
          double d0 = reach;
          HitResult rayTrace = viewEntity.pick(d0, 0.0F, false);
          Vec3 eyePos = viewEntity.getEyePosition(0.0F);
          boolean flag = false;
          double d1 = d0;
          if (mc.gameMode.hasFarPickRange() && d1 < 6.0D) {
            d1 = 6.0D;
            d0 = d1;
          } else if (d0 > reach) {
            flag = true;
          } 
          d1 *= d1;
          if (rayTrace != null)
            d1 = rayTrace.getLocation().distanceToSqr(eyePos); 
          Vec3 lookVec = viewEntity.getEyePosition(1.0F);
          Vec3 attackVec = eyePos.add(lookVec.x * d0, lookVec.y * d0, lookVec.z * d0);
          AABB expBounds = viewEntity.getBoundingBox().expandTowards(lookVec.scale(d0)).inflate(1.0D, 1.0D, 1.0D);
          EntityHitResult entityRayTrace = ProjectileUtil.getEntityHitResult(viewEntity, eyePos, attackVec, expBounds, entity -> 
              
              (!entity.isSpectator() && entity.canBeCollidedWith()), d1);
          if (entityRayTrace != null) {
        	  Vec3 hitVec = entityRayTrace.getLocation();
            double d2 = eyePos.distanceToSqr(hitVec);
            if (flag && d2 > (reach * reach)) {
              blockRayTraceResult = BlockHitResult.miss(hitVec, Direction.getNearest(lookVec.x, lookVec.y, lookVec.z), new BlockPos(hitVec));
            } else if (d2 < d1 || blockRayTraceResult == null) {
            	EntityHitResult entityRayTraceResult = entityRayTrace;
            } 
          } else {
            blockRayTraceResult = BlockHitResult.miss(attackVec, Direction.getNearest(lookVec.x, lookVec.y, lookVec.z), new BlockPos(attackVec));
          } 
        } 
        return (HitResult)blockRayTraceResult;
      }	    
	
	   private static void checkForReachAttack() {
	        Minecraft mc = Minecraft.getInstance();
	        LocalPlayer clientPlayerEntity = mc.player;
	        if (clientPlayerEntity == null || clientPlayerEntity.isSpectator())
	          return; 
	        double reach = (float)clientPlayerEntity.getAttributeValue(ForgeMod.REACH_DISTANCE.get());
	        if (reach == ForgeMod.REACH_DISTANCE.get().getDefaultValue())
	          return; 
	        HitResult rayTrace = getEntityMouseOverExtended((float)reach);
	        if (!(rayTrace instanceof EntityHitResult))
	          return; 
	        EntityHitResult entityRayTrace = (EntityHitResult)rayTrace;
	        Entity entityHit = entityRayTrace.getEntity();
	        if (entityHit != null && entityHit.invulnerableTime == 0 && entityHit != clientPlayerEntity && entityHit != clientPlayerEntity.getControllingPassenger()) {
	          float velocity = 0.0F;
	          if (clientPlayerEntity.getControllingPassenger() != null) {
	            Entity riding = clientPlayerEntity.getControllingPassenger();
	            Vec3 vec = riding.getDeltaMovement();
	            velocity = (float)vec.length();
	          }
	          PacketHandler.sendPacketToServer(new LongReachAttackPacket(entityHit.getId(), velocity));
	        } 
	        
	      }
  }

 

Edited by Sokoly_
Link to comment
Share on other sites

21 hours ago, Luis_ST said:

first of all you need to add the ForgeMod.REACH_DISTANCE to all EntityTypes that you want to have your Attribute,
then you need to create a Multimap with the Attribute itself and it's AttributeModifier, note this map must be lazy initialized, you can use Lazy.of for this
and last but not least you need to return the Multimap in Item#getAttributeModifiers, if you want to add the Attribute to a vanilla Item you need to use ItemAttributeModifierEvent

you didn't do what i told you to do, why did you copy the code from this thread?

Link to comment
Share on other sites

7 minutes ago, Luis_ST said:

you didn't do what i told you to do, why did you copy the code from this thread?

So the " public static void mouseEvent(InputEvent.MouseInputEvent event)" is unnecessary?

Edited by Sokoly_
Link to comment
Share on other sites

2 minutes ago, Luis_ST said:

to 100% yes

So please could you give me an example of how to make it possible to hit from a distance. I have seen other mods on github and most have the same process and I can't find another

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello. I'm using IntelliJ IDEA and making a mod for Forge 1.20.1 and I'm trying to make a GUI. I found that the Minecraft-related codes are all obfuscated and when setting up the workspace, Gradle did not execute Deobfuscation tasks like createMcpToSrg. Is this normal or a bug? Can anyone help me with this?
    • Hello! I'm trying to get a list of all entries registered in the infusion upgrade registry. Code can be found in github: https://github.com/ChamoisEST/MiningMadness/tree/1.20.1 Registry in common/registries/MMRegistries.java Event that calls the registry is in MiningMadness.java List of registered entries should be called in common/capabilities/infusion/InfusionCapabilityImplementation.java:getActiveInfusions() in the for loop. Is there any way to accomplish that? Thanks in advance!  
    • So, I am trying to create and add tags to my custom damage type, but looks like I made something wrong, since it crashing with error that "cannot register" damage type. Im trying to register it, and in datagen add tags, but it everytime crashing due to not register "grimtales:entropy". Full code there - https://github.com/undertakerJ/Grim-Tales-Forge ModDamageTypes class public class ModDamageTypes { public static final DeferredRegister<DamageType> DAMAGE_TYPES = DeferredRegister.create(Registries.DAMAGE_TYPE, GrimTales.MOD_ID); public static final ResourceKey<DamageType> ENTROPY_KEY = ResourceKey.create(Registries.DAMAGE_TYPE, new ResourceLocation(GrimTales.MOD_ID, "entropy")); public static final RegistryObject<DamageType> ENTROPY = DAMAGE_TYPES.register( "entropy", () -> new DamageType("entropy_effect", DamageScaling.ALWAYS, 1f, DamageEffects.HURT)); // // public static final DamageSource ENTROPY_SOURCE = new DamageSource(Holder.direct(ENTROPY.get())); public static void register(IEventBus eventBus) { DAMAGE_TYPES.register(eventBus); } } Datagen for damageTags public class ModDamageTagsProvider extends DamageTypeTagsProvider { public ModDamageTagsProvider( PackOutput p_270719_, CompletableFuture<HolderLookup.Provider> p_270256_, @Nullable ExistingFileHelper existingFileHelper) { super(p_270719_, p_270256_, GrimTales.MOD_ID, existingFileHelper); } @Override protected void addTags(HolderLookup.Provider pProvider) { this.tag(DamageTypeTags.BYPASSES_INVULNERABILITY).add(ModDamageTypes.ENTROPY_KEY); } } Datagen class it self   @Mod.EventBusSubscriber(modid = GrimTales.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD) public class DataGenerators { @SubscribeEvent public static void gatherData(GatherDataEvent event){ DataGenerator generator = event.getGenerator(); PackOutput packOutput = generator.getPackOutput(); ExistingFileHelper helper = event.getExistingFileHelper(); CompletableFuture<HolderLookup.Provider> lookupProvider = event.getLookupProvider(); generator.addProvider(event.includeServer(), new ModDamageTagsProvider(packOutput, lookupProvider, helper)); } } And register class in main class public GrimTales() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); ModDamageTypes.register(modEventBus); modEventBus.addListener(this::commonSetup); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); }  
    • Looking for a semi-vanilla Minecraft server? Maybe one with keep inventory and land claims? I have one for you! Let me introduce you to Safe Survival! Come on and join us at mc.safesurvival.net. It is bedrock supported too!
    • Hi. I'm trying to play RLCraft with Optifine but my game keeps crashing on startup with Exit Code 1. The modpack was working fine yesterday, not sure what changed to make it not wanna work anymore. I was hoping someone here could help me figure out what's going wrong. If I remove Optifine, nothing changes, I still get the same errors. Thanks in advance. Crash Report (I only included the errors+fatal, I’m not sure if more is needed, please let me know): https://pastebin.ai/66ivknz0f4  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.