Search the Forums BEFORE making a new post.

Destroy / Remove blocks (10x10x10) when the block is clicked with an item.

July 26, 20223 yr

Author

Of course, here you go:


import net.minecraft.client.Minecraft;
import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.nbt.CompoundTag;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResult;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.context.UseOnContext;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.TargetBlock;
import net.minecraft.world.phys.HitResult;
import net.minecraft.world.phys.Vec3;
import net.minecraftforge.event.entity.ProjectileImpactEvent;

import static net.minecraftforge.client.gui.ForgeIngameGui.rayTraceDistance;


public class teleportItem extends Item {
    public teleportItem(Properties pProperties) {
        super(pProperties);
    }


    @Override
    public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) {

        // entity.pick(rayTraceDistance, 0.0F, false);
        Entity entity = Minecraft.getInstance().getCameraEntity();

        rayTraceDistance = 500.0D;

        HitResult viewedBlock = entity.pick(rayTraceDistance, 0.0F, false);
        Double x = viewedBlock.getLocation().x;
        Double y = viewedBlock.getLocation().y;
        Double z = viewedBlock.getLocation().z;

        y += 1;

        if (!pLevel.isClientSide){
            pPlayer.teleportTo(x, y, z);
        }

        pPlayer.fallDistance = 0.0f;
        rayTraceDistance = 20.0D;

        return super.use(pLevel, pPlayer, pUsedHand);
    }
}

Quote

Replies 57
Views 40.2k
Created 3 yr3 yr
Last Reply 3 yr3 yr

Popular Days

Most Popular Posts

Luis_ST

July 22, 20223 yr

i think you forgot the !, since removing Blocks is always done on server
Luis_ST

July 22, 20223 yr

you removing 10*10*10 Blocks each click, this are 1000 Blocks i think this is a performance issue, you can use a BlockPos.MutableBlockPos instead of evertime a new BlockPos Do you know basic ja
Luis_ST

July 22, 20223 yr

create before the loops a new BlockPos.MutableBlockPos, and before you remove the Block you move the BlockPos.MutableBlockPos via BlockPos.MutableBlockPos#move to it's new Position i would re

July 26, 20223 yr

This does not work you need in this case server raytrace, you can take a look at BucketItem#use for an example.
why did you use ForgeIngameGui.rayTraceDistance this makes for me no sense, do you know what it is used for?

Quote

July 26, 20223 yr

Author

It gets me the x, y, z of my crosshair position. Initial value of the rayTraceDistance is 20.0D, therefore you can only get x, y, z in that specter, however once I increase it, I can get positions from much further. I used it from here: https://github.com/MinecraftForge/MinecraftForge/blob/bb4818630c0c6cdd7c4178b4d77dc406153c2bcb/src/main/java/net/minecraftforge/client/gui/overlay/ForgeGui.java#L680

So you reckon I have to change the way I get x, y and z?

Quote

July 26, 20223 yr

56 minutes ago, Gepardius said:

It gets me the x, y, z of my crosshair position. Initial value of the rayTraceDistance is 20.0D, therefore you can only get x, y, z in that specter, however once I increase it, I can get positions from much further. I used it from here:

ForgeIngameGui.rayTraceDistance is just a double value there is nothing special with it

57 minutes ago, Gepardius said:

So you reckon I have to change the way I get x, y and z?

yes:

1 hour ago, Luis_ST said:

you need in this case server raytrace, you can take a look at BucketItem#use for an example.

Quote

July 26, 20223 yr

Author

If I use this one:

HitResult viewedBlock = getPlayerPOVHitResult(pLevel, pPlayer, ClipContext.Fluid.NONE);

I can only teleport around 5-10 blocks. Is there another server side method to get rayTrace?

Quote

July 26, 20223 yr

Author

Btw. If I use pPlayer instead of assigning Entity through Minecraf.getInstance() as below:

@Override
    public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) {

        // entity.pick(rayTraceDistance, 0.0F, false);
        // Entity entity = Minecraft.getInstance().getCameraEntity();
        
        rayTraceDistance = 500.0D;

        HitResult viewedBlock = pPlayer.pick(rayTraceDistance, 0.0F, false); 
        Double x = viewedBlock.getLocation().x;
        Double y = viewedBlock.getLocation().y;
        Double z = viewedBlock.getLocation().z;

        y += 1;

        if (!pLevel.isClientSide){
            pPlayer.teleportTo(x, y, z);
        }

        pPlayer.fallDistance = 0.0f;
        rayTraceDistance = 20.0D;

        return super.use(pLevel, pPlayer, pUsedHand);
    }

Then it works as before and it solves it right?

Quote

July 26, 20223 yr

12 minutes ago, Gepardius said:

Then it works as before and it solves it right?

i'm not sure as far as I can see in the code, yes
test it on a server via runServer

12 minutes ago, Gepardius said:

I can only teleport around 5-10 blocks. Is there another server side method to get rayTrace?

it use the reach distance of the player which is 4.5 by default

Edited July 26, 20223 yr by Luis_ST

Quote

July 26, 20223 yr

Author

The server starts without interruptions, but I'd have to upload the mod into the run folder in order to real-life test it right, which will take some time? For the moment I'll just have to believe it will work on the server as well.

Quote

July 26, 20223 yr

20 minutes ago, Gepardius said:

but I'd have to upload the mod into the run folder in order to real-life test it right, which will take some time?

No you have to run the runServer gradle task

Note the first time you run the server it stops, since you need to accept the eula,
the second time it generate all missing files but you need to stop the server,
since you need to disable the online mode in the server.properties file

Quote

July 26, 20223 yr

Author

Hmmm... I've accepted the eula, changed online mode to false and now I only have Minecraft server window open. How do I connect to it? I tried through the client but I must be doing something wrong.

Quote

July 26, 20223 yr

Run a client (via runClient) join the server with ip localhost and port 25565

Quote

July 27, 20223 yr

Author

Aha. It worked when I connected just with: localhost.

Everything works normally, except the teleporting. I guess it is not possible to teleport player on the server with:

player.setPos(x, y, z);
// or
player.teleportTo(x, y, z);

Is there another server teleport method?

Quote

July 27, 20223 yr

The teleport command used ServerPlayer#connection and ServerGamePacketListenerImpl#teleport,
but i also remember that Player#teleportToWithTicket should work

Quote

July 27, 20223 yr

Author

I tried with Player#teleportToWithTicket, unfortunately it does not work:

if (!level.isClientSide) {

	player.teleportToWithTicket(x, y, z);

}

But I can't figure out how to try the ServerPlayer#connection and ServerGamePacketListenerImpl#teleport yet, so I'll have to get back to you once I do

Quote

July 27, 20223 yr

29 minutes ago, Gepardius said:

But I can't figure out how to try the ServerPlayer#connection and ServerGamePacketListenerImpl#teleport yet, so I'll have to get back to you once I do

i guess your variable "player" is a Player, then you need an instance of check if the Player is an ServerPlayer.
Then you can cast your Player to a ServerPlayer.

Btw this is basic java.

Quote

July 27, 20223 yr

Author

I am checking the instance now, but I don't know what to input as the last two elements.

if (player instanceof ServerPlayer){
	((ServerPlayer) player).connection.teleport(x, y, z, 0, 0);
}

Quote

July 27, 20223 yr

1 hour ago, Gepardius said:

I am checking the instance now, but I don't know what to input as the last two elements.

the first one is the y rotation of the player head and the second one is the x rotation of the player head,
you can use 0 if you don't want a specific head look direction

Quote

July 27, 20223 yr

Author

Very basic question again... I am not applying changes to the server, when using the InteractionResultHolder method:

@Override
    public InteractionResultHolder<ItemStack> use(Level level, Player player, InteractionHand pUsedHand) {

        rayTraceDistance = 500.D;

        HitResult viewedBlock = player.pick(rayTraceDistance, 0.0F, false);
        Double x = viewedBlock.getLocation().x;
        Double y = viewedBlock.getLocation().y;
        Double z = viewedBlock.getLocation().z;
        y += 1;

        if (player instanceof ServerPlayer){
            System.out.println("nothing happens");
            // player.teleportToWithTicket(x, y, z);
        }

        if (!level.isClientSide) {

            System.out.println("nothing happens");
            ((ServerPlayer) player).connection.teleport(x, y, z, 1, 1);
            // player.teleportToWithTicket(x, y, z);

        }

        rayTraceDistance = 20.0D;
        return super.use(level, player, pUsedHand);
    }

In theory shouldn't both of these ifs be triggered from the server?

Quote

July 27, 20223 yr

18 minutes ago, Gepardius said:

In theory shouldn't both of these ifs be triggered from the server?

yes, does it not work?

18 minutes ago, Gepardius said:
rayTraceDistance = 500.D;

why did you still use this, you can pass the value (500) directly into Player#pick

Quote

July 27, 20223 yr

Author

On the client yes, on the server no. Have you got any idea why?

rayTraceDistance = 500.D; I know but later on I might change it through custom leveling.

Full code:

import net.minecraft.server.level.ServerPlayer;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.HitResult;
import static net.minecraftforge.client.gui.ForgeIngameGui.rayTraceDistance;


public class teleportItem extends Item {
    public teleportItem(Properties pProperties) {
        super(pProperties);
    }


    @Override
    public InteractionResultHolder<ItemStack> use(Level level, Player player, InteractionHand pUsedHand) {

        rayTraceDistance = 500.D;

        HitResult viewedBlock = player.pick(rayTraceDistance, 0.0F, false);
        Double x = viewedBlock.getLocation().x;
        Double y = viewedBlock.getLocation().y;
        Double z = viewedBlock.getLocation().z;
        y += 1;


        if (player instanceof ServerPlayer){
            System.out.println("nothing happens");
            // player.teleportToWithTicket(x, y, z);
        }

        if (!level.isClientSide) {

            System.out.println("nothing happens");
            ((ServerPlayer) player).connection.teleport(x, y, z, 1, 1);
            // player.teleportToWithTicket(x, y, z);

        }

        rayTraceDistance = 20.0D;
        return super.use(level, player, pUsedHand);
    }
}

Quote

July 27, 20223 yr

2 minutes ago, Gepardius said:

On the client yes, on the server no. Have you got any idea why?

Did you mean Singleplayer with "client"?

1 minute ago, Gepardius said:

I know but later on I might change it through custom leveling.

Could you please explain that in more detail?

Quote

July 27, 20223 yr

Author

Yes singleplayer with client. No multiplayer through client (localhost).

This one "I know but later on I might change it through custom leveling." is not important for now. Later on I want to implement custom levels, which will increase/decrease this double figure.

Quote

July 27, 20223 yr

1 minute ago, Gepardius said:

Yes singleplayer with client. No multiplayer through client (localhost).

Then rayTraceDistance is your issue it's in a class which should be only used on client,
remove it since you can not store data like this in a Item, the value will be shared.

If you want to store data in a Item you need to store the data in the related ItemStack.
Therefore i would recommend you to use a Capability.

Quote

July 27, 20223 yr

Author

Nope still nothing happens the ifs are never accessed:

if (player instanceof ServerPlayer){
  System.out.println("nothing happens");
  // player.teleportToWithTicket(x, y, z);
}

if (!level.isClientSide) {

  System.out.println("nothing happens");
  ((ServerPlayer) player).connection.teleport(x, y, z, 1, 1);
  // player.teleportToWithTicket(x, y, z);

}

I thank you for your effort and time. I'll be gone for a few days now, so I won't be able to reply. I appreciate your help!

Edited July 27, 20223 yr by Gepardius

Quote

July 27, 20223 yr

I'm not be able to reproduce your problem, this code works fine in Singleplayer and on Server.
The Logger debug statements are correctly printed on console

Please post the full class of your Item.

	@Override
	public InteractionResultHolder<ItemStack> use(Level level, Player player, InteractionHand hand) {
		if (player instanceof ServerPlayer serverPlayer) {
			LogUtils.getLogger().debug("ServerPlayer");
			serverPlayer.connection.teleport(serverPlayer.getX(), 100, serverPlayer.getZ(), 0.0F, 0.0F);
		}
		if (!level.isClientSide) {
			LogUtils.getLogger().debug("!isClientSide");
		}
		return super.use(level, player, hand);
	}

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/114301-destroy-remove-blocks-10x10x10-when-the-block-is-clicked-with-an-item/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Replies 57
Views 40.2k
Created 3 yr3 yr
Last Reply 3 yr3 yr

Popular Days

Most Popular Posts

Luis_ST

July 22, 20223 yr

i think you forgot the !, since removing Blocks is always done on server
Luis_ST

July 22, 20223 yr

you removing 10*10*10 Blocks each click, this are 1000 Blocks i think this is a performance issue, you can use a BlockPos.MutableBlockPos instead of evertime a new BlockPos Do you know basic ja
Luis_ST

July 22, 20223 yr

create before the loops a new BlockPos.MutableBlockPos, and before you remove the Block you move the BlockPos.MutableBlockPos via BlockPos.MutableBlockPos#move to it's new Position i would re

Help with file conversion

This is really helpful

By Brialeblanc · 4 hours ago4 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 10 hours ago10 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 18 hours ago18 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 22 hours ago22 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

Sign In

Destroy / Remove blocks (10x10x10) when the block is clicked with an item.

Featured Replies

Top Posters In This Topic

Popular Days

Most Popular Posts

Luis_ST

Luis_ST

Luis_ST

Join the conversation

Top Posters In This Topic

Popular Days

Most Popular Posts

Luis_ST

Luis_ST

Luis_ST

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)