Help with ore generation and crashes

[Tucky143]

I try to make my ore generate naturally but it doesn't work properly!

Mod: https://github.com/Tucky143/Crystal-Minecraft-Mod-for-1.19

Edited July 27, 2022 by Tucky143
New Link

[Luis_ST]

Please do not upload your Mod as a .zip file. It's highly recommended to use a git repo with a git client.

Please post the debug.log.

[Tucky143]

There

[Luis_ST]

10 hours ago, Luis_ST said:

Please post the debug.log.

 

[Tucky143]

It's in the Github link now; the run/logs.

[Luis_ST]

your BiomeModifier json file is invalid, how did you create this BiomeModifier json file?

Do you register a BiomeModifier Codec somewhere?

[Tucky143]

No... I followed this tutorial: https://www.youtube.com/c/tkaupenjoe

Github Link:https://github.com/Tutorials-By-Kaupenjoe/Forge-Tutorial-1.19

[Luis_ST]

I would recommend you to take a look at this Doc, it's official from Forge and it explains how you create a valid BiomeModifier.

If you don't want to create your own you can take a look at the Builtin Modifier Types

[warjort]

Compare your biome modifier with the one from the tutorial

https://github.com/Tucky143/Crystal-Minecraft-Mod-for-1.19/blob/main/src/main/resources/data/examplemod/forge/biome_modifier/add_example_ore.json

https://github.com/Tutorials-By-Kaupenjoe/Forge-Tutorial-1.19/blob/main/src/main/resources/data/tutorialmod/forge/biome_modifier/add_zircon_ore.json

[warjort]

It's never a good idea to just blindly follow tutorials. You need to make sure you understand each step so you can correct errors.

[Tucky143]

I changed it because it's the same error anyways

[Luis_ST]

Create the BiomeModifier json how it's description in the Doc i linked above, then update your Git repo and the logs.

[Tucky143]

Didn't work

[Zetal911]

You aren't calling ModPlacedFeatures.register in your Mod constructor.

[Tucky143]

Called it but it still didn't work

[Zetal911]

There aren't any new logs?

[Tucky143]

Latest .log is the newest one.

[Luis_ST]

The error in latest and debug log say that there is not features key in your Biome Modifier,
but there is see here, so that can't be the problem.

I'm currently work on a Forge PR, if this is done i'll clone your git repo and debug this locally.

[Zetal911]

TBH it looks fine to me now, Tucky. Maybe try updating to the latest forge, since it seems like you're a bit behind?

[Tucky143]

Worked!!! Thanks "Zetal911"