Making Biomes with 4096 IDs

[blued00r]

now i was trying to make a biome with a block that has an id of 500+. Now understand that its the best that i dont move any ids as the map that i have would seriously get edited as i have run out of normal block ids. Can anybody help me. When i try to make them it doesnt generate

[ShneekeyTheLost]

This sounds less like a problem with 4096 and more like a problem with your mod_Block file. Specifically where you tell it to generate. There should be code that looks like this:

 

   public void GenerateSurface(World world, Random rand, int chunkX, int chunkZ)
        {
                        for(int l = 0; l < 5; l++)
                        {
                                int i1 = chunkX + rand.nextInt(16);
                                int j1 = rand.nextInt(20);
                                int k1 = chunkZ + rand.nextInt(16);
                                (new WorldGenMinable(oreTitanium.blockID, 3)).generate(world, rand, i1, j1, k1);
                        }
        }

 

This code yanked directly from this tutorial on creating mod blocks, and generation thereof. I'd strongly suggest reading it if you are new to this.

[blued00r]

See im not generating ores im making my own biome. The biome i make generate with no topblock or fillerblock.  ores gen fine if there over the minecraft block limit(i have my ores generating)

[hotrods20]

https://github.com/hotrods20/mod_shadowRealm/tree/master/net/minecraft/src

Look at my custom biome and such.

[blued00r]

I understand the how to make a biome. what im asking is how do i make it use my custom blocks as top and filler blocks. they always spawn as nothing. no top or filler blocks exist. 

 

Here's my BiomeGen class

 

package xolovon;

import net.minecraft.src.*;

public class BiomeGenSerenity extends BiomeGenBase
{

    public BiomeGenSerenity(int par1)
    {
            super(par1);
            spawnableCreatureList.clear();
            topBlock = (byte)mod_XolovonRPG.serenityGrass.blockID; //ID = 513
            fillerBlock = (byte)mod_XolovonRPG.serenityDirt.blockID; //ID = 514
            //biomeDecorator.treesPerChunk = 0;
            //biomeDecorator.deadBushPerChunk = 0;
            //biomeDecorator.reedsPerChunk = 0;
            //biomeDecorator.cactiPerChunk = 0;
            waterColorMultiplier = 0x9933FF;
    }

}

 

[Cutter]

This sounds less like a problem with 4096 and more like a problem with your mod_Block file. Specifically where you tell it to generate. There should be code that looks like this:

 

   public void GenerateSurface(World world, Random rand, int chunkX, int chunkZ)
        {
                        for(int l = 0; l < 5; l++)
                        {
                                int i1 = chunkX + rand.nextInt(16);
                                int j1 = rand.nextInt(20);
                                int k1 = chunkZ + rand.nextInt(16);
                                (new WorldGenMinable(oreTitanium.blockID, 3)).generate(world, rand, i1, j1, k1);
                        }
        }

 

This code yanked directly from this tutorial on creating mod blocks, and generation thereof. I'd strongly suggest reading it if you are new to this.

yah, that code throws an error/does not work. can you guess why?

[LexManos]

            topBlock = (byte)mod_XolovonRPG.serenityGrass.blockID; //ID = 513
            fillerBlock = (byte)mod_XolovonRPG.serenityDirt.blockID; //ID = 514

... who taught you data types?

[atrain99]

            topBlock = (byte)mod_XolovonRPG.serenityGrass.blockID; //ID = 513
            fillerBlock = (byte)mod_XolovonRPG.serenityDirt.blockID; //ID = 514

... who taught you data types?

Nobody.

I so should have caught that...

[blued00r]

            topBlock = (byte)mod_XolovonRPG.serenityGrass.blockID; //ID = 513
            fillerBlock = (byte)mod_XolovonRPG.serenityDirt.blockID; //ID = 514

... who taught you data types?

Nobody.

I so should have caught that...

 

well it was just off a tutorial...i dont really get how they work... but if i remove the (byte) it throws an error

[LexManos]

http://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html

[blued00r]

alright what would i have to change (byte) to?  i see all the others like short and int would work but how could i make it so that the biome works correctly with that

[LexManos]

You change it to a datatype that supports numbers as high as your id.

If the thing you're trying to assign it to doesn't support anything but a byte.

You're gunna have to figure out how to make it more then a byte.

 

[hotrods20]

I don't think it would be possible unless you created a new ChunkProvider that used a short instead of a byte and also creating a new variable for the ChunkProvider to use that would also be a short.

[blued00r]

Well see these biomes are for my new dimension so i am writing a new ChunkProvider. Now I almost have it complete. I have 2 more errors before i could test if casting the data to (short) instead of (byte).

 

How would i go about solving those errors below (I commented them on what I need to fix.)

 

    public Chunk provideChunk(int var1, int var2)
    {
        this.rand.setSeed((long)var1 * 341873128712L + (long)var2 * 132897987541L);
        byte[] var3 = new byte[32768];
        //Line Below needs to be casted to BiomeGenBase and not my Custom BiomeGenBase
        this.biomesForGeneration = this.worldObj.getWorldChunkManager().loadBlockGeneratorData(this.biomesForGeneration, var1 * 16, var2 * 16, 16, 16); 
        this.generateTerrain(var1, var2, var3, biomesForGeneration, generatedTemperatures);
        this.replaceBlocksForBiome(var1, var2, var3, this.biomesForGeneration); //Needs this.biomesForGeneration to be resolved
        this.caveGenerator.generate(this, this.worldObj, var1, var2, var3);
        Chunk var5 = new Chunk(this.worldObj, var3, var1, var2);
        byte[] var6 = var5.getBiomeArray();

        for (int var7 = 0; var7 < var6.length; ++var7)
        {
            var6[var7] = (byte)this.biomesForGeneration[var7].biomeID;
        }

        var5.generateSkylightMap();
        return var5;
    }

 

Should I just create another class that extends World specifying to just my custom BiomeGenBase instead of Minecraft's BiomeGenBase class?

[LexManos]

Thats fucking retarded. who taught you how to program?

You have a BiomeGen which extends BiomeGenBase

You override anything that uses the byte limited ids.

Replace them with a short.

How hard is that?

This has NOTHING to do with World at all

This is ALL inside BiomeGenBase

Seriously

Its not difficult

 

[hotrods20]

BiomeGenBase var10 = par4ArrayOfBiomeGenBase[var9 + var8 * 16];
                float var11 = var10.getFloatTemperature();
                int var12 = (int)(this.stoneNoise[var8 + var9 * 16] / 3.0D + 3.0D + this.rand.nextDouble() * 0.25D);
                int var13 = -1;
                byte var14 = var10.topBlock;
                byte var15 = var10.fillerBlock;

 

That is the code in the ChunkProviderGenerate that makes it so you need a new ChunkProvider.  That is where the problem is from.  It would be so much easier to just change it in his biome gen and assume the problem would go away but he will have to extend BiomeGenBase and write a different ChunkProvider that will accept a short instead of a byte.

 

He could copypasta mod a just make it read as:

BiomeGenHisBiome var10 = par4ArrayOfBiomeGenBase[var9 + var8 * 16];
                float var11 = var10.getFloatTemperature();
                int var12 = (int)(this.stoneNoise[var8 + var9 * 16] / 3.0D + 3.0D + this.rand.nextDouble() * 0.25D);
                int var13 = -1;
                short var14 = var10.topBlock;
                short var15 = var10.fillerBlock;

 

This would also mean he needs to make a new BiomeGenBase like file.  Would seem more troublesome than just making Forge compatible with all by simply switching the "default" code to have short instead of byte.

 

EDIT: I should also mention he will need to change about everything in his custom ChunkProviderGenerate to use short instead of byte.  If done correctly, this code would work fine.  Since you question his programming skill, someone might have to code it for him.

 

EDIT2: I took the time to create a new ChunkProviderGenerate that would *in theory* work.  I will message/email the code to you for you to use blued00r.

[LexManos]

Well, actually the main issue is that all of the world generation is encoded into a byte array.

Someone should look into what exactly would need to be changed for world gen to use a short array as opposed to a byte array.

Its in quite a few files.

Seems the start of it is ChunkProviderGenerate.providceChunk, and touches all BiomeGen classes, as well as all the other world generation classes...

It would be quite a large change.

Not to mention throwing compatibility right out the window with any non-forge mods.

I think the simplest soltution for now, is to either do your world gen stuff in the populatChunk callback.

Or to make sure your world-gen blocks are < 256

 

[hotrods20]

If you would wish/want, I could look into rewriting the code and still have compatibility.  In my rewrite of ChunkProviderGenerate, I made it so you still have an array of bytes for the world generation of structures, mines, and strongholds.  I then created a new array of shorts for the replaceBlocksForBiome method so that is gets the same exact array but as a short[].  It was a quick fix but overall changing the normal code would/could be possible while maintaining compatibility with non-Forge.  Just gotta do it the right way.

 

EDIT: Quick idea for a fix that could/would work with the code I wrote and wouldn't change much at all.  You could have a boolean variable in BiomeGenBase that says if it will require a byte or a short, defaulting to false(for byte) it could be used so old mods still have compatibility and would accept mods that use shorts.  I'm going to write a quick example and put the source on this thread for the classes I changed.

[blued00r]

Well, actually the main issue is that all of the world generation is encoded into a byte array.

Someone should look into what exactly would need to be changed for world gen to use a short array as opposed to a byte array.

Its in quite a few files.

Seems the start of it is ChunkProviderGenerate.providceChunk, and touches all BiomeGen classes, as well as all the other world generation classes...

It would be quite a large change.

Not to mention throwing compatibility right out the window with any non-forge mods.

I think the simplest soltution for now, is to either do your world gen stuff in the populatChunk callback.

Or to make sure your world-gen blocks are < 256

 

 

I can not make the blocks that are generating <256. My mod is for my personal server and we have had this map for a LONG time and I have filled every possible ID <256, therefore i can't, I'm sure I have stated this before. Compatibility is not my problem, I'm trying to enforce incompatibility. Also these biomes I'm trying to create are for my new Dimension. I have a ChunkProvider all set up for my dimension except my only problem is that my biomes don't generate their perspective top and filler blocks and my "stone" for the world gens as coal ore, as the ID for it is 528 came here to the forums to see if i could get help, all I've got is being screamed at with no real help..well except for hotrod..

[hotrods20]

Right now I am writing up a fix that could work for you and might even be put into Forge if Lex and the other members of Forge find it useful.  Currently ran into a problem but I am working on fixing it.  I see what error you came across.  It is pretty messed up.

[Entoarox]

Well, actually the main issue is that all of the world generation is encoded into a byte array.

Someone should look into what exactly would need to be changed for world gen to use a short array as opposed to a byte array.

Its in quite a few files.

Seems the start of it is ChunkProviderGenerate.providceChunk, and touches all BiomeGen classes, as well as all the other world generation classes...

It would be quite a large change.

Not to mention throwing compatibility right out the window with any non-forge mods.

I think the simplest soltution for now, is to either do your world gen stuff in the populatChunk callback.

Or to make sure your world-gen blocks are < 256

 

 

I can not make the blocks that are generating <256. My mod is for my personal server and we have had this map for a LONG time and I have filled every possible ID <256, therefore i can't, I'm sure I have stated this before. Compatibility is not my problem, I'm trying to enforce incompatibility. Also these biomes I'm trying to create are for my new Dimension. I have a ChunkProvider all set up for my dimension except my only problem is that my biomes don't generate their perspective top and filler blocks and my "stone" for the world gens as coal ore, as the ID for it is 528 came here to the forums to see if i could get help, all I've got is being screamed at with no real help..well except for hotrod..

 

compacted answer:

 

1) the generator currently does not support values above 256

2) its possible to custom rewrite the generator to do so, but its a lot of work

3) doing so for forge would most likely cause non-forge mods to become incompatible

4) hotrods is trying to solve your problem in a way that #3 does not happen

 

the reason people scream is because you are using dirty code, and the people here have a to high IQ to comprehend not everyone is as smart as they are

[blued00r]

Well, actually the main issue is that all of the world generation is encoded into a byte array.

Someone should look into what exactly would need to be changed for world gen to use a short array as opposed to a byte array.

Its in quite a few files.

Seems the start of it is ChunkProviderGenerate.providceChunk, and touches all BiomeGen classes, as well as all the other world generation classes...

It would be quite a large change.

Not to mention throwing compatibility right out the window with any non-forge mods.

I think the simplest soltution for now, is to either do your world gen stuff in the populatChunk callback.

Or to make sure your world-gen blocks are < 256

 

 

I can not make the blocks that are generating <256. My mod is for my personal server and we have had this map for a LONG time and I have filled every possible ID <256, therefore i can't, I'm sure I have stated this before. Compatibility is not my problem, I'm trying to enforce incompatibility. Also these biomes I'm trying to create are for my new Dimension. I have a ChunkProvider all set up for my dimension except my only problem is that my biomes don't generate their perspective top and filler blocks and my "stone" for the world gens as coal ore, as the ID for it is 528 came here to the forums to see if i could get help, all I've got is being screamed at with no real help..well except for hotrod..

 

compacted answer:

 

1) the generator currently does not support values above 256

2) its possible to custom rewrite the generator to do so, but its a lot of work

3) doing so for forge would most likely cause non-forge mods to become incompatible

4) hotrods is trying to solve your problem in a way that #3 does not happen

 

the reason people scream is because you are using dirty code, and the people here have a to high IQ to comprehend not everyone is as smart as they are

 

Now if their IQ is so high then why would they tell me to replace (byte) with (short) in just my BiomeGenMybiome? Even a noob modder would know that wouldn't work because BiomeGenBase's constructor is built with (byte)

[hotrods20]

To simplify, I am converting code and editing a lot of base classes(something I don't like doing).  So right now, you will have to hold on till I finish the fix.

[blued00r]

Thing is as i was trying to convert just the "stone" of my dimensions to short it would not generate... just making sure that after you do the fix that the world does indeed generate if it does use short

[Entoarox]

Now if their IQ is so high then why would they tell me to replace (byte) with (short) in just my BiomeGenMybiome? Even a noob modder would know that wouldn't work because BiomeGenBase's constructor is built with (byte)

 

and they told you to replace byte with short, just because you thought it only applied to the code you shared is not their problem...

cause if a noob modder knows a short cant be cast to a byte, you also imply they understand they have to use shorts in the first place....