Function called for Items in Chests?

[Draco18s]

I have an item that applies a passive effect to the player that's carrying it, and I can remove this effect when the item is dropped, but I can't seem to find a spot that will let me know that the item was removed from the player's inventory and placed into another object's inventory.

[Moritz]

I know 2 ways to check if an special Item is inside of the Players Inventory.

 

First way is from the item itself (onUpdate() function).

 

Second way is from an entityliving update handler. with that you should can scan the inventory of the player.

 

I think this shoud be what you are asking. If not explain it in more detail.

 

 

[Draco18s]

I want to know when it's NOT in the player's inventory.

 

And scanning every inventory of every player on a server ever tick is not a viable solution.

 

I only need the function called once (the frame that it leaves the player's inventory) but I need something.

[Moritz]

yeah that checking is not a solution. And what is when you add a varibale to a player has The item in the inventory and then the living handler search only at these players who have this variable. Would that be a way?

[Draco18s]

I'm not sure that's all that viable either, as these effects are unique (each has a separate UUID for the SharedMonsterAttribute system, so that they stack), so I need to remove exactly the one that was placed into the chest.

 

I'd have to add several flags to every player. :\  If they have any, then I need to loop through their entire inventory and verify each one.

[coolAlias]

Whenever one of these items is added to a player's inventory, store its UUID in a Map in IExtendedEntityProperties or someplace. Then, either find a way to inject code (ASM?) or edit base classes so that the InventoryPlayer checks for your Item onInventoryChanged, decrStackSize etc. and before setting the itemstack to null, remove its UUID from the map. That's the only way I can think of that wouldn't require doing lots of checks every tick. 

[Draco18s]

Moritz and I found a solution that works well enough:

 

onUpdate, if the player has an inventory open, remove effect.  So the effect is suppressed while they're looking in a chest.

[Moritz]

I got another problem for you. What happends when the player (standart keybinding) is Pressing Q? (Means drop a item in your hand)

[Draco18s]

I got another problem for you. What happends when the player (standart keybinding) is Pressing Q? (Means drop a item in your hand)

 

It gets tossed into the world as an EntityItem, and because THAT receives updates, it's easy to go "oh, hey, I've been dropped.  Hey NBT, what was the player's entity ID?"

[GotoLink]

You can also use the ItemTossEvent.

[Moritz]

ok. i want only to be save^^"

[Draco18s]

You can also use the ItemTossEvent.

 

Because of the way my items are built, I'm already using the EntityItemUpdate function (as there are effects which use it) so tying into that isn't difficult and keeps everything inside my Item class.

[Draco18s]

.  Putting items into item frames doesn't trigger any kind of function either!  And doing that doesn't require opening a GUI!

[Moritz]

You can use the onItemUseFunction, or onRightclick function for that. That will be triggered before the block trigger the putItemin function^^"

[Draco18s]

That will be triggered before the block trigger the putItemin function^^"

 

Actually, it's not.  I checked.

[MineMaarten]

Well if it's triggered after, you could check if the block being right clicked on is an Item Frame (or were Item Frame entities?), and then get the stored item from its TileEntity.

 

But even if this works, you still have the problem that this is not very reliable. You might have missed other vanilla features or other mods could easily add other features that take an item from your inventory by right clicking on something.

[GotoLink]

I think the problem is how you are doing your effect on the item.

It is bringing a lot of stupid issues because of this.

 

Edit: You could use the EntityInteractEvent and check for EntityItemFrame.

[Draco18s]

Well if it's triggered after, you could check if the block being right clicked on is an Item Frame (or were Item Frame entities?), and then get the stored item from its TileEntity.

 

It's not triggered before OR after, none of the item's functions are called.

 

I think the problem is how you are doing your effect on the item.

It is bringing a lot of stupid issues because of this.

 

How would you make an item that gives the player bonus health while they are carrying it?

 

Edit: You could use the EntityInteractEvent and check for EntityItemFrame.

 

I am trying to do this without events, but if I have to for this case I will.

[TheGreyGhost]

Hi.

 

Just a suggestion - if it's too expensive to check the inventory every tick, why not check (say) every 20 ticks.  A delay of 1 second will probably be unnoticeable to the player I imagine, depending on what "effect" you are applying.  Even if it is noticeable, perhaps you can turn it into a feature (eg - "the unholy aura effect lasts for 10 seconds after you throw away the skull of putrescence", or similar).

 

And to be honest I doubt it really takes that much extra time to check a player's inventory slots for a particular item ID.  You could try it with a profiler and see if it is a significant slowdown or not.

 

All the other solutions sound a bit fragile to me.

 

Cheers

  TGG

 

[Draco18s]

And to be honest I doubt it really takes that much extra time to check a player's inventory slots for a particular item ID

 

And then read that item's NBT data.

This isn't "oh, Item ID 1322 increases your health" it "Item ID 1322 {["onOwned":"increaseHealth"}]" vs. "Item ID 1322 {["onOwned":"increaseSpeed"}]" vs. "Item ID 1322 {["onUpdate":"heal1"}]" vs. "Item ID 1322 {["onRightClick":"causeLightning"}]" vs....

 

Anyway, if we're going to call things features, I think it would be a more interesting "feature" that items in frames are permanent boosts.

It's like a litch's phylactery!

 

It just isn't meaningful in SSP: no one can try and sneak into your base and "destroy" your powerbase.

[TheGreyGhost]

Now there's an idea for a mod

 

All I can suggest is that you try it with benchmarking and see if there really is a noticeable speed hit.  I'm fresh out of any other ideas.

 

-TGG

[Draco18s]

Now there's an idea for a mod

 

You mean the one I'm working on?

 

At last check I have over 67 million different items which may or may not have enchantments.

[Mazetar]

Lol draco, I'm giving you cred++; just for the signature you have on MCF there, nice one

[Draco18s]

Lol draco, I'm giving you cred++; just for the signature you have on MCF there, nice one

 

My signature arose from the fact that I tried to kindly remind someone that they shouldn't post in mod threads about updates.  I was all "hey, I just found out myself, but your post is technically against the TOS, didn't want to get you in trouble, just thought I'd let you know."

Someone decided I was being a total asshat.

Flames ensued.

 

I ended up reporting my own post to the mods for calling myself an asshole.

 

So I created my signature in an effort to deter such events in the future.

[Moritz]

Did you solve the problem with the itemframe alread? If not there should be a function which is called onInteractWithEntity(ItemStack par1, EntityPlayer player, EntityLivingBase par3)

{}