Jump to content

[1.6] Help adding a potion effect when my item is held


Seroe

Recommended Posts

Hello

 

I am trying to add a potion effect when my item is held that lasts until the player selects a different item.

 

    public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5, EntityPlayer par6)
    {
     if(par6.getCurrentEquippedItem().equals(getUnlocalizedName()))
     {
      par6.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 100, 3, true));
     }
     else
     {
      par6.curePotionEffects(par1ItemStack);
     }
    }

 

For some reason this doesn't work. How can I get it to work?

 

Here is the link to the full item's class: http://pastebin.com/R3EHXvif

 

Thanks in advance for the help.

Link to comment
Share on other sites

See line 153.

 

Probably not the best method in the world, but it works.

(Note: that particular class doesn't care about currently-active status, but that's just a flag)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I don't know where you came up with that onUpdate method, but the correct signature only has 5 parameters:

public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5) {}

With the incorrect signature, this method will never get called unless you call it yourself. Adding '@Override' above methods such as this will help prevent you from making simple mistakes in the future.

 

par5 is true if the itemstack is currently being used, so you could just check 'if (par5) add potion effect'

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.