Jump to content
Currently supported: All versions

OnWorldGenerator added

CreativeMD

By CreativeMD
in Suggestions

 Share

Recommended Posts

CreativeMD Creeper Killer

CreativeMD

Posted
Posted

Hi,

it would be very cool, if Forge could at a new event: OnWorldGenerator added and if they could change the worldgenerators from private to public because there is no way to get information out of the GameRegistry class.

It would be very helpful for my mod World Generation Manager.

CreativeMD Creeper Killer

CreativeMD

Posted
  • Author
Posted

Ok, the World Generation Manager allows you to regenerate a specific mod but therefore i need the worldGenerators of the mods. So i edited the base class (GameRegistry). So it would be very cool if there is an event for this and that the worldGenerators are public. What i mean is that it's currently private static. So you have no access to it. If you could change it to public static, other ways that modders would have to make their on list (with the event when a worldgenerator is added).

I hope you understand it :-)

CreativeMD Creeper Killer

CreativeMD

Posted
  • Author
Posted

No, my mod is working perfectly, but someone ask me if i could ask if this could be a standard feature of forge:

http://www.minecraftforum.net/topic/1879772-

 

You could actually add this in as a PR (Pull-Request, allows you to change Forge classes and submit the changes to go into the official source) for Forge, make it a bit easier for mods to do this. Would surely change Forge a lot, I'm looking for adding Retrogen ores (ores that generate after the world loads, aka ores that can generate in non-generated chunks) in my mod, so this would help :).

Mazetar World Shaper

Mazetar

Posted
Posted
  On 11/19/2013 at 8:29 PM, CreativeMD said:

You could actually add this in as a PR

 

Yeah... that's kinda how you do it when you are suggesting additions to an open source project...

Create the hook/event you need, submit the PR and if it's a reasonable and well implemented then the forge team will consider it and may end up adding it.

 

  Quote

If you guys dont get it.. then well ya.. try harder...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      Unable to update native luancher

      By TileEntity · Posted

      Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • Noureldien
      Unable to update native luancher

      By Noureldien · Posted

      can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • GPGPGold9393
      Death screen only shows the "You Died!" part

      By GPGPGold9393 · Posted

      The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept