Hello,

 

I'm currently updated my mod from 1.18.2 version to 1.20.2, and I was used to use the "FakePlayerFactory" that seems to have disappear in the 1.20.2 version.

This is how I created fake players.

	protected LivingEntity getOrCreateFakePlayer() {
        if (fakePlayer == null) {
            fakePlayer = FakePlayerFactory.getMinecraft((ServerLevel) this.level);
        }
        return fakePlayer;
    }

 

These fake players where used as parameters for creating a "LootParams" object like this :

protected LootParams constructLootParams(Mob mob) {
    Vec3 position = new Vec3(getBlockPos().getX(), getBlockPos().getY(), getBlockPos().getZ());
    Player fakePlayer = (Player) getOrCreateFakePlayer();

    return new LootParams.Builder((ServerLevel) this.level).withParameter(LootContextParams.ORIGIN, position)
      .withParameter(LootContextParams.THIS_ENTITY, mob)
      .withParameter(LootContextParams.DAMAGE_SOURCE, fakePlayer.damageSources().genericKill())
      .withParameter(LootContextParams.KILLER_ENTITY, fakePlayer)
      .withParameter(LootContextParams.LAST_DAMAGE_PLAYER, fakePlayer)
      .create(LootContextParamSets.ENTITY);
}

 So I would like to know if it is still possible to create fake players and if yes how ? And if not, how am I supposed to create the loot params in order to make it like it is a player that killed the entity ?

 

Thanks,

Edited December 31, 20231 yr by Sweetmimike

https://github.com/MinecraftForge/MinecraftForge/commit/90dafb0df0651b52102e25f6a252554cde884878

Quote

Rewrite our GameTest hooks to be sane.

Add game test to GlobalLootModifierTest which validates the smelting modifiers.

Removed FakePlayer system, it's broken and needs a major rewrite.

 I would guess Mojang's recent changes to networking are what broke that implementation?

i.e. the NetHandler/DummyConnection no longer works properly and no one has volunteered to fix it.

 

A fake player is something that extends ServerPlayer but makes most methods do nothing - the implementation that got deleted if you want to have a go at fixing it:

https://github.com/MinecraftForge/MinecraftForge/blob/d80f106140b30813432808f8b94da4d66e76dbfe/src/main/java/net/minecraftforge/common/util/FakePlayerFactory.java

https://github.com/MinecraftForge/MinecraftForge/blob/d80f106140b30813432808f8b94da4d66e76dbfe/src/main/java/net/minecraftforge/common/util/FakePlayer.java
 

Edited December 31, 20231 yr by warjort