Jump to content
Currently supported: All versions

"TileEntityConstructing" and/or "BlockCreated" events

CosmicDan

By CosmicDan
in Suggestions

 Share

Recommended Posts

CosmicDan Tree Puncher

CosmicDan

Posted
Posted

If these were possible, it would give us a lot of power and flexibility - there are many cases I can think of where this would save a significant number of operations/iterations, and open up other areas that are impossible without coremodding.

 

TileEntityConstructing is pretty self explainatory: I would think this'd be injected into the end of TileEntity#createAndLoadEntity. Such an event would allow mods to observe/modify TileEntity data in a less-direct manner (i.e. without a custom mod block within proximity of whichever block has the TE) and also a less-hacky manner (reflection/asm on specific tile entity classes). The main advantage of this is efficiency - a block, tick event, etc. currently has to constantly scan for TileEntities within whatever range, or globally if they're daring enough. Another advantage is simply to make the impossible possible - for example a specific game mechanic (e.g. summoning a boss) that does something to all applicable TE's (e.g. drain all the electricity from your base). This would be doable if a mod were to keep it's own central registry of TE's that it needs to interract as they are created, and just check this array/list/whatever as needed to do it's thing - but that's probably obvious.

 

BlockCreated is a similar idea, but for blocks. Not sure if this is possible/feasible, but it'd be potentially more useful. But maybe only along with an event that is fired when metadata for a block changes (or people can do that themselves with a tick event).

 

Only one is needed really, since it's simple to get one from the other. I would fork MinecraftForge and make a pull request for it, but I'm new to the MCP side of things. Seems that Forge has patch/diff files that it uses, and I know how to make these but I don't know of the specifics in how Forge is built or interracts with MCP. If anybody has some further reading on this, please let me know. That is unless the Forge collective don't see the point in this suggesion, which would be disappointing.

 

Thanks!

Windows software, Android hacking, and other curios

Link to comment
Share on other sites
  • 9 months later...
TheEdenCrazy Tree Puncher

TheEdenCrazy

Posted
Posted

After looking through the code a bit, I have found that createAndLoadTileEntity is called when a TE is loaded from nbt storage. If you want an event when a TE is placed, it needs to go in world#addTileEntity and/or the methods related to these like the methods for TE removal.

Link to comment
Share on other sites
LexManos Reality Controller

LexManos

Posted
Posted

Both should sufficiently be covered by the block events, and beyond that, there really isn't a good place to hook into this and pushing things like this out into the main event bus would just be horribly inefficient.

I don't see a real reason for you to need this exact event...

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites
Ernio Reality Controller

Ernio

Posted
Posted

Was about to write same thing.

Anyway - how do you people find topics that old?

 

Look into Forge's code before digging almost year old thread. Stuff changes over time.

 

If you need help in implemeting this (TheEdenCrazy) post what you need (exactly) in Modder Support.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites
Guest
This topic is now closed to further replies.
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • DDmce
      About mixin

      By DDmce · Posted

      So I saw that mixin is shipped as a library with forge, but is it available for 1.7.10 ?  
    • DDmce
      Weird idea on mods...

      By DDmce · Posted

      So I've read the EULA, and lets be straight...     If I split my modpack(of my mods, yeah I'm nuts) into several(many) individual mods(like just one boss) with minor additions(plus not working together), then have a complete/modpack version on patreon/onlyfans having each addon work together... Would people buy my idea?
    • graceholan64
      Gültige Ausgabe von Goethe A1-A2-B1-B2-C1-C2

      By graceholan64 · Posted

      German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate(+27(838-80-8170
    • Bubbles Walker
      crash when getting to loading the mods

      By Bubbles Walker · Posted

      Done, it still crashed. New log https://paste.ee/p/kYv6e
    • Beothorn
      [1.20.2] Textures for Block States that worked on 1.16 for Tile Entity are not working for Block Entity

      By Beothorn · Posted

      I am migrating a mod from 1.16.5 to 1.20.2 The version for 1.16.5 can be found here https://github.com/beothorn/automataCraft For the block called automata_start, it uses TileEntities and has blockstates, model/block and textures on json files. This is currently working fine on 1.16.5 https://github.com/beothorn/automataCraft/tree/master/src/main/resources/assets/automata For 1.20.2 I migrated the logic from TileEntities to BlockEntity. The mod is working fine. All blocks and Items are working with the correct textures except for the textures for each state of the automata_start block. No changes where made to the json files. This is the branch I am working on (there were some refactorings, but all is basically the same): https://github.com/beothorn/automataCraft/tree/1_20/src/main/resources/assets/automata The only difference I can think that may be related is that i had to implement createBlockStateDefinition on the BaseEntityBlock: https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L43 This is driving me crazy. I know the jsons are being loaded as I put a breakpoint at `net.minecraft.client.resources.model.ModelBakery#loadModel` and I can see BlockModelDefinition.fromJsonElement being called with automata_start. I also printed the state from the arguments of the tick function call and they look correct (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/Ticker.java#L32 ): blockState Block{automata:automata_start}[state=loadreplaceables] In game, all I see is the no textures. I think it is weird it is not the "missing texture" texture so I think it may be related to the material, but I had no success tweaking it (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L37).   public static final Property<AutomataStartState> state = EnumProperty.create("state", AutomataStartState.class); private final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType; private final Map<String, RegistryObject<Block>> registeredBlocks; public AutomataStartBlock( final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType, final Map<String, RegistryObject<Block>> registeredBlocks ) { super(BlockBehaviour.Properties.of().mapColor(MapColor.STONE).strength(1.5F, 6.0F)); this.blockEntityType = blockEntityType; this.registeredBlocks = registeredBlocks; this.registerDefaultState(this.getStateDefinition().any().setValue(state, AutomataStartState.LOAD_REPLACEABLES)); } @Override protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> stateBuilder) { stateBuilder.add(state); }     So my cry for help is, anyone has any ideas? Is there a way to easily debug this, for example somewhere where I can list the textures for a given state, or make sure this is loaded?   Thanks in advance for the hints

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept