1.8 CreativeTabs crash

BlazeAxtrius · January 29, 2015

public static final CreativeTabs tabNormalRails = new CreativeTabs(modid+"tabNormalRails") {
        public ItemStack getIconItemStack() {
                return new ItemStack(ERMBase.diamondRail, 1, 0);
        }

	@Override
	public Item getTabIconItem() {
		// TODO Auto-generated method stub
		return null;
	}

The game start normally but when I try to get to the second page in the inventory, the game crashes. This code is in the main mod file.

CoderAtParadise · January 29, 2015

Is diamond rail a block or an item

item

TheGreyGhost · January 29, 2015

By crikey dude, what did you think this line would do?

	@Override
	public Item getTabIconItem() {
		// TODO Auto-generated method stub
		return null;

and where did this method come from?

getIconItemStack()

This tutorial might help...

http://tutorials.darkhax.net/custom-creative-tabs.html

-TGG

BlazeAxtrius · January 30, 2015

Is diamond rail a block or an item

item

Its a block.

By crikey dude, what did you think this line would do?
	@Override
	public Item getTabIconItem() {
		// TODO Auto-generated method stub
		return null;
and where did this method come from?

getIconItemStack()

This tutorial might help...

http://tutorials.darkhax.net/custom-creative-tabs.html

-TGG

I used a tutorial to make it. The idea is that these rails are blocks and not items. That is why Item getTabIconItem() doesn't work and I use the ItemStack getIconItemStack()

Here is my github btw. https://github.com/BlazeAxtrius/ExpandedRailsMod

CoderAtParadise · January 30, 2015

Yes but itemstack looks for an item therefore you need to use Item.getItemFromBlock(yourBlock)

TheGreyGhost · January 30, 2015

I used a tutorial to make it. The idea is that these rails are blocks and not items. That is why Item getTabIconItem() doesn't work and I use the ItemStack getIconItemStack()

Here is my github btw. https://github.com/BlazeAxtrius/ExpandedRailsMod

your getIconItemStack() method does nothing because no code ever calls it.

When your creative tab is rendered, it calls the getTabIconItem() method to find out which Item's icon it should draw on the tab. You return null, the caller tries to draw it, and crashes because it expects a proper item. Your getTabIconItem() method needs to return the block's corresponding item as Voltab suggested.

Which tutorial did you use?

-TGG

BlazeAxtrius · January 30, 2015

Yes but itemstack looks for an item therefore you need to use Item.getItemFromBlock(yourBlock)

I changed the code however the game still crashed when I click the arrow that leads to my customtabs.

Eclipse doesn't show any errors.

public static final CreativeTabs tabNormalRails = new CreativeTabs(modid+"tabNormalRails") {

	public Item getTabIconItem() {
		// TODO Auto-generated method stub
		return Item.getItemFromBlock(diamondRail);
	}

I used a tutorial to make it. The idea is that these rails are blocks and not items. That is why Item getTabIconItem() doesn't work and I use the ItemStack getIconItemStack()

Here is my github btw. https://github.com/BlazeAxtrius/ExpandedRailsMod

your getIconItemStack() method does nothing because no code ever calls it.

When your creative tab is rendered, it calls the getTabIconItem() method to find out which Item's icon it should draw on the tab. You return null, the caller tries to draw it, and crashes because it expects a proper item. Your getTabIconItem() method needs to return the block's corresponding item as Voltab suggested.

Which tutorial did you use?

-TGG

i have no memory. I updated to the mod to 1.6.4 (that was 1 year ago) and then i decided to make the Tabs. I changed my PC so I don't have it in my history otherwise it was going to be easy.

BlazeAxtrius · January 30, 2015

I have the felling that it is this one

The Item getTabIconItem() I put in because i was getting an error for missing variables.

but in 1.6.4 and 1.7.x it was working even when this method was returning null;

BlazeAxtrius · January 30, 2015

Ok. I fixed it.

I am extremely retarded. I was using "rails" that i have excluded from the mod because I don't know how to

fix .getBlock and .getBlockMetadata.

Some rails have properties and I have excluded them so I can fix the rest that just rails.

If you can help me fix that too that will be great.

Here is how a rail with properties looks. I put 2 because one of them didn't have .getBlock.

package com.expanded.rails.mod.rails;

import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityMinecart;
import net.minecraft.world.World;

public class DiamondRail extends AllRails
{

    public DiamondRail(int par1)
    {
        super(par1);
        setHardness(0.7F);
        setStepSound(Block.soundTypeMetal);
        setUnlocalizedName("expandedrails:DiamondRail");
        // TODO Auto-generated constructor stub
    }

    public float getRailMaxSpeed(World world, EntityMinecart cart, int y, int x, int z)
    {
        return 0.5f;
    }

    public void onMinecartPass(World world, EntityMinecart cart, int x, int y, int z)
    {
        int blockMetaData = world.[b]getBlockMetadata[/b](x, y, z);

        if ((blockMetaData & 0x8) == 0)
        {
            {
                cart.motionX *= 3.5D;
                cart.motionY *= 0.0D;
                cart.motionZ *= 3.5D;
            }
        }
    }
}

package com.expanded.rails.mod.rails;

import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityMinecart;
import net.minecraft.world.World;

import com.expanded.rails.mod.ERMBase;

public class ArmedRail extends AllRails
{

    public ArmedRail(int par1)
    {
        super(par1);
        setHardness(0.7F);
        setStepSound(Block.soundTypeMetal);
        setUnlocalizedName("expandedrails:ArmedRail");
        // TODO Auto-generated constructor stub
    }

    public void onMinecartPass(World world, EntityMinecart cart, int x, int y, int z)
    {
        if ([b]world.getBlock[/b](x, y, z) == ERMBase.armedRail)
        {
            int blockMetaData = [b]world.getBlockMetadata[/b](x, y, z);
            world.createExplosion(cart, x, y, z, 0.3F, false);
            world.newExplosion(cart, x, y, z, 3.5F, true, true);
        }
    }
}

Draco18s · January 30, 2015

Ok. I fixed it.

I am extremely retarded. I was using "rails" that i have excluded from the mod because I don't know how to

fix .getBlock and .getBlockMetadata.

It might have something to do with getBlockState....

BlazeAxtrius · January 30, 2015

Ok. I fixed it.

I am extremely retarded. I was using "rails" that i have excluded from the mod because I don't know how to

fix .getBlock and .getBlockMetadata.

It might have something to do with getBlockState....

I read something about that, however with .getBlockState I don't know how to make it work. .getBlockState requires (blockpos1) but my method uses (x, y, z) and it doesn't work this way.

Also the Tabs names are (itemgroup.NoralmRails). How can I remove the "itemgroup." thing?

Draco18s · January 30, 2015

I read something about that, however with .getBlockState I don't know how to make it work. .getBlockState requires (blockpos1) but my method uses (x, y, z) and it doesn't work this way.

God damn. I wonder what a BlockPos is...

BlazeAxtrius · January 30, 2015

I read something about that, however with .getBlockState I don't know how to make it work. .getBlockState requires (blockpos1) but my method uses (x, y, z) and it doesn't work this way.

God damn. I wonder what a BlockPos is...

you description is really accurate . I don't know how to write it man.

public void onMinecartPass(World world, EntityMinecart cart, int x, int y, int z)

It doesn't accept "int" when i put .getBlockState.

Draco18s · January 30, 2015

No fucking shit. All of the x, y, z position coordinates for blocks changed to BlockPos. Use it.

BlazeAxtrius · January 30, 2015

No fucking shit. All of the x, y, z position coordinates for blocks changed to BlockPos. Use it.

public void onMinecartPass(World world, EntityMinecart cart, BlockPos pos1, int x, int y, int z)
    {
        if (world.getBlockState(pos1).getBlock() == ERMBase.armedRail)
        {
            IBlockState blockMetaData = world.getBlockState(pos1);
            world.createExplosion(cart, x, y, z, 0.3F, false);
            world.newExplosion(cart, x, y, z, 3.5F, true, true);
        }
    }

I changed the code in this and it doesn't show any errors, but this rail is supposed to explode when the cart passes it, which it doesn't do. I don't understand why it doesn't explode.

Also I don't know how to fix this or do i even need it. The BOLD part.

public void onMinecartPass(World world, EntityMinecart cart, BlockPos pos1, int x, int y, int z)
    {
        IBlockState blockMetaData = world.getBlockState(pos1);

        [b]if ((blockMetaData & 0x8) == 0)[/b]
        {
            {
                cart.motionX *= 3.5D;
                cart.motionY *= 0.0D;
                cart.motionZ *= 3.5D;
            }
        }

Draco18s · January 30, 2015

Put @Override on the line above the function. What happens?

BlazeAxtrius · January 30, 2015

Put @Override on the line above the function. What happens?

It shows an error "The method onMinecartPass must override or implement a supertype method.

Solutions shown are

"Create onMinecartPass() in super type AllRails"

"Create onMinecartPass() in super type ExpandedRails"

"Remove @Override annotation"

Draco18s · January 30, 2015

Le gasp! Your method signature is wrong and its not being called from anywhere!

BlazeAxtrius · January 30, 2015

Le gasp! Your method signature is wrong and its not being called from anywhere!

How can I call it from "EntityMinecart" since its there.

I updated my GitHub if it makes things easier.

https://github.com/BlazeAxtrius/ExpandedRailsMod

larsgerrits · January 30, 2015

No fucking shit. All of the x, y, z position coordinates for blocks changed to BlockPos. Use it.

BlazeAxtrius · January 30, 2015

I seriously don't get it.

Draco18s · January 30, 2015

Convert "int x, int y, int z" to BlockPos(x, y, z).

Fuck. This is basic java.

BlazeAxtrius · January 30, 2015

Convert "int x, int y, int z" to BlockPos(x, y, z).

Fuck. This is basic java.

public void onMinecartPass(World world, EntityMinecart cart, BlockPos pos1)
    {
        if (world.getBlockState(pos1) == ERMBase.chainRail)
        {
            IBlockState blockMetaData = world.getBlockState(pos1);
            double var41 = Math.sqrt(cart.motionX * cart.motionX + cart.motionZ * cart.motionZ);

            if (var41 < 0.05D)
            {
                double var43 = 0.1D;
                cart.motionX += cart.motionX / var41 * var43;
                cart.motionZ += cart.motionZ / var41 * var43;
            }
            else
            {
                cart.motionX += 0.0D;
                cart.motionZ += 0.0D;
            }
        }

In this rail it doesn't show any errors and the @Override works but it still doesn't work.

Also If i try to convert it from "int x, int y, int z" to BlockPos.

getBlockState() requires 1 BlockPos while createExplosion requires 3 int and I have no idea how to do that.

I tried to fix it but when i go over the rail the game crashes.

Also it might be basic java but I made this with a friend from watching tutorials and I have no idea what I am doing right now but I still want to make the mod work.

Draco18s · January 30, 2015

getBlockState() requires 1 BlockPos while createExplosion requires 3 int and I have no idea how to do that.

BlockPos.x? Jesus.

It might be xpos, or posx, I haven't actually used 1.8 yet, but I can't imagine its that difficult.

BlazeAxtrius · January 30, 2015

getBlockState returns an IBlockState. It will never be equal to a Block.

Thanks I fixed it now. But

public void onMinecartPass(World worldObj, EntityMinecart cart, BlockPos pos1)
    {
        if (worldObj.getBlockState(pos1).getBlock() == ERMBase.armedRail)
        {
            IBlockState blockMetaData = worldObj.getBlockState(pos1);
            worldObj.createExplosion(cart, [b]x, y, z[/b], 0.3F, false);
            worldObj.newExplosion(cart, [b]x, y, z[/b], 3.5F, true, true);
        }
    }

Ths BOLD things I dont know how to fix

Sign In

1.8 CreativeTabs crash

Recommended Posts

BlazeAxtrius

CoderAtParadise

TheGreyGhost

BlazeAxtrius

CoderAtParadise

TheGreyGhost

BlazeAxtrius

BlazeAxtrius

BlazeAxtrius

Draco18s

BlazeAxtrius

Draco18s

BlazeAxtrius

Draco18s

BlazeAxtrius

Draco18s

BlazeAxtrius

Draco18s

BlazeAxtrius

larsgerrits

BlazeAxtrius

Draco18s

BlazeAxtrius

Draco18s

BlazeAxtrius

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information