[1.7.10] Entity adding light not working

[Thornack]

Hi I have been trying to add light to my entity and it doesnt seem to work. The method is called inside my entities onLivingUpdate method but no light shows up. anyone know what the issue is.

 

@Override
    public void onLivingUpdate() {
    	super.onLivingUpdate();
    	
    	this.addLight();
    	
    	   }

 private void addLight() {
	 System.out.println("add Light is being called");  //THIS GETS OUTPRINTED ON UPDATE SO IT IS BEING CALLED
	 this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY, (int) this.posZ, 16); 
	  this.worldObj.markBlockRangeForRenderUpdate((int) this.posX,
	    (int) this.posY, (int) this.posX, 12, 12, 12);
	  this.worldObj.markBlockForUpdate((int) this.posX, (int) this.posY,
	    (int) this.posZ);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY + 1, (int) this.posZ);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY - 1, (int) this.posZ);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block,
	    (int) this.posX + 1, (int) this.posY, (int) this.posZ);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block,
	    (int) this.posX - 1, (int) this.posY, (int) this.posZ);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY, (int) this.posZ + 1);
	  this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY, (int) this.posZ - 1);
	 }

 

[HappyKiller1O1]

Try changing:

 

this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY, (int) this.posZ, 16); 

 

To:

this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX,
	    (int) this.posY, (int) this.posZ, 15); 

 

If that doesn't work, trying putting "this.addLight" before you call the super.

[Thornack]

That worked, But wow does that ever lag minecraft Im going to not use that haha

[Draco18s]

That worked, But wow does that ever lag minecraft Im going to not use that haha

 

Yep, lighting recalc isn't very fast.  That's why I used a fake lighting block that only updates if the "source" moves 4(?) blocks away from it.  Keeps the updates to a minimum while providing a decent amount of light.

https://github.com/Draco18s/Artifacts/blob/master/main/java/com/draco18s/artifacts/components/ComponentLight.java#L93