Posted March 26, 201510 yr Hi I have been trying to add light to my entity and it doesnt seem to work. The method is called inside my entities onLivingUpdate method but no light shows up. anyone know what the issue is. @Override public void onLivingUpdate() { super.onLivingUpdate(); this.addLight(); } private void addLight() { System.out.println("add Light is being called"); //THIS GETS OUTPRINTED ON UPDATE SO IT IS BEING CALLED this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX, (int) this.posY, (int) this.posZ, 16); this.worldObj.markBlockRangeForRenderUpdate((int) this.posX, (int) this.posY, (int) this.posX, 12, 12, 12); this.worldObj.markBlockForUpdate((int) this.posX, (int) this.posY, (int) this.posZ); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX, (int) this.posY + 1, (int) this.posZ); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX, (int) this.posY - 1, (int) this.posZ); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX + 1, (int) this.posY, (int) this.posZ); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX - 1, (int) this.posY, (int) this.posZ); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX, (int) this.posY, (int) this.posZ + 1); this.worldObj.updateLightByType(EnumSkyBlock.Block, (int) this.posX, (int) this.posY, (int) this.posZ - 1); }
March 26, 201510 yr Try changing: this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX, (int) this.posY, (int) this.posZ, 16); To: this.worldObj.setLightValue(EnumSkyBlock.Block, (int) this.posX, (int) this.posY, (int) this.posZ, 15); If that doesn't work, trying putting "this.addLight" before you call the super. I am not a cat. I know my profile picture is sexy and amazing beyond anything you could imagine but my cat like features only persist in my fierce eyes. I might be a cat.
March 27, 201510 yr Author That worked, But wow does that ever lag minecraft Im going to not use that haha
March 27, 201510 yr That worked, But wow does that ever lag minecraft Im going to not use that haha Yep, lighting recalc isn't very fast. That's why I used a fake lighting block that only updates if the "source" moves 4(?) blocks away from it. Keeps the updates to a minimum while providing a decent amount of light. https://github.com/Draco18s/Artifacts/blob/master/main/java/com/draco18s/artifacts/components/ComponentLight.java#L93 Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.