[1.7.10] Trouble with Auto Repair

[HappyKiller1O1]

Hey so, I am trying to set a timer for my auto repair and, I really wish it would work. I am using ticks and basically, the int constantly is set back to zero. Here is my code:

public void onUpdate(ItemStack stack, World world, Entity entity, int i, boolean flag) { //3600 = 3 minutes
	fixNBT(stack);

	if(stack.stackTagCompound.getBoolean("AutoRepair")) {
		if(stack.isItemDamaged()) {
			int autoRepairDelay = 0;

			if(autoRepairDelay < 3600)
				autoRepairDelay++;

			LogHelper.logInfo("Delay: " + autoRepairDelay);

			if(autoRepairDelay == 3600) {
				stack.damageItem(-1, (EntityPlayer)entity);

				autoRepairDelay = 0;
			}
		}
	}
}

 

The autoRepairDelay NEEDS to be initialized before I can edit it but, if I set it to zero it will constantly be reset to zero and my number gets stuck going back and forth from one to zero. If I make the int declared in my class it works but, when you have two of the item in your inventory to repair it screws up. Any way to do this?

[Elix_x]

Plus, you don't read it, you just initialise it with 0... Do you think mc will magically read it from nbt?

[HappyKiller1O1]

My problem is not setting and reading from NBT, even if it is set to NBT it will still be constantly set to that number.

[HappyKiller1O1]

Plus, you don't read it, you just initialise it with 0... Do you think mc will magically read it from nbt?

You do know I have not added any number to NBT yet, right?

[Draco18s]

Plus, you don't read it, you just initialise it with 0... Do you think mc will magically read it from nbt?

You do know I have not added any number to NBT yet, right?

You do know that if you don't, your code is going to do fucknothing, right?

[HappyKiller1O1]

Yes, I get that. My problem still is I need to make a timer. Even if I set my Integer to a Integer set in the stack's NBT it still gets reset every time. Am I suppose to just use that number and constantly save and load the nbt to raise the number?

[Draco18s]

How about you show us code where you save that variable to the NBT and read it back out again.

[HappyKiller1O1]

Honestly, I know I gotta be doing something wrong.

 

public void onUpdate(ItemStack stack, World world, Entity entity, int i, boolean flag) { //3600 = 3 minutes
	fixNBT(stack);

	if(stack.stackTagCompound.getBoolean("AutoRepair")) {
		if(stack.isItemDamaged()) {
			int autoRepairDelay = stack.stackTagCompound.getInteger("RepairDelay");

			if(autoRepairDelay < 3600)
				autoRepairDelay++;

			LogHelper.logInfo("Delay: " + autoRepairDelay); //TODO WORK ON AUTO REPAIR

			if(autoRepairDelay == 3600) {
				stack.damageItem(-1, (EntityPlayer)entity);

				autoRepairDelay = stack.stackTagCompound.getInteger("RepairDelay");
			}
		}
	}
}

public static void fixNBT(ItemStack stack){
	if(stack.stackTagCompound == null) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack NBTTagCompound was null. Attempting fix...");

		stack.stackTagCompound = new NBTTagCompound();
	}

	/*if(!stack.stackTagCompound.hasKey("HammerTag")) {
		stack.stackTagCompound.setTag("HammerTag", new NBTTagCompound());
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'HammerTag'. Attempting fix...");
	}*/

	if(!stack.stackTagCompound.hasKey("RepairDelay")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'RepairDelay'. Attempting fix...");

		stack.stackTagCompound.setInteger("RepairDelay", 0);
	}

	if(!stack.stackTagCompound.hasKey("MiningSize")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'MiningSize'. Attempting fix...");

		stack.stackTagCompound.setString("MiningSize", "3x3");
	}

	if(!stack.stackTagCompound.hasKey("AutoSmelt")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'AutoSmelt'. Attempting fix...");

		stack.stackTagCompound.setBoolean("AutoSmelt", false);
	}

	if(!stack.stackTagCompound.hasKey("AutoRepair")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'AutoRepair'. Attempting fix...");

		stack.stackTagCompound.setBoolean("AutoRepair", false);
	}

	if(!stack.stackTagCompound.hasKey("Has3x3")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'Has3x3'. Attempting fix...");

		stack.stackTagCompound.setBoolean("Has3x3", false);
	}

	if(!stack.stackTagCompound.hasKey("Has5x5")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'Has5x5'. Attempting fix...");

		stack.stackTagCompound.setBoolean("Has5x5", false);
	}

	if(!stack.stackTagCompound.hasKey("Has7x7")) {
		LogHelper.logWarn("[CrewHammer] " + "The ItemStack did not contain the key 'Has7x7'. Attempting fix...");

		stack.stackTagCompound.setBoolean("Has7x7", false);
	}
}

 

It's set in fixNBT and read in onUpdate. I was thinking about setting a variable to my class and setting it equal to the saved Integer? Not sure if that would work though.

[HappyKiller1O1]

That was my problem for that. In 1.6.4 I made a timer just fine but I can't remember how I did.

[HappyKiller1O1]

Anyone got any ideas? I honestly am not sure how to use NBT to fix this.

[Abastro]

Honestly, I know I gotta be doing something wrong.

 

public void onUpdate(ItemStack stack, World world, Entity entity, int i, boolean flag) { //3600 = 3 minutes
	fixNBT(stack);

	if(stack.stackTagCompound.getBoolean("AutoRepair")) {
		if(stack.isItemDamaged()) {
			int autoRepairDelay = stack.stackTagCompound.getInteger("RepairDelay");

			if(autoRepairDelay < 3600)
				autoRepairDelay++;
[/quote]
You should save the local variable(autoRepairDelay) into the stackTagCompound, otherwise it would just get lost.
Use NBTTagCompount#setInteger for that.

[HappyKiller1O1]

Hm, see I understand that but, in changing it to go up and down like a timer; wouldn't I have to constantly save and load from NBT?

[Ernio]

Yes, you would. In every onUpdate() you will first get NBT integer, if found you increment it and save back to NBT, if not found, you make new one, increment and save it back. That's it. You get -> increment -> save.

 

NBT is nothing but just a big-ass map.

Note that even if that is not very bad design, there are still better ones (more efficient), but require a lot more coding.

[Sbeagin]

If I understand you'r issue correctly then all you need to do is declare an integer outside of the onUpdate function

Something like:

private in ticks = 0;
public void onUpdate(ItemStack stack, World world, Entity entity, int i, boolean flag)
{
    if(ticks == 400)//400 is the amount of ticks to wait. 20 ticks = 1 second
    {
        stack.setItemDamage(stack.getItemDamage() + 1);
        ticks = 0;
    }
    else
    {
        ticks++;
    }


}

should work just fine!

Hope this helped 

[Ernio]

Sbeagin - you might know Java, but in this case you wrote something that is not even remotely correct for Minecraft/Forge coding.

Never, ever, forever you should declare ANY fields inside Item that are not shared between all Items.

 

Item is merely an instance of something that represents item, ItemStack is the actual "thing" that you hold, and only ItemStack can hold data (NBT).

[HappyKiller1O1]

If I understand you'r issue correctly then all you need to do is declare an integer outside of the onUpdate function

Something like:

private in ticks = 0;
public void onUpdate(ItemStack stack, World world, Entity entity, int i, boolean flag)
{
    if(ticks == 400)//400 is the amount of ticks to wait. 20 ticks = 1 second
    {
        stack.setItemDamage(stack.getItemDamage() + 1);
        ticks = 0;
    }
    else
    {
        ticks++;
    }


}

should work just fine!

Hope this helped 

 

Thanks for attempting to help but, like Ernio said: declaring a field in the item class would be for every one of those Items. That would mean that, for one: the tick count would be shared between all of that Item. And secondly, you could not repair two of the item in your inventory.