Jump to content

Recommended Posts

Posted

Show the code for the

isOffCooldown(...)

method.  We need to know why you need access to a World there.

As well as why that function is calling

getCooldown(...)

 

Notably, because isOffCooldown is calling getCooldown, you could just add a World param to getCooldown and then pass it, then badabing, you have your world object (but still have an infinite loop).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

here is a way of implementing an item with a cooldown without the need of any hack:

 

/**
* you can extend this class to implement any item that has a cooldown
* @author Kauan99
* 
*/
public class CooldownItem extends Item
{
final int cooldown;//in ticks. ideally, minecraft runs at 20 ticks per second

public CooldownItem(int cooldown)
{
	super();//if you extend something else, you have to call the proper constructor
	this.cooldown = cooldown;
}

@Override
    public void onCreated(ItemStack stack, World world, EntityPlayer player)
    {
	/*
	 * this method can be used to create the NBT if the item is crafted on a workbench.
	 * wont be invoked in creative though (I think)
	 */
	if(stack.stackTagCompound == null)
		stack.stackTagCompound = new NBTTagCompound();

	stack.stackTagCompound.setLong("lastuse", world.getTotalWorldTime());
    }
    
@Override
    public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player)
    {
	if(!world.isRemote)
	{
		if(stack.stackTagCompound != null)
		{
	        if(!isOnCoolDown(stack, world))
	        {
	        	stack.stackTagCompound.setLong("lastuse", world.getTotalWorldTime());
	        	doAction(stack, world, player);
	        }
	        else
	        {
	        	/*
	        	 * this message here just for test purposes. you could remove this else clause entirely in your actual code
	        	 */
	        	player.addChatMessage(new ChatComponentText("you could not use the item because it's on cooldown. wait " + (cooldown - (world.getTotalWorldTime() - stack.stackTagCompound.getLong("lastuse"))) + " more ticks to use it"));
	        }
		}
		else
		{
			stack.stackTagCompound = new NBTTagCompound();
			stack.stackTagCompound.setLong("lastuse", world.getTotalWorldTime());

			/* 
			 * bellow we have an example of recursion. this method calls itself, but we are certain this will happen only
			 * once for each item stack
			 */
			return this.onItemRightClick(stack, world, player);
		}
	}
	return stack;
        /*
         * or you could make this class extend something that already does stuff when used. just replace line above with
         * return super.onRightClick(stack, world, player);
         */
    }	

/**
 * override this each item that has a cooldown
 * @param stack
 * @param world
 * @param player
 */
protected void doAction(ItemStack stack, World world, EntityPlayer player)
{
	//possibly cause damage to the item stack and whatever else you want it to do.
	//message bellow just for test purposes, remove it in your actual code.
	player.addChatMessage(new ChatComponentText("the item is doing its thing"));
}

public boolean isOnCoolDown(ItemStack stack, World world)
{
	long lastUse = stack.stackTagCompound.getLong("lastuse");
	long rightNow = world.getTotalWorldTime();
	return rightNow - lastUse < cooldown;	
}
}

 

edit: no idea why the indentation got all messed up, but if you paste that into eclipse and ctrl+i the code it will get properly indented.

WIP mods: easyautomation, easyenergy, easyelectronics, easymoney, easytrasportation, easysecurity, easymultiverse, easyfactions, easymagick, easyalchemy, easyseasons

Posted

FYI: The OP's code is adapted from an example I provided in their previous thread.

 

pretty similar to what I came up with. this is probably the only decent way to do it, since we both came up with virtually the same solution.

WIP mods: easyautomation, easyenergy, easyelectronics, easymoney, easytrasportation, easysecurity, easymultiverse, easyfactions, easymagick, easyalchemy, easyseasons

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • 1) Update to the latest build of Forge for your MC version. The recommended build actually means minimum recommended. I can’t remember if it was backported to 1.20.1 or not, but we did clean up the early loading screen a bit in newer builds to look less cluttered. 2) Change the accessibility setting in game to black background. The early loading screen will then be black instead of red.
    • I'm sure this entire community knows exactly who you are, what mixin you're talking about, and how deer function in minecraft.  But being new here, and I am ignorant about all of those things. That said, I'd love to review your mixin.  I'm also having mixin issues, and I feel that if I can help you, perhaps both of our problems might get solved. Can you provide some links and context for people who aren't aware of your renown?  I'm asking humbly because I know you probably have better things to do, and you just want somebody to fix things for you.
    • I am working in the latest MDK.  Minecraft 1.21.4, Forge 54.1.0. I am trying to create a mixin.  The implementation doesn't matter.  Assume it is doing nothing more than logging to the console: @Mixin(LevelRenderer.class) public abstract class LevelRendererMixin { private static final Logger LOGGER = LogManager.getLogger("LevelRendererMixin"); @Inject(method = "renderLevel", at = @At("TAIL")) private void onRenderLevel( com.mojang.blaze3d.resource.GraphicsResourceAllocator allocator, net.minecraft.client.DeltaTracker deltaTracker, boolean someFlag, Camera camera, GameRenderer gameRenderer, Matrix4f matrix1, Matrix4f matrix2, CallbackInfo ci ) { Assuming my whole implementation is just to write something to console, it works perfectly fine in when I debug (runClient) in IntelliJ.  Whenever the Minecraft `renderLevel` runs every frame, my logging is overlaid at "TAIL". Yes, this spams the sht out of the console. But when I `build` and use the jar as a mod, it does not.  The mixin annotation processor shows to be loading, and my other parts of my mod work, but the nothing gets logged by my mixin. I am apparently generating a proper `refmap` and it's in the jar root.  Other files are also in the jar appropriately, including mods.toml.  And all the naming and reference paths are correct. I had to add this to my build.gradle to get my refmap into the jar ([name] obviously replaced): tasks.register("copyRefmap", Copy) { dependsOn tasks.named("compileJava") from("${project.buildDir}/tmp/compileJava") { include "mixins.[name].refmap.json" } into("${project.buildDir}/resources/main") } tasks.named("processResources", ProcessResources).configure { dependsOn(tasks.named("copyRefmap")) } tasks.named("jar", Jar).configure { // Include the generated refmap from build/resources/main into the jar. from("${project.buildDir}/resources/main") { include "mixins.[name].refmap.json" } }   Just for fun, here is my refmap in case something looks wrong to anybody:   { "mappings": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } }, "data": { "searge": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } } } } TLDR; My mixin works in dev, but not when built and run in an official Forge/Minecraft environment.  Like it's not overlaying/replacing the minecraft function. What are some typical other things to check when a mixin works in dev, but not after build?
    • Thank you, Ugdhar.  But that only confirms the problem.  Both in the github and in my IDE, if I search for objects extended from net.minecraftforge.client.event, it isn't there.  Though the javadocs (at least at nekoyue) say it should be. Maybe since it definitely isn't there, is there some other way anybody knows to highlight some blocks (without mixins and drawing artificial faces on the camera).
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.