Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

ASM retransform

NiceDev

By NiceDev
in Modder Support

 Share

Recommended Posts

Draco18s Reality Controller

Draco18s

Posted
Posted

Long story short:

You're doing it wrong.

 

Long version:

What are you trying to transform and why?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
NiceDev Tree Puncher

NiceDev

Posted
  • Author
Posted

Long story short:

You're doing it wrong.

 

Long version:

What are you trying to transform and why?

 

Sorry, I'm an asm skid, because I don't understand it ._.

I override the method "shouldCombineTextures" in the "LayerArmorBase" class. Here is my source:

 

LayerArmorBaseTransformer: http://hastebin.com/oqavulijow.m

LayerArmorBaseClassVisitor: http://hastebin.com/ajeruricuh.axapta

ShouldCombineTexturesInstructionAdapter: http://hastebin.com/erusefepar.java

Link to comment
Share on other sites
NiceDev Tree Puncher

NiceDev

Posted
  • Author
Posted

Why are you transforming the class? Especially if you have no idea what you're doing...

I want, that the armor is red at damaging, too. In the new version (1.8) it has been changed.

This Transformer works, too, but I want to change it by changing the config in the config-gui I created.

Link to comment
Share on other sites
NiceDev Tree Puncher

NiceDev

Posted
  • Author
Posted

Please explain better. You want to make the armor you're wearing red?

There is no need for this you can just add/edit layers.

No, but the armor is not going to be red, when the entity gets damage. With this fix, it's going to be red.

 

Without fix:

SMpDWrm.png

 

With fix:

JzVEswi.png

Link to comment
Share on other sites
LexManos Reality Controller

LexManos

Posted
Posted

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites
NiceDev Tree Puncher

NiceDev

Posted
  • Author
Posted

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

Just how?

Link to comment
Share on other sites
EverythingGames Diamond Finder

EverythingGames

Posted
Posted

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

Just how?

 

Like mentioned above, you would add / edit the armor layers / armor rendering. Try looking into the RenderPlayerEvent - all rendering for the player is done there, including armor rendering (pretty sure - look into ModelPlayer.class and RenderPlayer.class to find more info on the biped layers for the player). Also, look at LayerBipedArmor.class and LayerArmorBase.class. Maybe you could create a new player model with the player's skin, 3 / 4 pixel arms, and armor (except the armor is made red) and cancel the vanilla model in the RenderPlayerEvent. I've done similar, it can be done.

Development of Plugins [2012 - 2014] Development of Mods [2012 - Current]

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • KevinManEc
      Skipped Language

      By KevinManEc · Posted

      Hello, I was trying to play a MOD in my preferred language, but I see that only some items are translated, and I go to debug and I get this information (the only thing that is translated is the bestiary):   [14sep.2024 17:14:36.415] [Render thread/WARN] [net.minecraft.client.resources.language.ClientLanguage/]: Skipped language file: mowziesmobs:lang/es_es.json (com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Expected name at line 394 column 2 path $.config.mowziesmobs.ice_crystal_attack_multiplier) [14sep.2024 17:14:36.421] [Render thread/WARN] [net.minecraft.client.resources.language.ClientLanguage/]: Skipped language file: iceandfire:lang/es_es.json (com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Unterminated object at line 1349 column 4 path $.iceandfire.sound.subtitle.dragonflute)   Is that the reason why everything is not translated? , and is there any way to fix it? Thanks
    • Shipwrecker
      [1.20.1] Can't figure out how to get EntityRendererProvider.Context - Difficulty getting custom player model to render

      By Shipwrecker · Posted

      I got my model to render from the models renderToBuffer method. But still not quite what I want. I want to render the model from my renderer's render method. I feel that having access to the renderer and its methods will open some doors for me later down the line. //EntityRendererProvider.Context pContext = ; I want this //ToaPlayerRenderer render = new ToaPlayerRenderer(pContext, false); // if I can get the above line to work, having the methods from the renderer class would be incredibly helpful down the line RenderType rendertype = model.renderType(p.getSkinTextureLocation()); // this should be something like render.getTextureLocation() VertexConsumer vertexconsumer = buffer.getBuffer(rendertype); model.renderToBuffer(stack, vertexconsumer, paLights, 1, 1, 1, 1, 1); // I don't want the render to happen here since it doesn't use the renderer //model.render(p, 1f, pTicks, stack, buffer, paLights); I want to render the model using this It is certainly getting closer though. Probably. I am still worried that even if pContext is initialized this new instance of the renderer class will still hit me with the classic and all too familiar "can't use static method in non-static context"
    • Theral9
      ServerF

      By Theral9 · Posted

      server  
    • Sora666
      PartEntity Issues

      By Sora666 · Posted

      Hello, I am learning how to create Multipart Entities and I tried creating a PartEntity based on the EnderDragonPart code. However, when I tested summoning the entity in the game, the PartEntity appeared at position x 0, y 0, z 0 within the game. I tried to make it follow the main entity, and after testing again, the part entity followed the main entity but seemed to teleport back to x 0, y 0, z 0 every tick (I'm just guessing). I don't know how to fix this can someone help me? My github https://github.com/SteveKK666/Forge-NewWorld-1.20.1/tree/master/src/main/java/net/kk/newworldmod/entity/custom Illustration  https://drive.google.com/file/d/157SPvyQCE8GcsRXyQQkD4Dyhalz6LjBn/view?usp=drive_link Sorry for my English; I’m not very good at it. 
    • 3.1459
      Can Someone help me understand this?

      By 3.1459 · Posted

      its still crashing with the same message

  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept