ASM retransform

[NiceDev]

Hello,

I want to use a transformer twice (on config change), but how can I reuse a Transformer?

 

 

[Draco18s]

Long story short:

You're doing it wrong.

 

Long version:

What are you trying to transform and why?

[NiceDev]

  On 10/26/2015 at 9:50 PM, Draco18s said:

Long story short:

You're doing it wrong.

 

Long version:

What are you trying to transform and why?

 

Sorry, I'm an asm skid, because I don't understand it ._.

I override the method "shouldCombineTextures" in the "LayerArmorBase" class. Here is my source:

 

LayerArmorBaseTransformer: http://hastebin.com/oqavulijow.m

LayerArmorBaseClassVisitor: http://hastebin.com/ajeruricuh.axapta

ShouldCombineTexturesInstructionAdapter: http://hastebin.com/erusefepar.java

[LexManos]

Why are you transforming the class? Especially if you have no idea what you're doing...

[NiceDev]

  On 10/26/2015 at 9:59 PM, LexManos said:

Why are you transforming the class? Especially if you have no idea what you're doing...

I want, that the armor is red at damaging, too. In the new version (1. it has been changed.

This Transformer works, too, but I want to change it by changing the config in the config-gui I created.

[LexManos]

Please explain better. You want to make the armor you're wearing red?

There is no need for this you can just add/edit layers.

[NiceDev]

  On 10/26/2015 at 10:18 PM, LexManos said:

Please explain better. You want to make the armor you're wearing red?

There is no need for this you can just add/edit layers.

No, but the armor is not going to be red, when the entity gets damage. With this fix, it's going to be red.

 

Without fix:

 

With fix:

[LexManos]

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

[NiceDev]

  On 10/27/2015 at 8:48 AM, LexManos said:

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

Just how?

[EverythingGames]

  On 10/30/2015 at 9:35 PM, NiceDev said:

  Quote

Yup, you dont need ASM for this, you can just replace the layer for rendering armor.

Always, ALWAYS use ASM as a last resort, you have adequate non-asm-hacky options to solve this.

Also, Is this an actual bug or is it a intended feature of vanilla minecraft?

Just how?

 

Like mentioned above, you would add / edit the armor layers / armor rendering. Try looking into the RenderPlayerEvent - all rendering for the player is done there, including armor rendering (pretty sure - look into ModelPlayer.class and RenderPlayer.class to find more info on the biped layers for the player). Also, look at LayerBipedArmor.class and LayerArmorBase.class. Maybe you could create a new player model with the player's skin, 3 / 4 pixel arms, and armor (except the armor is made red) and cancel the vanilla model in the RenderPlayerEvent. I've done similar, it can be done.