[1.8.9][SOLVED] Extended Entity Properties

[DiabolicaTrix]

Hi, I made an Extended Entity Properties because I want to save some data but when the player dies, the data is not saved and I don't know why.

 

 

Code: https://www.github.com/DiabolicaTrix/MinecraftLifeRPG

[diesieben07]

IEEP does not survive player death by default. You need to copy over the data from the old IEEP to the new in PlayerEvent.Clone if event.wasDeath is true.

[DiabolicaTrix]

Oh, I forgot, the EEP is only saved on server side. I tried to put a Sysout in my debugItem and the output is: 


[10:47:10] [Client thread/INFO] [sTDOUT]: [me.diabolicatrix.items.ItemDebug:onItemUse:49]: 0 !
[10:47:10] [server thread/INFO] [sTDOUT]: [me.diabolicatrix.items.ItemDebug:onItemUse:49]: 2 !


and here is my onPlayerClone event:

    @SubscribeEvent

    public void onPlayerClone(PlayerEvent.Clone event)

    {

        if(event.wasDeath)

        {

            NBTTagCompound compound = new NBTTagCompound();

            PlayerEEP.get(event.original).saveNBTData(compound);

            PlayerEEP.get(event.entityPlayer).loadNBTData(compound);

        }

    }

[diesieben07]

I do not see any issue. The output is exactly what you'd expect.

[Choonster]

It's worth noting that

IEEP

has been deprecated in favour of the Capability system and may eventually be removed.

[DiabolicaTrix]

@diesieben07 No it's not, I want the EEP to be synced with the client

 

 

@Choonster Oh, I didn't know, I'll give it a try.

[jabelar]

@diesieben07 No it's not, I want the EEP to be synced with the client

 

That doesn't happen automatically. If code on one side (like server) is changing the EEP without similar code running on client, then you'd have to use a custom packet I think to sync it.

 

Also, are you doing this for your own custom entity or adding EEP for vanilla entities. For your own custom entities you don't really need to use the EEP system, but rather can directly override the writeToNBT() and readFromNBT() methods. But again, to sync client to server you need a packet.

[DiabolicaTrix]

Ok, I tried with the Capabilities but it's doing the exact same thing, the value is saved server-side only. https://github.com/DiabolicaTrix/MinecraftLifeRPG/blob/master/src/main/java/me/diabolicatrix/other/PlayerCapabilities.java

[diesieben07]

Things don't get synced by magic. You have to do it yourself using packets.

[DiabolicaTrix]

Sorry, I misexplained. The AttachCapabilitiesEvent is called before the PlayerCloneEvent on client-side but it works on server-side.

 

 

 

[15:30:19] [server thread/INFO] [sTDOUT]: [me.diabolicatrix.events.CommonEventHandler:onAttachCapability:62]: Attach Server

[15:30:19] [server thread/INFO] [sTDOUT]: [me.diabolicatrix.events.CommonEventHandler:onPlayerCloned:49]: Clone (server only)

[15:30:19] [Client thread/INFO] [sTDOUT]: [me.diabolicatrix.events.CommonEventHandler:onAttachCapability:62]: Attach Client

 

 

So even if I try to sync with a packet, the value will be overwritten by the attach event.

[diesieben07]

Not sure what you are saying here. The attach event should (especially not on the client!) set any data.

[DiabolicaTrix]

In my constructor, I set the default values of my variables. And when I attach the capability, I make a new Instance of PlayerCapabilities.

[diesieben07]

That will not be a problem, since the sync packet cannot possibly operate before your capabilities have finished attaching.

[DiabolicaTrix]

It's doing exactly what I said before:

 

 

 

[16:43:24] [server thread/INFO] [sTDOUT]: [me.diabolicatrix.events.CommonEventHandler:onAttachCapability:62]: Attach Server

[16:43:24] [Netty Local Client IO #1/INFO] [sTDOUT]: [me.diabolicatrix.packets.PacketSyncCapabilities$ClientHandler:onMessage:58]: Packet Received

[16:43:24] [Client thread/INFO] [sTDOUT]: [me.diabolicatrix.events.CommonEventHandler:onAttachCapability:62]: Attach Client

[diesieben07]

Sounds like you didn't read the warning box on this page.

[DiabolicaTrix]

Oh, that solves all my problems! I just started using forge 1.8 so I didn't know the packets were handled differently. Thanks you very much for your help.

 

 

EDIT: I tought it would work but it doesn't, the value is still overwritten by the constructor.

[diesieben07]

Show the capability code and where you attach it as well as your network code.

[DiabolicaTrix]

Where I attach it: https://github.com/DiabolicaTrix/MinecraftLifeRPG/blob/master/src/main/java/me/diabolicatrix/events/CommonEventHandler.java

 

 

My capabilities class: https://github.com/DiabolicaTrix/MinecraftLifeRPG/blob/master/src/main/java/me/diabolicatrix/other/PlayerCapabilities.java

 

 

My packet: https://github.com/DiabolicaTrix/MinecraftLifeRPG/blob/master/src/main/java/me/diabolicatrix/other/PlayerCapabilities.java And https://github.com/DiabolicaTrix/MinecraftLifeRPG/blob/master/src/main/java/me/diabolicatrix/other/ScheduledPacketTask.java

 

 

Also, how do I save it when the player disconnect?

[diesieben07]

Why are all your packets two way? That is a very bad idea.

Then you are also accessing Minecraft#thePlayer while still on the netty thread, don't do that.

[DiabolicaTrix]

only my sync packets are two ways? Ok, I'll try.

 

 

EDIT: It doesn't work, it does the exact same thing.

[Draco18s]

Sync should never be two way, it should only be server -> client

[diesieben07]

Don't sync in the clone event, use the respawn event.

[DiabolicaTrix]

Thanks, it works but how do I save it when the player disconnect?

[diesieben07]

Your IStorage interface will receive a callback to write the data to NBT.

[DiabolicaTrix]

    public static class Storage implements Capability.IStorage<PlayerCapabilities>
    {


        @Override
        public NBTBase writeNBT(Capability<PlayerCapabilities> capability, PlayerCapabilities instance, EnumFacing side)
        {
            NBTTagCompound compound = new NBTTagCompound();
            
            compound.setInteger("Test", instance.getTest());
            
            return compound;
        }


        @Override
        public void readNBT(Capability<PlayerCapabilities> capability, PlayerCapabilities instance, EnumFacing side, NBTBase nbt)
        {
            NBTTagCompound compound = (NBTTagCompound) nbt;
            
            instance.setTest(compound.getInteger("Test"));
        }

    }