Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

custom block that prevents spawning of mobs in a certain perimeter


Thaliviel
 Share

Recommended Posts

If I set a range of 50 Blocks (in a cube-ish range around the block, not a sphere), each spawn will check 100*100*100 Blocks, which is 1 million blocks. And that is a bit too much... Storing the data to a small list and saving/loading the list is much more elegant, I think.

I too had been wondering about that, so I am glad to see your explanation. With such a long range, I can also see a potential difference in behavior with regards to unloaded chunks: A spawn-supressor remembered by the world will have its effect even if its chunk is "over the horizon". However, a ticking TE (or a block-seeking event handler) would only work while its chunk is loaded.

 

If these blocks ever became common enough to make an absolute world-list tedious, then you might opt for a synthesis of strategies (having the world aware of what suppressor blocks are currently loaded, but otherwise leaving them in their chunks).

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

  • Replies 62
  • Created
  • Last Reply

Top Posters In This Topic

Okay, so adding a glow/brightness is quite difficult, right?

There's no method similar to setLightValue(), where you can just set a value.

There is getBlockBrightness(), but that doesn't seem to help...

 

So I have to create a renderer and set the brightness with a tesselator, if I'm not mistaken?

Or is there an easier method?

____

Basically, I just want to make the block look like it recieves light from a torch on every side. Or something like that.

Link to comment
Share on other sites

Ooh, you want it to LOOK like it is fully lit without actually emitting light.

 

That's trickier, but involves rendering the block yourself.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

There is still one thing bothering me: In the documentation

http://mcforge.readthedocs.org/en/latest/datastorage/worldsaveddata/

it says:

 

There are two ways to attach the data: per dimension, or globally.

[...]

In code, these storage locations are represented by two instances of MapStorage present in the World object. The global data is obtained from World#getMapStorage(), while the per-world map is obtained from World#getPerWorldStorage().

 

However, I didn't use getMapStorage or getPerWorldStorage...

So is my BlockList stored per dimension or globally?

Link to comment
Share on other sites

Have you looked at the source of the

World#loadItemData

method? In 1.8.9, it uses

World#mapStorage

(global) rather than

World#perWorldStorage

(per-dimension).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Thank you!!

 

An instance of "world" is a dimension, like overworld, or nether, right? Or is it the whole world containing all dimensions?

 

So right now my BlockList is global, which means spawns will be denied in all dimensions. So when I put a MonsterBlocker-Block in the overworld, spawns will be denied in same area of the nether, too, although there is no MB-Block in the nether. Did I understand this right?

 

If that's the case, I somehow need to use World#perWorldStorage(), and I think that I'll be able to do that on my own - so please just confirm if I'm right, or correct me if I'm wrong.

Link to comment
Share on other sites

Wait, something's not right.

 

	public void LSECheckSpawn(LivingSpawnEvent.CheckSpawn event)
{
	List<Position> mbBlockList = new ArrayList();
	MBSave mbdata = get(event.world);
	mbBlockList = mbdata.getList();

 

I'm retrieving the mbdata from a certain world (dimension).

So it SHOULD be right the way it is now? I'm confused...

Link to comment
Share on other sites

Thank you!!

 

An instance of "world" is a dimension, like overworld, or nether, right? Or is it the whole world containing all dimensions?

 

So right now my BlockList is global, which means spawns will be denied in all dimensions. So when I put a MonsterBlocker-Block in the overworld, spawns will be denied in same area of the nether, too, although there is no MB-Block in the nether. Did I understand this right?

 

If that's the case, I somehow need to use World#perWorldStorage(), and I think that I'll be able to do that on my own - so please just confirm if I'm right, or correct me if I'm wrong.

 

An instance of

World

is one dimension, yes.

 

Wait, something's not right.

 

	public void LSECheckSpawn(LivingSpawnEvent.CheckSpawn event)
{
	List<Position> mbBlockList = new ArrayList();
	MBSave mbdata = get(event.world);
	mbBlockList = mbdata.getList();

 

I'm retrieving the mbdata from a certain world (dimension).

So it SHOULD be right the way it is now? I'm confused...

 

There's no point in creating an

ArrayList

if you're immediately assigning another value to the variable. Declare the

mbBlockList

variable in the same statement as you're calling

mbdata.getList()

in.

 

Your

get

method does receive a

World

argument, but it uses

World#loadItemData

to load the data from that

World

. At least in 1.8.9, this uses the global

MapStorage

(

World#mapStorage

) instead of that dimension's

MapStorage

(

World#perWorldStorage

).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Okay, nevermind. I was dumb to assume that setLightValue(2F) would be brighter than setLightValue(1F).

 

So if light is 0 to 15, and 1.0f corresponds to 15 and it bit-overflows, what happens is we double that?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

My old get method was this:

	public static MBSave get(World world) {
	MBSave handler = (MBSave) world.loadItemData(MBSave.class, DATA_NAME);
	if(handler==null) {
		handler = new MBSave();
		world.setItemData(DATA_NAME, handler);
	}
	return handler;
}

 

And in World.class there is

    public WorldSavedData loadItemData(Class par1Class, String par2Str)
    {
        return this.mapStorage.loadData(par1Class, par2Str);
    }

 

But instead of mapStorage (global) I need perWorldStorage. So my new get method is:

	public static MBSave get(World world) {
	MBSave handler = (MBSave) world.perWorldStorage.loadData(MBSave.class, DATA_NAME);
	if(handler==null) {
		handler = new MBSave();
		world.perWorldStorage.setData(DATA_NAME, handler);
	}
	return handler;
}

 

Is that right? If it is, then I'm a bit proud that I'm understanding Java and Minecraft and Forge a little more than when I started this thread :)

At least it is working when I test it with these changes.

Link to comment
Share on other sites

If the

World#perWorldStorage

field is public in 1.6.4, your new code is correct. The field is protected in 1.8.9, but that may be a recent change.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share




×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.