[1.10.2] [SOLVED]Potion effect when full set is worn. Where do I put it?

[nedas60]

I have a class for each individual armor item. Code looks like:

package Nedas60.TestMod.items;

import net.minecraft.item.ItemArmor;
import Nedas60.TestMod.Reference;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;

public class Infused_Leggings extends ItemArmor {

public Infused_Leggings(ArmorMaterial material) {
	super(material, 2, EntityEquipmentSlot.LEGS);
	setUnlocalizedName(Reference.TestItems.INFUSED_LEGGINGS.getUnlocalizedName());
	setRegistryName(Reference.TestItems.INFUSED_LEGGINGS.getRegistryName());
}
}

Ofcourse each one has it's own names. The problem is that I don't know where to put the test for armor set. Should I create a new class?

[Animefan8888]

Put the test?

[nedas60]

Put the test?

Sorry if it unclear. It said "test for armor set"

 

 

Override onUpdate, check if you (i.e.

this

) are the helmet (or any other piece, but just one piece needs to check obviously). Then check if the player is wearing the full set, if so apply the potion.

Do I put that for each class or just one of my choice?

 

[Animefan8888]

Do I put that for each class or just one of my choice?

Which classes are you talking about? You only posted one so far.

He made multiple classes for each Armor piece and posted one as an example.

[nedas60]

Do I put that for each class or just one of my choice?

Which classes are you talking about? You only posted one so far.

All of the armor ones. The difference between them is just the name and the super value. There is Infused_Helmet, Infused_Leggings, Infused_Boots, Infused_Chestplate.

[Animefan8888]

Yeah that shouldn't matter although you should just use one class.

[nedas60]

Yes, there is no need to make a class for all those. In fact it is pretty stupid to do that.

I am kinda new to forge. Who knows how it works. Please don't judge 

 

I also tried following BedrockMiner's tutorial and I seem to be getting an error. Code:

package Nedas60.TestMod.items;

import Nedas60.TestMod.Reference;
import Nedas60.TestMod.init.ModItems;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.MobEffects;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

public class Infused_Leggings extends ItemArmor {

public Infused_Leggings(ArmorMaterial material) {
	super(material, 2, EntityEquipmentSlot.LEGS);
	setUnlocalizedName(Reference.TestItems.INFUSED_LEGGINGS.getUnlocalizedName());
	setRegistryName(Reference.TestItems.INFUSED_LEGGINGS.getRegistryName());
}
        @Override
public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack) {

	private void effectPlayer(EntityPlayer player1, Potion potionIn, int amplifier) {
	    //Always effect for 8 seconds, then refresh
	    if (player1.getActivePotionEffect(potionIn) == null || player1.getActivePotionEffect(potionIn).getDuration() <= 1)
	        player1.addPotionEffect(new PotionEffect(Potion.getActivePotionEffect(potionIn)), 159, amplifier, true, true));
	}

	if (player1.inventory.armorItemInSlot(3) != null && player1.inventory.armorItemInSlot(3).getItem() == ModItems.InfusedHelmet
	    && player1.inventory.armorItemInSlot(2) != null && player1.inventory.armorItemInSlot(2).getItem() == ModItems.InfusedBoots
	    && player1.inventory.armorItemInSlot(1) != null && player1.inventory.armorItemInSlot(1).getItem() == ModItems.InfusedLeggings
	    && player1.inventory.armorItemInSlot(0) != null && player1.inventory.armorItemInSlot(0).getItem() == ModItems.InfusedChestplate) {
			this.effectPlayer(player, MobEffects.SPEED, 3);
	}
}
}

But there are a lot of errors. Can someone explain how can I get it to work normally? Errors:

Multiple markers at this line

- void is an invalid type for the variable

effectPlayer

- Syntax error on token ",", ; expected

- Syntax error on token "(", ; expected

- Syntax error on token ")", ; expected

- Syntax error on token ",", ; expected

That's not all:

        Multiple markers at this line

- The method addPotionEffect(PotionEffect) in the type EntityLivingBase is not applicable for the arguments (PotionEffect, int, int, boolean,

boolean)

- The method getActivePotionEffect(Potion) is undefined for the type Potion

- Syntax error on token ")", delete this token

Also:

        The method effectPlayer(EntityPlayer, Potion, int) is undefined for the type Infused_Leggings

 

 

[Animefan8888]

You have a method inside of a method...

[nedas60]

Well blame the tutorial

You have a method inside of a method...

[Asweez]

Please learn some basic Java and come back once you have done that. No where in BedrockMiner's tutorial does it put a method inside of a method, that is a good tutorial.

[Animefan8888]

Also onArmorTick might not work unless you set the potion effects time to a small number, as Diesieben said might wanna use onUpdate.

[Asweez]

Also onArmorTick might not work unless you set the potion effects time to a small number, as Diesieben said might wanna use onUpdate.

 

What?  Those are the same thing, one is just specific to armor. Just set the potion effect length to whatever you want after checking that the player doesn't already have that potion effect.

[Animefan8888]

Also onArmorTick might not work unless you set the potion effects time to a small number, as Diesieben said might wanna use onUpdate.

 

What?  Those are the same thing, one is just specific to armor. Just set the potion effect length to whatever you want after checking that the player doesn't already have that potion effect.

You are right, I was just remembering back to 1.5 when I was just getting into this and couldn't get it to get rid of the potion effect when one piece of the armor is taken off....

[nedas60]

Please learn some basic Java and come back once you have done that. No where in BedrockMiner's tutorial does it put a method inside of a method, that is a good tutorial.

I have learned java. What I have NOT learned is minecraft's functions and stuff like that. What can I do? Sure sometimes people don't see mistakes. I didn't notice that he made it differently. That's why I am here.

[Asweez]

If you knew basic Java then you would't put a method inside of another method... That's just ridiculous.

[Draco18s]

This right here is super clever:

		setUnlocalizedName(Reference.TestItems.INFUSED_LEGGINGS.getUnlocalizedName());
	setRegistryName(Reference.TestItems.INFUSED_LEGGINGS.getRegistryName());

 

(Hint: no it's not, does not do what you want it do to,* and in fact is just going to crash the game)

 

Lets see here, you are setting the unlocalized name to....this item's unlocalized name. 

A = A; //A currently equals null

good jorb this code does precisely nothing.

Except oh wait, you didn't use

this

but rather the public static reference of your main class.  Whiiiich because the constructor--where this code is located--hasn't completed yet that reference is fucking null, so good jorb again you got an NPE.

And then you do it all over again for the registry name. Bravo.

 

[Draco18s]

I suppose it could be an enum.  It has the look of being an Item object, though.

[Draco18s]

Oh, sure. It is definitely that.

[nedas60]

That does come from a tutorial and it is an enum.

[Draco18s]

Ok, so tell me what's wrong here:

 

//new function
public void onArmorTick(World world, EntityPlayer player, ItemStack itemStack) { //open paren

	//new function
	private void effectPlayer(EntityPlayer player1, Potion potionIn, int amplifier) { //open paren

[nedas60]

Oh wait sorry forgot to update the title. This is now fixed. Previously in the comment I said didn't notice that the effectPlayer or whatever it is was in a method. Also bedrock's design was a bit broken. I had to fix it up a bit. Now it is fixed