[SOLVED] Compilation error only when "gradle build"

[Blackout]

Hello,

 

I have some issues with generics.

In eclipse (using JRE 7 with compilance setting set to 1.6), I have no error, my game launches well.

But when I try to make a release using "gradle build" command, I get a compilation error about generics.

 

\build\sources\main\java\fr\eyzox\dependencygraph\DependencyGraph.java:31: error: method buildIndex in class DataKeyProvider<K> cannot be applied to given types;
                        node.keyProvider.buildIndex(index, node);
                                        ^
  required: Map<KEY,DependencyGraph<KEY,? extends IData<KEY>>.Node>,DependencyGraph<KEY,? extends IData<KEY>>.Node
  found: Map<KEY,DependencyGraph<KEY,DATA>.Node>,DependencyGraph<KEY,DATA>.Node
  reason: actual argument Map<KEY,DependencyGraph<KEY,DATA>.Node> cannot be converted to Map<KEY,DependencyGraph<KEY,? extends IData<KEY>>.Node> by method invocation conversion
  where KEY,DATA,K are type-variables:
    KEY extends Object declared in class DependencyGraph
    DATA extends IData<KEY> declared in class DependencyGraph
    K extends Object declared in class DataKeyProvider

 

I don't know why it works in Eclipse but doesn't when build.

I've edit gradle.build to use Java 7 to compile with theses line :

sourceCompatibility = 1.7
targetCompatibility = 1.7

 

Source code is available here : https://github.com/RedRelay/FCH_DEBUG

 

Maybe it is pur java's generics missunderstanding, but I doubt it because all works fine in Eclipse.

 

Edit : This is for 1.9 atm so I use the recommended version of forge for MC 1.9 (1.9-12.16.1.1887)

[Animefan8888]

Does this work in the dev environment?

[Blackout]

Yes it works on my dev environment 

[Animefan8888]

It seems the error is in your DependancyGraph on line 31.

[Blackout]

I saw, but there are no error on Eclipse and Eclipse build-in compilation works well.

I know at line 31, I call a method with generics parameters that seems not match for gradle but they match for Eclipse.

[diesieben07]

This is really hard to debug by just staring at code but sadly your repository is broken so I cannot debug this in my IDE.

[Blackout]

Thanks for helping me,

github repo is broken ? How can I fix it ? All works fine at home

[diesieben07]

It is broken in that

[*]it has no

.gitignore

[*]it is missing the gradle wrapper

[*]your build.gradle defines no java source directories and you are not using the default one, hence as far as the gradle project is concerned your source code does not exist

1 and 2 I can deal with but 3 makes it impossible to even run your code. And I am not fixing your build.gradle for you.

[Blackout]

Oh ok my bad ^^

I use default build.gradle

The build.gradle in the repository is useless, I only use it to copy/paste when I update forge because I'm too lazy to edit version, group and archiveBaseName each time ^^ I should have remove it from git for a while ^^

 

All is default Forge 1.9-12.16.1.1887 configuration, and my .git is located in /src

 

I've gradle 2.7 installed on my computer so I don't need wrapper right ?

However, I copy/paste all file in mdk zip except gradlew.bat and gradlew.sh

[diesieben07]

Ok... what?

 

Your git repo should be in the root of your workspace. You shouldn't be copy-pasting anything...

[Blackout]

I've always push only sources to git repo.

All other root files are set to default value.

 

I'll put the root directory on github after releasing if it's a better practice.

 

EDIT : I've done it for my others mods repo, I just wait releasing to rework this repo

[AshIndigo]

If all fails just redownload the MDK and copy your files in.

[Blackout]

Already done, still the same error

[Blackout]

I've create a new repo for debug purpose : https://github.com/RedRelay/FCH_DEBUG

[diesieben07]

Yeah, your code doesn't compile. Intellij shows an error, too.

If eclipse lets you compile it, that's a bug in eclipse (they have their own compiler).

 

I am not really in the mood for fixing this, since your generics are a mess

[Blackout]

I didn't know that Eclipse using its own compiler

I've worked on my java's generics understanding, and I've fixed the issue using

protected abstract <D extends IData<K>> void buildIndex(final Map<K, DependencyGraph<K, D>.Node> index, final DependencyGraph<K, D>.Node theNode) throws DuplicateKeyException;

instead of

protected abstract void buildIndex(final Map<K, DependencyGraph<K, ? extends IData<K>>.Node> index, final DependencyGraph<K, ? extends IData<K>>.Node theNode) throws DuplicateKeyException;

 

Thanks a lot

[Draco18s]

Of course Eclipse has its own compiler. How did you think the run button worked?

[diesieben07]

Of course Eclipse has its own compiler. How did you think the run button worked?

Uhm, what? IntelliJ uses Javac and they have a run button as well? Eclipse only has it's own compiler because they use the compiler for most of the IDE magic (auto-complete, etc.). IntelliJ has it's own stuff for that and uses javac just for compiling.

Unless you are being sarcastic here?