Jump to content

getStackInSlot does not render Item in overlay


Spyeedy

Recommended Posts

Okay so my custom Inventory's getStackInSlot does not render the item in the overlay.

[spoiler=InventoryWeapons]

public class InventoryWeapons implements IInventory
{
private final String name = "Inventory Weapons";
private final String tagName = "InvWeaponsTag";
public static final int INV_SIZE = 2;

public ItemStack[] inventory = new ItemStack[iNV_SIZE];

public InventoryWeapons()
{

}

@Override
public int getSizeInventory()
{
	return inventory.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inventory[slot];
}

@Override
public ItemStack decrStackSize(int slot, int amount)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		if (stack.stackSize > amount)
		{
			stack = stack.splitStack(amount);
			this.markDirty();
		}
		else
		{
			this.setInventorySlotContents(slot, null);
		}
	}
	return stack;
}

@Override
public ItemStack removeStackFromSlot(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	this.setInventorySlotContents(slot, null);
	return stack;
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	this.inventory[slot] = stack;

	if (stack != null && stack.stackSize > this.getInventoryStackLimit())
	{
		stack.stackSize = this.getInventoryStackLimit();
	}

	this.markDirty();
}

@Override
public String getName()
{
	return null;
}

@Override
public boolean hasCustomName()
{
	return name.length() > 0;
}

@Override
public int getInventoryStackLimit()
{
	return 1;
}

@Override
public void markDirty()
{
	for (int i = 0; i < this.getSizeInventory(); ++i)
	{
		if (this.getStackInSlot(i) != null && this.getStackInSlot(i).stackSize == 0)
		{
			this.inventory[i] = null;
		}
	}
}

@Override
public boolean isUseableByPlayer(EntityPlayer player)
{
	return true;
}

@Override
public void openInventory(EntityPlayer player) {}

@Override
public void closeInventory(EntityPlayer player) {}

@Override
public boolean isItemValidForSlot(int slot, ItemStack stack)
{
	return stack.getItem() instanceof ItemWeapons;
}

public void writeToNBT(NBTTagCompound compound)
{
	NBTTagList items = new NBTTagList();

	for (int i = 0; i < getSizeInventory(); ++i)
	{
		if (getStackInSlot(i) != null)
		{
			NBTTagCompound item = new NBTTagCompound();
			item.setByte("Slot", (byte) i);
			getStackInSlot(i).writeToNBT(item);
			items.appendTag(item);
		}
	}

	compound.setTag(tagName, items);
}

public void readFromNBT(NBTTagCompound compound)
{
	NBTTagList items = compound.getTagList(tagName, compound.getId());

	for (int i = 0; i < items.tagCount(); ++i)
	{
		NBTTagCompound item = (NBTTagCompound) items.getCompoundTagAt(i);
		byte slot = item.getByte("Slot");

		if (slot >= 0 && slot < getSizeInventory())
		{
			inventory[slot] = ItemStack.loadItemStackFromNBT(item);
		}
	}
}

@Override
public IChatComponent getDisplayName()
{
	return new ChatComponentText(getName());
}

@Override
public int getField(int id)
{
	return 0;
}

@Override
public void setField(int id, int value) {}

@Override
public int getFieldCount()
{
	return 0;
}

@Override
public void clear()
{
	for (int i = 0; i < inventory.length; ++i)
	{
		inventory[i] = null;
	}
}
}

 

 

 

[spoiler=GUI Overlay]

public class GuiWeaponSlots extends Gui
{
private static final ResourceLocation texture = new ResourceLocation(Reference.MOD_ID + ":textures/gui/weaponSlots.png");

@SubscribeEvent(priority=EventPriority.NORMAL)
public void onRenderGameOverlay(RenderGameOverlayEvent.Post event)
{
	if (event.isCancelable() || event.type != ElementType.HEALTH)
	{
		Minecraft mc = Minecraft.getMinecraft();

		ScaledResolution sr = new ScaledResolution(mc);
            int i = sr.getScaledWidth() / 2;
            InventoryWeapons invWeapons = new InventoryWeapons();
            
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            mc.getTextureManager().bindTexture(texture);
		this.drawTexturedModalRect(i - 121, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		this.drawTexturedModalRect(i + 101, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(0), i - 118, sr.getScaledHeight() - 19);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(1), i + 104, sr.getScaledHeight() - 19);
	}
}
}

 

 

Thanks in advance

width=620 height=260http://www.startrek.com/uploads/assets/articles/61c89a9d73c284bda486afaeaf01cdb27180359b.jpg[/img]

Till next time. Thank you for delivering funny scenes to Star Trek as Chekov :) . Will always remember you

Link to comment
Share on other sites

You will need to call readFromNBT to make sure the itemstacks in the array are not equal to null.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

In the overlay you create a new instance of the inventory but never load the itemstacks to the inventory.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

You will need to call readFromNBT to make sure the itemstacks in the array are not equal to null.

How do I do that? I'm scratching my head here. I don't really get the hang of NBT.  :o

width=620 height=260http://www.startrek.com/uploads/assets/articles/61c89a9d73c284bda486afaeaf01cdb27180359b.jpg[/img]

Till next time. Thank you for delivering funny scenes to Star Trek as Chekov :) . Will always remember you

Link to comment
Share on other sites

Like so

// You already have this.
Inventory inventory = new Inventory();
inventory.readFromNBT(somehowGrabPlayerNBT);
// Do rendering

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Like so

// You already have this.
Inventory inventory = new Inventory();
inventory.readFromNBT(somehowGrabPlayerNBT);
// Do rendering

 

Okay so how do I grab the player's NBT? I've tried calling getEntityData, getNBTTagCompound through EntityPlayerSP with Minecraft.getMinecraft().thePlayer.

width=620 height=260http://www.startrek.com/uploads/assets/articles/61c89a9d73c284bda486afaeaf01cdb27180359b.jpg[/img]

Till next time. Thank you for delivering funny scenes to Star Trek as Chekov :) . Will always remember you

Link to comment
Share on other sites

How are you saving the data?

 

 

 

public class GuiWeaponSlots extends Gui
{
private static final ResourceLocation texture = new ResourceLocation(Reference.MOD_ID + ":textures/gui/weaponSlots.png");

@SubscribeEvent(priority=EventPriority.NORMAL)
public void onRenderGameOverlay(RenderGameOverlayEvent.Post event)
{
	if (event.isCancelable() || event.type != ElementType.HEALTH)
	{
		Minecraft mc = Minecraft.getMinecraft();

		ScaledResolution sr = new ScaledResolution(mc);
            int i = sr.getScaledWidth() / 2;
            InventoryWeapons invWeapons = new InventoryWeapons();
            invWeapons.readFromNBT(mc.thePlayer.getEntityData());
            
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            mc.getTextureManager().bindTexture(texture);
		this.drawTexturedModalRect(i - 121, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		this.drawTexturedModalRect(i + 101, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(0), i - 118, sr.getScaledHeight() - 19);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(1), i + 104, sr.getScaledHeight() - 19);
	}
}
}

 

 

width=620 height=260http://www.startrek.com/uploads/assets/articles/61c89a9d73c284bda486afaeaf01cdb27180359b.jpg[/img]

Till next time. Thank you for delivering funny scenes to Star Trek as Chekov :) . Will always remember you

Link to comment
Share on other sites

How are you saving the data?

 

 

 

public class GuiWeaponSlots extends Gui
{
private static final ResourceLocation texture = new ResourceLocation(Reference.MOD_ID + ":textures/gui/weaponSlots.png");

@SubscribeEvent(priority=EventPriority.NORMAL)
public void onRenderGameOverlay(RenderGameOverlayEvent.Post event)
{
	if (event.isCancelable() || event.type != ElementType.HEALTH)
	{
		Minecraft mc = Minecraft.getMinecraft();

		ScaledResolution sr = new ScaledResolution(mc);
            int i = sr.getScaledWidth() / 2;
            InventoryWeapons invWeapons = new InventoryWeapons();
            invWeapons.readFromNBT(mc.thePlayer.getEntityData());
            
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            mc.getTextureManager().bindTexture(texture);
		this.drawTexturedModalRect(i - 121, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		this.drawTexturedModalRect(i + 101, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(0), i - 118, sr.getScaledHeight() - 19);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(1), i + 104, sr.getScaledHeight() - 19);
	}
}
}

 

 

That would be loading not saving, as LexManos said you should be using the Capability system.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

How are you saving the data?

 

 

 

public class GuiWeaponSlots extends Gui
{
private static final ResourceLocation texture = new ResourceLocation(Reference.MOD_ID + ":textures/gui/weaponSlots.png");

@SubscribeEvent(priority=EventPriority.NORMAL)
public void onRenderGameOverlay(RenderGameOverlayEvent.Post event)
{
	if (event.isCancelable() || event.type != ElementType.HEALTH)
	{
		Minecraft mc = Minecraft.getMinecraft();

		ScaledResolution sr = new ScaledResolution(mc);
            int i = sr.getScaledWidth() / 2;
            InventoryWeapons invWeapons = new InventoryWeapons();
            invWeapons.readFromNBT(mc.thePlayer.getEntityData());
            
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            mc.getTextureManager().bindTexture(texture);
		this.drawTexturedModalRect(i - 121, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		this.drawTexturedModalRect(i + 101, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(0), i - 118, sr.getScaledHeight() - 19);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(1), i + 104, sr.getScaledHeight() - 19);
	}
}
}

 

 

That would be loading not saving, as LexManos said you should be using the Capability system.

Pardon me for my lack of knowledge of this Capability system. But what is it exactly?

width=620 height=260http://www.startrek.com/uploads/assets/articles/61c89a9d73c284bda486afaeaf01cdb27180359b.jpg[/img]

Till next time. Thank you for delivering funny scenes to Star Trek as Chekov :) . Will always remember you

Link to comment
Share on other sites

How are you saving the data?

 

 

 

public class GuiWeaponSlots extends Gui
{
private static final ResourceLocation texture = new ResourceLocation(Reference.MOD_ID + ":textures/gui/weaponSlots.png");

@SubscribeEvent(priority=EventPriority.NORMAL)
public void onRenderGameOverlay(RenderGameOverlayEvent.Post event)
{
	if (event.isCancelable() || event.type != ElementType.HEALTH)
	{
		Minecraft mc = Minecraft.getMinecraft();

		ScaledResolution sr = new ScaledResolution(mc);
            int i = sr.getScaledWidth() / 2;
            InventoryWeapons invWeapons = new InventoryWeapons();
            invWeapons.readFromNBT(mc.thePlayer.getEntityData());
            
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            mc.getTextureManager().bindTexture(texture);
		this.drawTexturedModalRect(i - 121, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		this.drawTexturedModalRect(i + 101, sr.getScaledHeight() - 22, 0, 0, 22, 22);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(0), i - 118, sr.getScaledHeight() - 19);
		mc.getRenderItem().renderItemAndEffectIntoGUI(invWeapons.getStackInSlot(1), i + 104, sr.getScaledHeight() - 19);
	}
}
}

 

 

That would be loading not saving, as LexManos said you should be using the Capability system.

Pardon me for my lack of knowledge of this Capability system. But what is it exactly?

The capability system is the replacment for IEntityExtendedProperties for 1.8+ though if you want infotmation on how to use it you should look at the docs.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • That looks pretty cool, nice!   Sure, so looking at that JSON file I posted, I pretty much made a record class for each "custom" data type in that JSON. The Input is a good example of why ``` "inputs": [ { "ingredient": { "item": "relativedimensions:aberrant_shard" }, "count": 8 } ], ``` So here's the inputs, it's an array, which we can use the Codec builder's builder.listOf to define an array. Each Item is of some arbitrary object with keys "ingredient" (which we know is an Ingredient) and a "count" which is an int. You don't have to have an intermediate class to map this to necessarily but I found that it's just easier to see the data that way, hence the 'ParticleReboundIngredient' represents one of these inputs.   Let me know if that makes sense or not. 
    • Pretty much, although all the recipes im planning to make on it are shapeless. The idea is that the chamber uses energy to "fuse" the items in each of the center slots together, in this case an ingot. The two slots at the sides are fuel. (A special kind of wood in this case). Here is an image of the interface just for reference (The center slot is the output)   As for the code- Can you elaborate a little bit on it? Seeing three different record classes has confused me a lot. (Elaborate as in why make them in three different records. I understand the code itself more or less)
    • Hello im trying to make a mod and the past few days GSON has almost killed me, when i export the mod and then launch it through minecraft launcher i get java.lang.NoSuchMethodError: com.google.gson.JsonParser.parseString(Ljava/lang/String;)Lcom/google/gson/JsonElement; i have literally tried everything here is my build config   dependencies { minecraft("com.mojang:minecraft:1.8.9") mappings("de.oceanlabs.mcp:mcp_stable:22-1.8.9") forge("net.minecraftforge:forge:1.8.9-11.15.1.2318-1.8.9") compileOnly("cc.polyfrost:oneconfig-1.8.9-forge:0.2.2-alpha+") shadowImpl("cc.polyfrost:oneconfig-wrapper-launchwrapper:1.0.0-beta+") { isTransitive = false exclude(module = "gson") } shadowImpl("org.spongepowered:mixin:0.7.11-SNAPSHOT") { isTransitive = false exclude(module = "gson") } annotationProcessor("org.spongepowered:mixin:0.8.5-SNAPSHOT") shadowImpl("org.javassist:javassist:3.15.0-GA") { isTransitive = false exclude(module = "gson") } shadowImpl("com.neovisionaries:nv-i18n:1.28") { isTransitive = false exclude(module = "gson") } shadowImpl("org.apache.commons:commons-lang3:3.4") { isTransitive = false exclude(module = "gson") } shadowImpl("org.apache.httpcomponents:httpcore:4.4.5") { isTransitive = false exclude(module = "gson") } compileOnly("com.google.code.gson:gson:2.8.6") { isTransitive = false } configurations.all { resolutionStrategy { force("com.google.code.gson:gson:2.8.6") } } shadowImpl(fileTree( mapOf( "dir" to "libs", "include" to listOf("*.jar"), "exclude" to listOf( "asm", "asm-commons", "asm-tree", "gson", "unspecified", "nv-i18n" ) ) )) }  
    • @chxr Looks like you're making some sort of a crafting table / furnace hybrid? Are the inputs needing arranging like a shaped recipe, or is it shapeless? I'll assume it's shapeless since that just adds a lot more complexity. In that case I'd probably do something like this { "type": "relativedimensions:particle_rebound", "inputs": [ { "ingredient": { "item": "relativedimensions:aberrant_shard" }, "count": 8 } ], "fuel": { "tag": "relativedimensions:block/aberrant_fuel" }, "output": { "Count": 1, "id": "relativedimensions:aberrant_ingot" } } inputs: A list of ingredients and how many are needed. The count among each input adds up to 8. Since there's only 1 ingredient, the count is set to 8. fuel: Same thing as before but remove the list and just make it an object with a tag. output: Kept the same.   In this case the Codec I would make is public record ParticleReboundIngredient(Ingredient ingredient, int count) { public static final Codec<ParticleReboundIngredient> CODEC = RecordCodecBuilder.create( builder -> builder.group( Ingredient.CODEC.fieldOf("ingredient").forGetter((i) -> i.ingredient), Codec.INT.fieldOf("count").forGetter(i -> i.count) ).apply(builder, ParticleReboundIngredient::new) ); } public record ParticleReboundFuel(String tag) { public static final Codec<ParticleReboundFuel> CODEC = RecordCodecBuilder.create( builder -> builder.group(Codec.STRING.fieldOf("tag").forGetter(f -> f.tag)).apply(builder, ParticleReboundFuel::new) ); public boolean isFuel(ItemStack stack) { // TODO: Check if fuel item matches the tag } } public record ParticleReboundRecipe(List<ParticleReboundIngredient> inputs, ParticleReboundFuel fuel, ItemStack output) { public static final Codec<ParticleReboundRecipe> CODEC = RecordCodecBuilder.create( builder -> builder.group( ParticleReboundIngredient.CODEC.listOf().fieldOf("inputs").forGetter(r -> r.inputs), ParticleReboundFuel.CODEC.fieldOf("fuel").forGetter(r -> r.fuel), ItemStack.CODEC.fieldOf("output").forGetter(r -> r.output) ).apply(builder, ParticleReboundRecipe::new) ); }   There might be a more proper Codec for the fuel and the tag that's built into minecraft / forge, but I didn't look
    • Tested with 5900X, 64GB 3200 MHz, 3070 Ti, driver 551.86 GPU clock range: 200 - 1950 MHz, usually 210 MHz with 10-30% utilisation on desktop idle use Render settings: Vsync ON, Framerate unlimited, Render distance 32, Fullscreen ON (60hz monitor, so 60 fps with vsync) Vanilla minecraft: Main menu: 210mhz idle clock always, ingame clock around 400 - 1000 mhz with ~30% utilisation and after alt+tab stays at same. Modded install with curseforge app, only said forge added: Main menu: 210 mhz idle clock always, ingame clock around 400 - 1000 mhz with ~30% utilisation, but after alt+tab gpu clock shoots up to 1950 mhz and utilisation is at 50-60% After disabling all render and chunk related stuff in config, after alt+tab it goes up to 1500 mhz. So game turns gpu into space heater when its not even seen. GPU usage returns to expected when game comes back on top. If instead of unlimited fps, fps is set to ~60, then during alt+tab gpu stays at same range as vanilla, but minecraft has horrible limit logic and framerate limit causes lot of tearing, so its not an option. So it seems that when alt+tabbing, for some reason logic no longer takes vsync toggle into account. So expected behaviour would be for it to work like vanilla does. keep rendering in same manner, no matter if its seen and use same amount of resources. Essentially noticed this behaviour while playing Supersymmetry and after elimination testing, result was that only Forge was enough to cause it. And also confirmed it by doing fresh pack with only Forge added, so no other mods even in disabled state. Also happened with both singleplayer and remote multiplayer. Other offender was "Universal Tweaks" which introduced same effect to main menu with its # Removes the hardcoded 30 FPS limit in screens like the main menu B:"Uncap FPS"=true setting, meaning when game was on top, it still worked in limits of vsync cap, but after alt+tabbing even in main menu gpu usage shot up to max.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.