Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I tried creating custom shears using the ItemShears class and checking the items class to see if there was anything special with the Itemshears registration, and tried extending ItemShears but it just acts like a normal item, I just need some help with making it work properly

 

Item registration class

 

package top.mod.init;

import net.minecraft.client.Minecraft;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.init.SoundEvents;

import net.minecraft.inventory.EntityEquipmentSlot;

import net.minecraft.item.Item;

import net.minecraft.item.Item.ToolMaterial;

import net.minecraft.item.ItemArmor.ArmorMaterial;

import net.minecraft.item.ItemSword;

import net.minecraft.util.ResourceLocation;

import net.minecraftforge.common.util.EnumHelper;

import net.minecraftforge.fml.common.registry.GameRegistry;

import top.mod.armor.toparmor;

import top.mod.main.reference;

import top.mod.tab.toptab;

public class _items {

 

//items

public static Item copper;

 

//tools

public static Item coppersword;

public static Item copperpick;

public static Item coppershovel;

public static Item copperaxe;

public static Item copperhoe;

public static Item coppershears;

 

//armor

public static ArmorMaterial copperarmor = EnumHelper.addArmorMaterial("copperarmor", "tm:copper", 15, new int[]{2, 5, 6, 2}, 9, SoundEvents.ITEM_ARMOR_EQUIP_DIAMOND, 0.0F);

public static ToolMaterial COPPER = EnumHelper.addToolMaterial("COPPER", 1, 181, 6.0F, 2.0F, 14);

public static Item copperhelm;

public static Item copperchest;

public static Item copperlegs;

public static Item copperboots;

 

 

public static final void preinit(){

coppersword = registerItem(new coppersword(COPPER), "coppersword");

copperpick = registerItem(new copperpick(COPPER), "copperpick");

coppershovel = registerItem(new coppershovel(COPPER), "coppershovel");

copperaxe = registerItem(new copperaxe(COPPER), "copperaxe");

copperhoe = registerItem(new copperhoe(COPPER), "copperhoe");

 

 

copperhelm = registerItem(new toparmor(copperarmor, 1, EntityEquipmentSlot.HEAD), "copperhelm");

copperchest = registerItem(new toparmor(copperarmor, 1, EntityEquipmentSlot.CHEST), "copperchest");

copperlegs = registerItem(new toparmor(copperarmor, 2, EntityEquipmentSlot.LEGS), "copperlegs");

copperboots = registerItem(new toparmor(copperarmor, 1, EntityEquipmentSlot.FEET), "copperboots");

 

 

copper = registerItem(new copper(), "copper");

coppershears = registerItem(new copper(), "coppershears");

 

 

}

public static final void registerRenders() {

registerRender(copper);

registerRender(coppersword);

registerRender(copperpick);

registerRender(coppershovel);

registerRender(copperaxe);

registerRender(copperhoe);

registerRender(copperhelm);

registerRender(copperchest);

registerRender(copperlegs);

registerRender(copperboots);

registerRender(coppershears);

 

}

 

public static final void registerRender(Item i){

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(i,0,

new ModelResourceLocation(reference.MODID + ":" + i.getRegistryName().getResourcePath(), "inventory"));

 

}

 

public static final Item registerItem(Item i, String n){

ResourceLocation r = new ResourceLocation(reference.MODID, n);

 

i.setUnlocalizedName(n);

i.setRegistryName®;

i.setCreativeTab(toptab.toptab);

 

GameRegistry.register(i);

return i;

 

}

}

 

 

 

coppershears class

 

package top.mod.init;

import net.minecraft.block.Block;

import net.minecraft.block.material.Material;

import net.minecraft.block.state.IBlockState;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.init.Blocks;

import net.minecraft.item.Item;

import net.minecraft.item.ItemShears;

import net.minecraft.item.ItemStack;

import net.minecraft.util.math.BlockPos;

import net.minecraft.world.World;

public class coppershears extends ItemShears {

 

public coppershears () {

super();

 

this.setMaxStackSize(1);

this.setMaxDamage(181);

 

}

/**

* Called when a Block is destroyed using this Item. Return true to trigger the "Use Item" statistic.

*/

public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)

{

stack.damageItem(1, entityLiving);

Block block = state.getBlock();

return state.getMaterial() != Material.LEAVES && block != Blocks.WEB && block != Blocks.TALLGRASS && block != Blocks.VINE && block != Blocks.TRIPWIRE && block != Blocks.WOOL && !(state instanceof net.minecraftforge.common.IShearable) ? super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving) : true;

}

/**

* Check whether this Item can harvest the given Block

*/

public boolean canHarvestBlock(IBlockState blockIn)

{

Block block = blockIn.getBlock();

return block == Blocks.WEB || block == Blocks.REDSTONE_WIRE || block == Blocks.TRIPWIRE;

}

public float getStrVsBlock(ItemStack stack, IBlockState state)

{

Block block = state.getBlock();

return block != Blocks.WEB && state.getMaterial() != Material.LEAVES ? (block == Blocks.WOOL ? 5.0F : super.getStrVsBlock(stack, state)) : 15.0F;

}

/**

* Returns true if the item can be used on the given entity, e.g. shears on sheep.

*/

@Override

public boolean itemInteractionForEntity(ItemStack itemstack, net.minecraft.entity.player.EntityPlayer player, EntityLivingBase entity, net.minecraft.util.EnumHand hand)

{

if (entity.worldObj.isRemote)

{

return false;

}

if (entity instanceof net.minecraftforge.common.IShearable)

{

net.minecraftforge.common.IShearable target = (net.minecraftforge.common.IShearable)entity;

BlockPos pos = new BlockPos(entity.posX, entity.posY, entity.posZ);

if (target.isShearable(itemstack, entity.worldObj, pos))

{

java.util.List<ItemStack> drops = target.onSheared(itemstack, entity.worldObj, pos,

net.minecraft.enchantment.EnchantmentHelper.getEnchantmentLevel(net.minecraft.init.Enchantments.FORTUNE, itemstack));

java.util.Random rand = new java.util.Random();

for(ItemStack stack : drops)

{

net.minecraft.entity.item.EntityItem ent = entity.entityDropItem(stack, 1.0F);

ent.motionY += rand.nextFloat() * 0.05F;

ent.motionX += (rand.nextFloat() - rand.nextFloat()) * 0.1F;

ent.motionZ += (rand.nextFloat() - rand.nextFloat()) * 0.1F;

}

itemstack.damageItem(1, entity);

}

return true;

}

return false;

}

@Override

public boolean onBlockStartBreak(ItemStack itemstack, BlockPos pos, net.minecraft.entity.player.EntityPlayer player)

{

if (player.worldObj.isRemote || player.capabilities.isCreativeMode)

{

return false;

}

Block block = player.worldObj.getBlockState(pos).getBlock();

if (block instanceof net.minecraftforge.common.IShearable)

{

net.minecraftforge.common.IShearable target = (net.minecraftforge.common.IShearable)block;

if (target.isShearable(itemstack, player.worldObj, pos))

{

java.util.List<ItemStack> drops = target.onSheared(itemstack, player.worldObj, pos,

net.minecraft.enchantment.EnchantmentHelper.getEnchantmentLevel(net.minecraft.init.Enchantments.FORTUNE, itemstack));

java.util.Random rand = new java.util.Random();

for(ItemStack stack : drops)

{

float f = 0.7F;

double d = (double)(rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;

double d1 = (double)(rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;

double d2 = (double)(rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;

net.minecraft.entity.item.EntityItem entityitem = new net.minecraft.entity.item.EntityItem(player.worldObj, (double)pos.getX() + d, (double)pos.getY() + d1, (double)pos.getZ() + d2, stack);

entityitem.setDefaultPickupDelay();

player.worldObj.spawnEntityInWorld(entityitem);

}

itemstack.damageItem(1, player);

player.addStat(net.minecraft.stats.StatList.getBlockStats(block));

}

}

return false;

}

}

 

How should it look, because there literally is no tutorials anywhere about sheers

coppperShears = registerItem(new copperShears(...));

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

copperhelm = registerItem(new toparmor(copperarmor, 1, EntityEquipmentSlot.HEAD), "copperhelm");

 

See that "new" keyword?

See the thing that coems right after it?  That's a class.  Which you've poorly named by not making the first letter capitalized (should be "TopArmor").

 

You never do this with your

coppershears

class (*cough* CopperShears *cough*).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

copperhelm = registerItem(new toparmor(copperarmor, 1, EntityEquipmentSlot.HEAD), "copperhelm");

 

See that "new" keyword?

See the thing that coems right after it?  That's a class.  Which you've poorly named by not making the first letter capitalized (should be "TopArmor").

 

 

someone told me capitalized classes where being removed in 1.11, it is't throwing any errors but I will change it anyway

 

You never do this with your

coppershears

class (*cough* CopperShears *cough*).

capitalized class names is a java convention to make things look easier to understand, the problem is with the capitalized paths (or package names) or capitalized MODID because the package names depend on it

Even after you get your shears to exist, they still might not behave exactly the same as vanilla shears. That's because some Minecraft objects depend on other objects knowing about them and coding special behavior for them by name (and not as instance of).

 

These are technical violations of the "compartmentalization" aspect of O-O design methodology, but it's much easier to code that way when one is pressed by a deadline and not thinking about how difficult life will be for modders later.

 

Therefore, test all behaviors that you care about. Try to enchant your custom shears, while in survival mode, with each enchantment you expect them to accept (using table and/or anvil+book as appropriate).

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Enchantments should works fine, it's the "shear sheep" bit I expect to break. If not that, then harvesting leaves.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.