[1.10] Actions when player step on entity

[KmKadze]

Hi everyone! (sorry for my english)

 

I want to create my own Armor Stand(call it "auto armor stand") which is activated when player "step on" it. I used onCollideWithPlayer method, in which I wrote verifying of that the player is in the same block as the "auto armor stand". If it's true, another method swaps armor:

public void onCollideWithPlayer(EntityPlayer player)
    { 
    	if(isActive)
    	{	    	 		
    		int playerX = player.getPosition().getX();
        	int playerY = player.getPosition().getY();
        	int playerZ = player.getPosition().getZ();
        	int thisX = this.getPosition().getX();
        	int thisY = this.getPosition().getY();
        	int thisZ = this.getPosition().getZ();
        	
        	if(playerX == thisX && playerY == thisY && playerZ == thisZ && !player.isSpectator() && !player.isInvisible())
        	{ 	
        		swapItemsWithPlayer(player, EntityEquipmentSlot.MAINHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.OFFHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.HEAD);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.CHEST);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.LEGS);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.FEET);  
        		isActive = false;
        	}
    	}

I used "isActive" variable to make swap worked once, then went to cooldown. The problem is that the method all the same have a time to work twice and in the and armor doesn't swap. What should I do to fix this?

 

p.s. Armor stand and "auto armor stand" is an entity

[Draco18s]

You can't store information in the Block class, you must store it elsewhere (TileEntity, Player Capability, etc.)

[Choonster]

You can't store information in the Block class, you must store it elsewhere (TileEntity, Player Capability, etc.)

 

Despite being placed by an

Item

in a block-like manner, the vanilla armor stand is an

Entity

rather than a

Block

. I suspect the OP's is the same.

[Draco18s]

I can't tell from the code snippet.

There may be also something else they did that I can't see.

[KmKadze]

Ok so maybe it'll be helpful. This is in mod main class:

@Mod(modid=modInfo.MODID, name=modInfo.MODNAME, version=modInfo.VERSION)
public class LittleFeatures 
{	
@Instance(modInfo.MODID)
public static LittleFeatures instance;	

@EventHandler
public void init(FMLInitializationEvent event)
{		
	EntitiesList.entities();	
}

        public static void registerEntity(Class entityClass, String name, int id)
{		
	EntityRegistry.registerModEntity(entityClass, name, id, instance, 64, 1, true);
}

}

EntitiesList.java:

public class EntitiesList {

public static void entities()
{                
	LittleFeatures.registerEntity(EntityAutoArmorStand.class, "autoArmorStand", 364545);
}
}

EntityAutoArmorStand.java (i copied all of the EntityArmorStand(minecraft's armor stand), changed variables' names and added this code):

public class EntityAutoArmorStand extends EntityLivingBase
{
    private int timer = 0; //for timer
    private boolean isActive = true; 

    public void onLivingUpdate() //cooldown timer, based on ticks
    {   	     
        if(isActive == false && timer < 60)
    	{
    		timer++;
    	}
    	else if(timer >= 60 && isActive == false)
    	{
    		isActive = true;
    		timer = 0;
    	}
    }
    
    public void onCollideWithPlayer(EntityPlayer player)
    { 
    	if(isActive == true)
    	{	    	 		
    		int playerX = player.getPosition().getX();
        	int playerY = player.getPosition().getY();
        	int playerZ = player.getPosition().getZ();
        	int thisX = this.getPosition().getX();
        	int thisY = this.getPosition().getY();
        	int thisZ = this.getPosition().getZ();
        	
        	if(playerX == thisX && playerY == thisY && playerZ == thisZ && !player.isSpectator() && !player.isInvisible())
        	{ 	
        		swapItemsWithPlayer(player, EntityEquipmentSlot.MAINHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.OFFHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.HEAD);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.CHEST);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.LEGS);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.FEET);  
        		isActive = false;
        	}
    	}
    }    
    
    private void swapItemsWithPlayer(EntityPlayer player, EntityEquipmentSlot slot)
    {
   		if(player.getItemStackFromSlot(slot) != null && this.getItemStackFromSlot(slot) == null)
       	{
       		this.setItemStackToSlot(slot, player.getItemStackFromSlot(slot));
       		player.setItemStackToSlot(slot, null);    	
       	}
       	else if(player.getItemStackFromSlot(slot) == null && this.getItemStackFromSlot(slot) != null)
       	{
       		player.setItemStackToSlot(slot, this.getItemStackFromSlot(slot));
       		this.setItemStackToSlot(slot, null); 
       		this.playEquipSound(player.getItemStackFromSlot(slot));
       	}
       	else if(player.getItemStackFromSlot(slot) != null && this.getItemStackFromSlot(slot) != null)
       	{
       		ItemStack playerStack = player.getItemStackFromSlot(slot);
       		ItemStack thisStack = this.getItemStackFromSlot(slot);
       		
       		this.setItemStackToSlot(slot, playerStack);
       		player.setItemStackToSlot(slot, thisStack);        	
       	}     	
    }

[Animefan8888]

I dont think onCollideWithPlayer is ever called because it is not overriding anything, and you never call it.

[TheMasterGabriel]

I dont think onCollideWithPlayer is ever called because it is not overriding anything, and you never call it.

 

onCollideWithPlayer is called by EntityPlayer whenever the player intersects an entity (it's in EntityPlayer, line 619)

 

    public void onCollideWithPlayer(EntityPlayer player)
    { 
    	if(isActive == true)
    	{	    	 		
    		int playerX = player.getPosition().getX();
        	int playerY = player.getPosition().getY();
        	int playerZ = player.getPosition().getZ();
        	int thisX = this.getPosition().getX();
        	int thisY = this.getPosition().getY();
        	int thisZ = this.getPosition().getZ();
        	
        	if(playerX == thisX && playerY == thisY && playerZ == thisZ && !player.isSpectator() && !player.isInvisible())
        	{ 	
        		swapItemsWithPlayer(player, EntityEquipmentSlot.MAINHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.OFFHAND);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.HEAD);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.CHEST);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.LEGS);
        		swapItemsWithPlayer(player, EntityEquipmentSlot.FEET);  
        		isActive = false;
        	}
    	}
    }    

 

You don't need to manually check if the entity positions are equal and if the player is a spectator, EntityPlayer already does this (in essence). Try removing the position checks and the spectator check.

 

Also, you never reset the timer (timer=0) when the player collides with your entity for the first time, so your code will only run once.

[KmKadze]

You don't need to manually check if the entity positions are equal and if the player is a spectator, EntityPlayer already does this (in essence). Try removing the position checks and the spectator check.

Also, you never reset the timer (timer=0) when the player collides with your entity for the first time, so your code will only run once.

Ok, I removed the position and spectator cheking, now it works perfectly but in the one block radius from the "auto armor stand".

Also, you never reset the timer (timer=0) when the player collides with your entity for the first time, so your code will only run once.

Timer resets in onLivingUpdate method.