Jump to content

Recommended Posts

Posted

Basically my when my items entity hits a block, it does not cause an explosion even though I included the line this.worldObj.createExplosion((Entity) null, i, k, 10F, i, true);

 

Can someone help me please

 

ItemEntityClass

 

 

package top.mod.item;

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.projectile.EntityThrowable;

import net.minecraft.init.Items;

import net.minecraft.item.Item;

import net.minecraft.util.DamageSource;

import net.minecraft.util.EnumParticleTypes;

import net.minecraft.util.datafix.DataFixer;

import net.minecraft.util.math.RayTraceResult;

import net.minecraft.world.World;

public class EntityKnife extends EntityThrowable{

public EntityKnife(World worldIn) {

super(worldIn);

 

}

public EntityKnife(World worldIn, EntityLivingBase throwerIn) {

super(worldIn, throwerIn);

 

}

public EntityKnife(World worldIn, double x, double y, double z) {

super(worldIn, x, y, z);

 

}

public static void func_189662_a(DataFixer p_189662_0_)

{

EntityThrowable.func_189661_a(p_189662_0_, "knife");

}

 

@Override

protected void onImpact(RayTraceResult result)

{

if(result.entityHit != null)

{

result.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), 41.0F);

}

if(!this.worldObj.isRemote && this.rand.nextInt(8) == 0)

{

int i = 1;

 

if(this.rand.nextInt(32) == 0)

{

i = 4;

}

 

double d0 = 0.08D;

 

for (int k = 0; k < 8; ++k)

{

this.worldObj.spawnParticle(EnumParticleTypes.ITEM_CRACK, this.posX, this.posY, this.posZ, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, new int[] {Item.getIdFromItem(Items.EGG)});

this.worldObj.createExplosion((Entity) null, i, k, 10F, i, true);

}

}

 

if (!this.worldObj.isRemote)

{

this.setDead();

}

}

}

 

 

Posted

http://pastebin.com/ysVjvHau

 

there is my item class with syntax highlighting

The answer you are looking for is you are not passing the right parameters, look in world at createExplosion it tells you the what each variable is.

 

Also by formatted he means it kinda "cascades".

     public void example(int i) {
          if (i == 1) {
              i = 0;
          }
     }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

 

@Override

public void onUpdate() {

super.onUpdate();

int i = MathHelper.floor_double(this.getEntityBoundingBox().minX + 0.001D);

int j = MathHelper.floor_double(this.getEntityBoundingBox().minY + 0.001D);

int k = MathHelper.floor_double(this.getEntityBoundingBox().minZ + 0.001D);

World world = this.worldObj;

Entity entity = (Entity) this;

 

 

if (true) {

world.createExplosion((Entity) null, i, j, k, 10F, true);

}

 

this.kill();

}

 

 

 

 

 

Ok so using this causes it to explode now, however it does not travel and explodes in my hand

Posted
if (true) 

.....I wonder....

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I fixed it with this code, I know it's horrible and unorganized, bit im still learning this stufff.

 

package top.mod.item;

import net.minecraft.entity.Entity;

import net.minecraft.entity.EntityLivingBase;

import net.minecraft.entity.projectile.EntityThrowable;

import net.minecraft.init.Items;

import net.minecraft.item.Item;

import net.minecraft.util.DamageSource;

import net.minecraft.util.EnumParticleTypes;

import net.minecraft.util.datafix.DataFixer;

import net.minecraft.util.math.MathHelper;

import net.minecraft.util.math.RayTraceResult;

import net.minecraft.world.World;

public class EntityKnife extends EntityThrowable{

public EntityKnife(World worldIn) {

super(worldIn);

 

}

public EntityKnife(World worldIn, EntityLivingBase throwerIn) {

super(worldIn, throwerIn);

 

}

public EntityKnife(World worldIn, double x, double y, double z) {

super(worldIn, x, y, z);

 

}

public static void func_189662_a(DataFixer p_189662_0_)

{

EntityThrowable.func_189661_a(p_189662_0_, "knife");

}

 

 

@Override

protected void onImpact(RayTraceResult result)

{

if(result.entityHit != null)

{

result.entityHit.attackEntityFrom(DamageSource.causeThrownDamage(this, this.getThrower()), 41.0F);

}

if(!this.worldObj.isRemote && this.rand.nextInt(4) == 0)

{

int i = 1;

 

if(this.rand.nextInt(32) == 0)

{

i = 4;

}

 

double d0 = 0.08D;

 

for (int k = 0; k < 8; ++k)

{

this.worldObj.spawnParticle(EnumParticleTypes.ITEM_CRACK, this.posX, this.posY, this.posZ, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, ((double) this.rand.nextFloat() - 0.5D) * 0.08D, new int[] {Item.getIdFromItem(Items.EGG)});

{

{

super.onUpdate();

int i1 = MathHelper.floor_double(this.getEntityBoundingBox().minX + 0.001D);

int j = MathHelper.floor_double(this.getEntityBoundingBox().minY + 0.001D);

int k1 = MathHelper.floor_double(this.getEntityBoundingBox().minZ + 0.001D);

World world = this.worldObj;

Entity entity = (Entity) this;

 

 

if (true) {

world.createExplosion((Entity) null, i1, j, k1, 4F, true);

}

 

this.kill();

}

 

 

 

 

 

 

if (!this.worldObj.isRemote)

{

this.setDead();

}

}

}

}

}

}

 

 

 

 

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi here is an update. I was able to fix the code so my mod does not crash Minecraft. Please understand that I am new to modding but I honestly am having a hard time understanding how anyone can get this to work without having extensive programming and debugging experience as well as searching across the Internet, multiple gen AI bots (claude, grok, openai), and examining source code hidden in the gradle directory and in various github repositories. I guess I am wrong because clearly there are thousands of mods so maybe I am just a newbie. Ok, rant over, here is a step by step summary so others can save the 3 days it took me to figure this out.   1. First, I am using forge 54.1.0 and Minecraft 1.21.4 2. I am creating a mod to add a shotgun to Minecraft 3. After creating the mod and compiling it, I installed the .jar file to the proper directory in Minecraft and used 1.21.4-forge-54.1.0 4. The mod immediately crashed with the error: Caused by: java.lang.NullPointerException: Item id not set 5. Using the stack trace, I determined that the Exception was being thrown from the net.minecraft.world.item.Item.Properties class 6. It seems that there are no javadocs for this class, so I used IntelliJ which was able to provide a decompiled version of the class, which I then examined to see the source of the error. Side question: Are there javadocs? 7. This method, specifically, was the culprit: protected String effectiveDescriptionId() {      return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));  } 8. Now my quest was to determine how to set this.id. Looking at the same source file, I determined there was another method:  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } 9. So now, I need to figure out how to call setId(). This required working backwards a bit. Starting from the constructor, I stubbed out the variable p which is of type Item.Properties public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); Rather than putting this all on one line, I split it up for readability like this: private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); Here is was the missing function, setId(), which takes a type of ResourceKey<Item>. My next problem is that due to the apparent lack of documentation (I tried searching the docs on this site) I could not determine the full import path to ResourceKey. I did some random searching on the Internet and stumbled across a Github repository which gave two clues: import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; Then I created the rk variable like this: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); And now putting it all together in order: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); This compiled and the mod no longer crashes. I still have more to do on it, but hopefully this will save someone hours. I welcome any feedback and if I missed some obvious modding resource or tutorial that has this information. If not, I might suggest we add it somewhere for people trying to write a mod that doesn't crash. Thank you !!!  
    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
    • It was working perfectly fine last night but now I'm getting an exit code -1 with the textbox: The game crashed: rendering overlay Error: net.minecraftforge.fml.ModLoadingException: Supplementaries (supplementaries) encountered an error during the done event phase Here's the crash log: https://pastebin.com/KmesArYS Any help is apricated
    • Link to Crashlog: https://pastebin.com/bKqH9fx2 Trying to set up a custom mod pack, was going smoothly up until recently as the WorldLoader screen, (the one that appears when you select "create new world" in Singleplayer), was clicked to test that it was running fine. Most Recent Few mods added were; - Create (+ its addons) - Immersive Weathering [Forge] I've tried all I could think of since loading up the game worked fine and I've never had this issue before.  Any help is appreciated.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.