Jump to content

[1.10.2] Storing items in an enum VS Performence


SHsuperCM
 Share

Recommended Posts

Will adding items inside an enum and doing all things needed from there affect performence

while loading the game/being in the game?

I'm somewhat new to java and I dont know..

 

I'm asking this because I belive I made the simplest way of adding items and im not sure if its safe...

 

All you need is 1 line for an item and it's resources...

 

 

 

EDIT: IGNORE THIS VV  new below

public class ModItems{
    public static enum ModItemsEnum{
        TESTITEM("TestItem","this_is_test",0),
        ANOTHERTEST("UnLocalizedNameHere","registry_name_here",1),
        CanReallyBeAnything("IsThisGud","this_is_registry_name",0);




        private Item item;
        ModItemsEnum(Item INitem, String INunlocalizedName, String INregistryName, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(INunlocalizedName);
            this.item.setRegistryName(INregistryName);
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(String INunlocalizedName, String INregistryName, int INspecial){ //Normal Classless Items
            this(new Item(),INunlocalizedName,INregistryName,INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;    
        }
        return true;
    }
}

Doing stuff n' things

Link to comment
Share on other sites

EDIT:

 

Found a way to shrink it even more! Woop Woop!

 

public class ModItems{
    public static enum ModItemsEnum{
        TESTITEM("this_is_test",0),
        ThisIsUnlocalizedName("registry_name_here",0),
        CanReallyBeAnything("this_is_registry_name",0);




        private Item item;
        ModItemsEnum(Item INitem, String INregistryName, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(this.name());
            this.item.setRegistryName(INregistryName);
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(String INregistryName, int INspecial){ //Normal Classless Items
            this(new Item(),INregistryName,INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }
}

Doing stuff n' things

Link to comment
Share on other sites

Creating items in static constructors is typically a bad thing to do.

Just setup your items normally in your init methods.

I figured that, but what actually it does? because I can just have items and register them any time I want,

and again I want to know what it really matters...

 

Is there some inside super wierd code that doesnt get applied to item instances when they are being themselves?

Doing stuff n' things

Link to comment
Share on other sites

You're not initalizing the items whenever you want, you're doing it whenever the class is referenced.

Which could be in placed you have no idea.

Such as when other mods re running and then FML is like "Where the hell are these items coming from!?" And it screws up the registry and things go to hell...

Its also a level of indirection magic that makes your code harder to understand.

Technically YES you could write things like this, but you shouldn't as it has a lot of downfalls.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Link to comment
Share on other sites

Actually just creating an Item instance is fine, it does not register it.

Just make sure you call GameRegistry.register in preInit only.

That's what I'm thinking about right now...

I'm just creating the items, and the registry happens only on preinit...

(a.k.a im calling

registerItems()

in preInit, and also calling

registerRenders()

in clientProxy's preInit)

So I dont actually think something would happen wrong...

Doing stuff n' things

Link to comment
Share on other sites

:D

 

I've managed to make it even smaller text/item ratio!

 

 

public class ModItems{
    public static enum ModItemsEnum{
        this_is_test(0)
        ,registry_name_here(0)
        ,this_is_also_the_unlocalized_name(0)
        
        
        ;


        private Item item;
        ModItemsEnum(Item INitem, int INspecial){ //Special ItemClass
            this.item = INitem;
            this.item.setUnlocalizedName(this.name());
            this.item.setRegistryName(this.name());
            if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);
        }

        ModItemsEnum(int INspecial){ //Normal Classless Items
            this(new Item(),INspecial);
        }

        public Item getItem(){
            return this.item;
        }
    }

    public static boolean registerItems(){
        try{
            for(ModItemsEnum item : ModItemsEnum.values()){
                GameRegistry.register(item.getItem());
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }

    public static boolean registerRenders(){
        try {
            for (ModItemsEnum item : ModItemsEnum.values()) {
                ModelLoader.setCustomModelResourceLocation(item.getItem(), 0, new ModelResourceLocation(item.getItem().getRegistryName(), "inventory"));
            }
        }catch(Exception e){
            return false;
        }
        return true;
    }
}

 

Figured: why the H would I even need a diffrent string for the unlocalized name..

So its just the same!

 

Thought I'd share... Dont really have a reason...

Doing stuff n' things

Link to comment
Share on other sites

Shame it will still crash a dedicated server because it has client-side-only code in a common place.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

ModelLoader

does not exist on the dedicated server.

 

Do you understand why the proxy system exists?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

As long as registration methods are called in mod's preInit, I can't argue with the fact that it will work.

 

As to what I would comment here:

 

1. While ModelLoader is not @SideOnly, it actually is for client use only and I personally would place it in client only class (or client proxy) or at least call it from one (client proxy). :)

 

2. You already made up your mind, why keep asking? If it works, it works (doesn't mean it is any better than any other thing you could write and most certainly it isn't clearer this way).

 

3. This is probably the worst: :P

if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);

Just do ModItemsEnum.this_is_test.item.setSomeThing(stuff) from preInit.

 

4. Oh wait, it (above) isn't - From now on, instead of doing Items.ITEM, you will have to do Items.LONG_ENUM_NAME.getItem() in EVERY damn place in your code... great!

Aside from that - writing such systems for simple stuff is retarded - anything out of ordinary will still require writing few more lines of code. :P

 

My piece on this. 8)

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

1. While ModelLoader is not @SideOnly, it actually is for client use only and I personally would place it in client only class (or client proxy) or at least call it from one (client proxy). :)

I said it is only called from client proxy.

 

3. This is probably the worst: :P

if(INspecial == 0)
                this.item.setCreativeTab(Main.modCreativeTab);

Just do ModItemsEnum.this_is_test.item.setSomeThing(stuff) from preInit.

This is only called to make special types of items, I dont want to add 10 items and get them in a tab and I dont want to make 10 items

and not get them in a tab, This is an automatic way to do special things to items using the enum constructor

 

4. Oh wait, it (above) isn't - From now on, instead of doing Items.ITEM, you will have to do Items.LONG_ENUM_NAME.getItem() in EVERY damn place in your code... great!

Aside from that - writing such systems for simple stuff is retarded - anything out of ordinary will still require writing few more lines of code. :P

Calling for an item using its registry name and adding a

getItem()

really isnt that bad for the nothing you do to add the item..

it wont change much at all...

 

 

 

2. You already made up your mind, why keep asking? If it works, it works (doesn't mean it is any better than any other thing you could write and most certainly it isn't clearer this way).

 

You're right!

 

LOCKED

Doing stuff n' things

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try removing the Curios mod and any mods that depend on it. Add them back in one at a time, test launching each time.
    • I am new in modding. I have a registry class for all minecraft items. How I add information an Item without opening new class?
    • Seriously, is this gonna plague future versions of Forge? Because how the hell am I supposed to load mods correctly like I did before if this keeps going on? (Here's the error.) [07Feb2023 12:06:56.387] [Render thread/WARN] [mixin/]: Error loading class: com/mojang/math/Quaternion (java.lang.ClassNotFoundException: com.mojang.math.Quaternion) [07Feb2023 12:06:56.390] [Render thread/FATAL] [mixin/]: Mixin apply failed flywheel.mixins.json:matrix.PoseStackMixin -> com.mojang.blaze3d.vertex.PoseStack: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException Unexpecteded ClassMetadataNotFoundException whilst transforming the mixin class: [MAIN Applicator Phase -> flywheel.mixins.json:matrix.PoseStackMixin -> Apply Methods -> (Lcom/mojang/math/Quaternion;)Lcom/jozufozu/flywheel/util/transform/TransformStack;:multiply -> Transform LVT -> var=quaternion -> desc=Lcom/mojang/math/Quaternion;] org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: Unexpecteded ClassMetadataNotFoundException whilst transforming the mixin class: [MAIN Applicator Phase -> flywheel.mixins.json:matrix.PoseStackMixin -> Apply Methods -> (Lcom/mojang/math/Quaternion;)Lcom/jozufozu/flywheel/util/transform/TransformStack;:multiply -> Transform LVT -> var=quaternion -> desc=Lcom/mojang/math/Quaternion;]     at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformMethod(MixinTargetContext.java:491) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyNormalMethod(MixinApplicatorStandard.java:532) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMethods(MixinApplicatorStandard.java:518) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:386) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:383) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:365) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:156) ~[modlauncher-10.0.8.jar:10.0.8+10.0.8+main.0ef7e830]     at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.6.jar:?]     at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.6.jar:?]     at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.6.jar:?]     at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.6.jar:?]     at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.6.jar:?]     at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]     at com.mojang.blaze3d.systems.RenderSystem.<clinit>(RenderSystem.java:83) ~[1.19.3-forge-44.1.16.jar:?]     at net.minecraft.client.main.Main.m_239872_(Main.java:174) ~[1.19.3-forge-44.1.16.jar:?]     at net.minecraft.client.main.Main.main(Main.java:51) ~[1.19.3-forge-44.1.16.jar:?]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]     at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:27) ~[fmlloader-1.19.3-44.1.16.jar:?]     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.8.jar:?]     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] Caused by: org.spongepowered.asm.mixin.throwables.ClassMetadataNotFoundException: com.mojang.math.Quaternion     at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformSingleDescriptor(MixinTargetContext.java:983) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformSingleDescriptor(MixinTargetContext.java:943) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformLVT(MixinTargetContext.java:544) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]     at org.spongepowered.asm.mixin.transformer.MixinTargetContext.transformMethod(MixinTargetContext.java:450) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] This has been going on since 44.1.8 and how on Earth is this not even fixed yet?
    • Error downloading asset (try 2) : minecraft/sounds/block/fence_gate/close2.ogg java.io.IOException: Server returned HTTP response code: 400 for URL: http://resources.download.minecraft.net/58/58d63232621aaa03e4d09598700561214e7c2477     at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1902)     at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1500)     at java.net.URL.openStream(URL.java:1093)     at net.minecraftforge.gradle.tasks.DownloadAssetsTask$GetAssetTask.call(DownloadAssetsTask.java:189)     at net.minecraftforge.gradle.tasks.DownloadAssetsTask$GetAssetTask.call(DownloadAssetsTask.java:150)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) This and countless other assets failing to download. This is my school laptop, Programs such as Fortiguard are installed, Could this possibly be interfering? 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.