Search the Forums BEFORE making a new post.

[1.8] [Solved] methods #onEntityWalking #onEntityCollideWithBlock

Followers

Start new topic

September 21, 20169 yr

Edit: I was registering BlockFluidClassic and not my custom Block class so never called my overrided methods!!!

Having a bit of trouble getting potion effects to work onEntityCollideWithBlock ...I have tried both (World worldIn, BlockPos pos, Entity entityIn) as parameters and (World worldIn, BlockPos pos, IBlockState state, Entity entityIn)

 @Override   
    public void onEntityWalking(World worldIn, BlockPos pos,  Entity entity){

        super.onEntityWalking(worldIn, pos, entity);
        if ((!worldIn.isRemote && entity instanceof EntityPlayer ))
    	((EntityPlayer)entity).attackEntityFrom(DamageSource.wither, 100);
    	
    }  
   //tried using IBlockState needed for 1.8 since there are two possible overloads 

   @Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, Entity entityIn) {

	if (entityIn instanceof EntityLiving ) {

		((EntityLiving)entityIn).addPotionEffect(new PotionEffect(Potion.damageBoost.id, 200, 1, false, true));		//adds potion effect to mobs/ target --strength=damageboost
	}	
		else if (entityIn instanceof EntityPlayer){	

		((EntityPlayer)entityIn).addPotionEffect(new PotionEffect(Potion.confusion.id, 200, 0, false, true));		//adds potion effect to player/target--nausea=confusion
		System.out.print("Called");
		}
		else if ((entityIn instanceof EntityBlackTobo || entityIn instanceof EntityTobieKing || entityIn instanceof EntityTobieQueen)){

			((EntityBlackTobo) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieKing) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieQueen) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));

		}
		  
}

At any rate, not real sure what the four parameters of PotionEffect are, I think it is duration, level ..not sure on the two booleans.

Also @Overriding onEntityWalking is redlined by eclipse . . .it does not seem to work at all in 1.8 ...has that method changed in 1.8 from 1.7.10?

Edit: Looks like #onEntityWalking is now #onEntityCollidedWithBlock with only the three parameters --ie, no IBlockState, and the former #onEntityCollidedWithBlock now has four parameters.

Mine is still not working though. Help appreciated

September 21, 20169 yr

Also @Overriding onEntityWalking is redlined by eclipse . . .it does not seem to work at all in 1.8 ...has that method changed in 1.8 from 1.7.10?

That means you aren't overriding a method (method signature doesn't match anything). You need to go look at the parent class to determine what the new signature is.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

September 21, 20169 yr

Author

Also @Overriding onEntityWalking is redlined by eclipse . . .it does not seem to work at all in 1.8 ...has that method changed in 1.8 from 1.7.10?

That means you aren't overriding a method (method signature doesn't match anything). You need to go look at the parent class to determine what the new signature is.

I don't see that method #onEntityWalking in 1.8

Why is the #onEntityCollidedWithBlock is not working for me in 1.8? in 1.7.10 instead of the BlockPos parameter, it was x, y, z but I did not change anything else? Sry to bother you but I'm sure this is something pitifully simple I'm just f---ing missing it

September 21, 20169 yr

Also @Overriding onEntityWalking is redlined by eclipse . . .it does not seem to work at all in 1.8 ...has that method changed in 1.8 from 1.7.10?

That means you aren't overriding a method (method signature doesn't match anything). You need to go look at the parent class to determine what the new signature is.

I don't see that method #onEntityWalking in 1.8

Why is the #onEntityCollidedWithBlock is not working for me in 1.8? in 1.7.10 instead of the BlockPos parameter, it was x, y, z but I did not change anything else? Sry to bother you but I'm sure this is something pitifully simple I'm just f---ing missing it

Block#onEntityWalk(World worldIn, BlockPos pos, Entity entityIn)

and

Block#public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) (Which is only called when the entity is within the collision bounds).

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 21, 20169 yr

Author

Edited:

#onEntityWalk not coming up for me as a method...perhaps that's a 1.8.9 or later version not 1.8?

The other method Block#public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn)is not working for me either maybe something wrong with my coding?

September 22, 20169 yr

Could you fix your post? I think you typed inside the quote.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 28, 20169 yr

Author

bump

Help please ...just a couple more problems to fix with my 1.8 mod update then I can move on to a newer version ..what is wrong with my coding? neither #onEntityCollideWithBlock with IBlockState parameter or without is working

I have no errors in Eclipse, and no crash. The method is simply not being called. My Block class extends BlockFluidClassic.

package com.glistre.glistremod.blocks;

import com.glistre.glistremod.entities.blacktobie.EntityBlackTobo;
import com.glistre.glistremod.entities.king.EntityTobieKing;
import com.glistre.glistremod.entities.queen.EntityTobieQueen;
import com.glistre.glistremod.init.ItemRegistry;
import com.glistre.glistremod.reference.Reference;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.BlockPos;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.DamageSource;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;

public class RudBlock extends BlockFluidClassic {

public RudBlock(Fluid fluid, Material material) {
	super(fluid, material);
	setCreativeTab(CreativeTabs.tabMisc);
}

    @Override
    public boolean canDisplace(IBlockAccess world, BlockPos pos) {
            if (world.getBlockState(pos).getBlock().getMaterial().isLiquid()) return false;
            return super.canDisplace(world, pos);
    }
    
    @Override
    public boolean displaceIfPossible(World world, BlockPos pos) {
            if (world.getBlockState(pos).getBlock().getMaterial().isLiquid()) return false;
            return super.displaceIfPossible(world, pos);
    }
   @Override 
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        return true;
    }

/* @Override   
  //duration, level , badeffect or not
    public void onEntityWalk(World worldIn, BlockPos pos, Entity entity){

//    ((EntityLivingBase) entity).addPotionEffect(new PotionEffect(ItemRegistry.poisonProtectPotion.id, 300, 0, false));
//adds damage effect from Rud
        
        if ((!worldIn.isRemote && entity instanceof EntityPlayer ))
    	((EntityPlayer)entity).attackEntityFrom(DamageSource.wither, 100);
    	
    }  */

   public AxisAlignedBB getCollisionBoundingBox(World worldIn, BlockPos pos, IBlockState state)
   {
       float f = .01F;
       return new AxisAlignedBB((double)((float)pos.getX() + f), (double)pos.getY(), (double)((float)pos.getZ() + f), (double)((float)(pos.getX() + 1) - f), (double)((float)(pos.getY() + 1) - f), (double)((float)(pos.getZ() + 1) - f));
   }
//adds 0.01F to the block bounding box AKA makes box smaller?larger?
   @Override
   @SideOnly(Side.CLIENT)
   public AxisAlignedBB getSelectedBoundingBox(World worldIn, BlockPos pos)
   {
           float f = 0.01F;
           return new AxisAlignedBB((double)((float)pos.getX() + f), (double)pos.getY(), (double)((float)pos.getZ() + f), (double)((float)(pos.getX() + 1) - f), (double)(pos.getY() + 1), (double)((float)(pos.getZ() + 1) - f));
   }
   
   @Override 
   public void setBlockBoundsBasedOnState(IBlockAccess worldIn, BlockPos pos){
   this.setBlockBounds(0.0F,  0.0F, 0.0F, 1.0F, 0.0625F, 1.0F);
   }
   
   @Override//no IBlockState aka stateless matches old onEntityWalking exactly like with slimes
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, Entity entityIn) {
  
//	   super.onEntityCollidedWithBlock(worldIn, pos, entityIn);
   //adds damage effect from Rud
       
       if ((!worldIn.isRemote && entityIn instanceof EntityPlayer ))
   	((EntityPlayer)entityIn).attackEntityFrom(DamageSource.wither, 100);
   	
   }	  

   //use IBlockState needed for 1.8 there are two overloads 
  //duration, level , badeffect , no swirls?
   @Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
   
//	   super.onEntityCollidedWithBlock(worldIn, pos, state, entityIn);

   if (!worldIn.isRemote && entityIn instanceof EntityPlayer ){	

	   ((EntityPlayer)entityIn).attackEntityFrom(DamageSource.wither, 1.0F);
		((EntityPlayer)entityIn).addPotionEffect(new PotionEffect(Potion.confusion.id, 300, 0, false, false));


		//adds potion effect to player/target--nausea=confusion
		System.out.print("Called confusion");
		return;
	}	
		else if (entityIn instanceof EntityLiving ) {		
			((EntityLiving)entityIn).addPotionEffect(new PotionEffect(Potion.damageBoost.id, 2000, 2, false, false));
			//adds potion effect to mobs/ target --strength=damageboost
			System.out.println("Called damageboost");
			return;
	}
		else if ((entityIn instanceof EntityBlackTobo || entityIn instanceof EntityTobieKing || entityIn instanceof EntityTobieQueen)){

			((EntityBlackTobo) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieKing) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieQueen) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			System.out.println("Called mob healing");
		}
   return;
}
    
    @Override 
    public boolean isOpaqueCube(){

    	return true;
    }
    @Override 
    public boolean isFullCube(){

    	return false;
    }
    
}

September 28, 20169 yr

bump

I have no errors in Eclipse, and no crash. The method is simply not being called. My Block class extends BlockFluidClassic.

package com.glistre.glistremod.blocks;

import com.glistre.glistremod.entities.blacktobie.EntityBlackTobo;
import com.glistre.glistremod.entities.king.EntityTobieKing;
import com.glistre.glistremod.entities.queen.EntityTobieQueen;
import com.glistre.glistremod.init.ItemRegistry;
import com.glistre.glistremod.reference.Reference;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.BlockPos;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.DamageSource;
import net.minecraft.util.EnumFacing;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;

public class RudBlock extends BlockFluidClassic {

public RudBlock(Fluid fluid, Material material) {
	super(fluid, material);
	setCreativeTab(CreativeTabs.tabMisc);
}

    @Override
    public boolean canDisplace(IBlockAccess world, BlockPos pos) {
            if (world.getBlockState(pos).getBlock().getMaterial().isLiquid()) return false;
            return super.canDisplace(world, pos);
    }
    
    @Override
    public boolean displaceIfPossible(World world, BlockPos pos) {
            if (world.getBlockState(pos).getBlock().getMaterial().isLiquid()) return false;
            return super.displaceIfPossible(world, pos);
    }
   @Override 
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        return true;
    }

/* @Override   
  //duration, level , badeffect or not
    public void onEntityWalk(World worldIn, BlockPos pos, Entity entity){

//    ((EntityLivingBase) entity).addPotionEffect(new PotionEffect(ItemRegistry.poisonProtectPotion.id, 300, 0, false));
//adds damage effect from Rud
        
        if ((!worldIn.isRemote && entity instanceof EntityPlayer ))
    	((EntityPlayer)entity).attackEntityFrom(DamageSource.wither, 100);
    	
    }  */

   public AxisAlignedBB getCollisionBoundingBox(World worldIn, BlockPos pos, IBlockState state)
   {
       float f = .01F;
       return new AxisAlignedBB((double)((float)pos.getX() + f), (double)pos.getY(), (double)((float)pos.getZ() + f), (double)((float)(pos.getX() + 1) - f), (double)((float)(pos.getY() + 1) - f), (double)((float)(pos.getZ() + 1) - f));
   }
//adds 0.01F to the block bounding box AKA makes box smaller?larger?
   @Override
   @SideOnly(Side.CLIENT)
   public AxisAlignedBB getSelectedBoundingBox(World worldIn, BlockPos pos)
   {
           float f = 0.01F;
           return new AxisAlignedBB((double)((float)pos.getX() + f), (double)pos.getY(), (double)((float)pos.getZ() + f), (double)((float)(pos.getX() + 1) - f), (double)(pos.getY() + 1), (double)((float)(pos.getZ() + 1) - f));
   }
   
   @Override 
   public void setBlockBoundsBasedOnState(IBlockAccess worldIn, BlockPos pos){
   this.setBlockBounds(0.0F,  0.0F, 0.0F, 1.0F, 0.0625F, 1.0F);
   }
   
   @Override//no IBlockState aka stateless matches old onEntityWalking exactly like with slimes
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, Entity entityIn) {
  
//	   super.onEntityCollidedWithBlock(worldIn, pos, entityIn);
   //adds damage effect from Rud
       
       if ((!worldIn.isRemote && entityIn instanceof EntityPlayer ))
   	((EntityPlayer)entityIn).attackEntityFrom(DamageSource.wither, 100);
   	
   }	  

   //use IBlockState needed for 1.8 there are two overloads 
  //duration, level , badeffect , no swirls?
   @Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
   
//	   super.onEntityCollidedWithBlock(worldIn, pos, state, entityIn);

   if (!worldIn.isRemote && entityIn instanceof EntityPlayer ){	

	   ((EntityPlayer)entityIn).attackEntityFrom(DamageSource.wither, 1.0F);
		((EntityPlayer)entityIn).addPotionEffect(new PotionEffect(Potion.confusion.id, 300, 0, false, false));


		//adds potion effect to player/target--nausea=confusion
		System.out.print("Called confusion");
		return;
	}	
		else if (entityIn instanceof EntityLiving ) {		
			((EntityLiving)entityIn).addPotionEffect(new PotionEffect(Potion.damageBoost.id, 2000, 2, false, false));
			//adds potion effect to mobs/ target --strength=damageboost
			System.out.println("Called damageboost");
			return;
	}
		else if ((entityIn instanceof EntityBlackTobo || entityIn instanceof EntityTobieKing || entityIn instanceof EntityTobieQueen)){

			((EntityBlackTobo) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieKing) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			((EntityTobieQueen) entityIn).addPotionEffect(new PotionEffect(Potion.heal.id, 2000, 7, false, true));
			System.out.println("Called mob healing");
		}
   return;
}
    
    @Override 
    public boolean isOpaqueCube(){

    	return true;
    }
    @Override 
    public boolean isFullCube(){

    	return false;
    }
    
}

It may have something to do with canCollideCheck(...)

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

September 29, 20169 yr

Author

Not exactly sure how to use that method, I added the following to my RudBlock code and nothing changed.

@Override
public boolean canCollideCheck(IBlockState state, boolean hitIfLiquid){

	//return hitIfLiquid && ((Integer)state.getValue(LEVEL)).intValue() == 1;
//	return false;
	return this.isCollidable();
}

  @Override
  	@SideOnly(Side.CLIENT)
      public boolean isCollidable()
      {
      	return true;
      }

2 years later...

November 29, 20187 yr

Yes It's also working with minecraft 1.12.2

7 yr7 yr Guest locked this topic

This topic is now closed to further replies.

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Porting a mod from MCreator

I recommend starting with a simple "Hello World" mod in Fabric or Forge to get familiar with the development environment and the API. Then, gradually add features from your MCreator mod, focusing on the custom grass block and bonemeal interactions first. Attempt to extend your MCreator mod with custom Java code. This is very complex and often leads to instability. It involves exporting your MCreator code and trying to integrate it with a Java modding project. Not recommended unless you're already comfortable with Java.

By lucasoxsxoz · 8 minutes ago8 min
What Actually Makes a Forge Mod Feel “High Quality”?

In the world of Minecraft modding, "high quality" is rarely about adding the most content. Instead, it’s about seamlessness. A high-quality mod (think Create, Alex’s Mobs, or Farmer’s Delight) feels like it was developed by Mojang, but with a higher degree of complexity than they usually allow.
Here is the anatomy of a top-tier Forge mod: Uhmegle OmeTv
1. The "Vanilla+" Aesthetic (Art Direction)
High-quality mods respect the 16x16 pixel grid.
Color Palette: They use the established "Minecraft colors" (muted greens, desaturated stones). If a mod adds a new metal that is neon purple and glowing, it immediately feels "moddy" and low-effort.
Model Complexity: They avoid "circular" models or hyper-detailed shapes. They stick to the "cubic" philosophy. Even Create, which adds complex machinery, uses blocks and shafts that feel like they belong in a blocky world.
2. Deep Integration (The "Tag" System)
A low-quality mod is an island; a high-quality mod is a bridge.
Cross-Mod Compatibility: High-quality mods use Tags (e.g., #forge:ingots/copper). This ensures that if you have five different mods that add copper, the high-quality mod recognizes all of them for its recipes.
World-Gen Logic: A high-quality biome doesn't just cut off at a square border. It uses the modern noise-generator system to blend into neighboring biomes realistically.
3. Polish and "Juice"
This is the "feel" of the mod that is hard to quantify but easy to notice:
Custom Particles & Sounds: When you interact with a block, does it make a unique, high-fidelity sound, or does it just use the generic "stone break" noise?
Animations: Does the mob have a "hinge" leg movement (old school), or does it have subtle animations like ear twitches or tail wags?
Tooltips: Professional mods use colors and "Shift for more info" prompts in their item descriptions.
4. Technical Stability (The "Log" Test)
If you open a Minecraft instance with a high-quality mod, the Latest.log file shouldn't be screaming.
Optimization: High-quality mods use Flywheel or similar rendering engines to ensure that adding 100 new machines doesn't drop your FPS to 10.
Conflict Avoidance: They don't "hard-overwrite" vanilla classes (which causes crashes with other mods). They use Mixins cleanly.
5. Documentation (The In-Game Manual)
The days of having to tab out to a messy Wiki are over.
Patchouli or Lavender: High-quality mods almost always include a craftable book that explains the mechanics in-game.
JEI Integration: Every single item and machine must have its recipes clearly visible in Just Enough Items.

By Diplak · 11 minutes ago11 min
Ore to nuggets and ore rarity mod

Tough As Nails: (Fabric & Forge) While not exactly what you described, Tough As Nails adds temperature and thirst mechanics, making survival more challenging overall. It doesn't directly change smelting, but it increases the difficulty of resource gathering and exploration. https://www.curseforge.com/minecraft/mc-mods/tough-as-nails
Realistic Ore Generation: (Forge - might have Fabric ports) This mod focuses on making ore generation more realistic, often resulting in rarer ores and more uneven distribution. It doesn't change smelting, but it addresses the diamond rarity aspect.
Scaling Health & Difficulty: (Fabric & Forge) This mod increases the difficulty of mobs as you progress, making combat more challenging and requiring better gear (which means more resource grinding).
Resourceful Fuels: (Fabric & Forge) This mod makes fuel sources more limited, indirectly increasing the grind for smelting.

By noahrauckn · 13 minutes ago13 min
How Can I Safely Play an Old Version of Minecraft?

1. Open the Minecraft Launcher: Launch the official Minecraft Launcher.
2. Go to Installations: Click on the "Installations" tab at the top.
3. Create a New Installation: Click the "+ New Installation" button.
4. Name Your Installation: Give it a descriptive name like "Minecraft Beta 1.7.3" so you know what it is.
5. Version Selection: In the "Version" dropdown menu, scroll down until you find "1.7.3" (or the specific Beta version you want). It will be under the "Legacy" section.

By lucasbatzd950 · 25 minutes ago25 min
im trying to find my mods but i cant it anywhere even tho it is the corect everything and its on the corect lauther aswell but

im doing everything correct but yet it isnt showing my mods anywhere

By susbpacer · 1 hour ago1 hr

[1.8] [Solved] methods #onEntityWalking #onEntityCollideWithBlock

Featured Replies

Posts

Porting a mod from MCreator

What Actually Makes a Forge Mod Feel “High Quality”?

Ore to nuggets and ore rarity mod

How Can I Safely Play an Old Version of Minecraft?

im trying to find my mods but i cant it anywhere even tho it is the corect everything and its on the corect lauther aswell but

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)