[1.8.9] Issue with new Forge Blockstate

[GalianRyu]

I'm trying to use the new Submodel Blockstates to make some unique stairs and I've encounterted something odd, hoping you guys might know what I can do.

 

Here is an excerpt from the JSON file in question:

 

{
    "forge_marker": 1,
    "defaults": {
    	"textures": {
    		"top": "millenaire:blocks/tilestopvert",
    		"bottom": "blocks/stonebrick",
    		"front": "millenaire:blocks/tilesfront",
        	"back": "millenaire:blocks/tilesfront",
        	"side": "millenaire:blocks/tilesfront"
        }
},
"variants": {
	"half": {
		"top": { "x": 180 },
		"bottom": {}
	},
	"facing": {
		"north": { "y": 270 },
		"south": { "y": 90 },
		"east": {},
		"west": { "y": 180 }
	},
	"shape": {
		"straight": {
			"submodel": {
        			"stonePart": { "model": "millenaire:byzantineStairsStonePart", "uvlock": true },
        			"tilePart": { "model": "millenaire:byzantineStairsTilePart", "uvlock": false }
        		}
		},

 

No errors in the console, no problem rendering the block, but the issue is that it won't flip the stairs unless they facing East.  Basically unless "facing" is East, "half" is being completely ignored.  I've run many tests and isolated that as the problem.  Anyone know what I can do?

[GalianRyu]

For further info:  I tried editing it this way, as a test.

	"variants": {
	"half": {
		"top": { "x": 180 },
		"bottom": { "x": 90 }
	},
	"facing": {
		"north": { "y": 270 },
		"south": { "y": 90 },
		"east": { "y": 0 },
		"west": { "y": 180 }
	},

And now it ignores "half" completely, even when facing is east.  So it seems like multiple variables can't both be affecting the rotation, is this a bug in Forge itself?

[LexManos]

Update to 1.10 and the system doesn't work like that the specific x/z values are not mixed so you're defining models with null models and x defined as 0 for all the directions

[GalianRyu]

If that's the case, wouldn't it also fail to work on "facing"?  It orients to the correct Y value on all of those.  And if I take out the changes to Y in facing, then if flips on X just fine.  I guess I'm failing to understand exactly what you mean, aside from update to 1.10? (which is the plan eventually, but this is not a small mod and that's a fair bit of work).

[Draco18s]

Lex means that rotations aren't combinable.  Just because one specifies X and the other Y doesn't mean that a combined state will rotate XY, instead it picks "one" and that's why removing it makes the other one work: rotate is really only one field.

[GalianRyu]

Ah, okay that makes sense. 

 

Means I have to either abandon doing the stairs this way and just use a simpler model, or I have to switch from inheriting stairs and define a blockstate that would let me include both directional rotations in one variable (upper-north, upper-south, lower-north, etc).

 

Okay, well thank you both for helping me out!

[jeffryfisher]

I think it means that you must list the Cartesian product of the state's properties (4 facings * 2 halves = 8 variants) so that you can put both x and y into a single rotation array for each.

[GalianRyu]

Is there a way to do that without having to change the Enum values in the code itself Jeffery?

[GalianRyu]

I cannot believe this actually worked, but it does!  I glanced over the code that makes the blockstates from the new system and test this and it works:

{
    "forge_marker": 1,
    "defaults": {
    	"textures": {
    		"top": "millenaire:blocks/tilestopvert",
    		"bottom": "blocks/stonebrick",
    		"front": "millenaire:blocks/tilesfront",
        	"back": "millenaire:blocks/tilesfront",
        	"side": "millenaire:blocks/tilesfront"
        }
},
"variants": {
	"facing": {
		"north,half=bottom": { "y": 270 },
		"south,half=bottom": { "y": 90 },
		"east,half=bottom": { "y": 0 },
		"west,half=bottom": { "y": 180 },
		"north,half=top": { "y": 270, "x": 180 },
		"south,half=top": { "y": 90, "x": 180 },
		"east,half=top": { "y": 0, "x": 180 },
		"west,half=top": { "y": 180, "x": 180 }
	},
	"shape": {
		"straight": {
			"submodel": {
        			"stonePart": { "model": "millenaire:byzantineStairsStonePart", "uvlock": true },
        			"tilePart": { "model": "millenaire:byzantineStairsTilePart", "uvlock": false }
        		}
		},

 

While this is somewhat of a hack, I'd suggest actually making it a thing, because it greatly increases the options available in this new system.  Immense gratitude to Jeffryfisher for giving me the idea to keep experimenting!

[Draco18s]

Uh...

Cartesian product of the state's properties

"north,half=bottom": { "y": 270 },

That's exactly what Jeffy said.

https://en.wikipedia.org/wiki/Cartesian_product