[1.8.9] More effective replacement for thread.sleep?

larsgerrits · October 7, 2016

You don't know how to?

Yes we do, but it's your mod, and we are not going to write your mod for you.

CoalOres · October 7, 2016

You don't know how to?

Yes we do, but it's your mod, and we are not going to write your mod for you.

I've attempted to copy the data in the txt file to an arrayList but it is just resulting in a "The type of expression must be an array type but it is resolved to List<String>".

This is the only way I can think of keeping track:

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont == true){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	            try {
	                FileReader file = new FileReader(path);
	                BufferedReader buffered = new BufferedReader(file);
	               
	                while ((line = buffered.readLine()) != null) {
	                    list.add(line);
	                    
	                }
	                int i = 0;
	                

	               if(list[i] != null){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + line);
	                		i ++;

	                }
	               else{
	            	   buffered.close();
	            	   com.megaparties.Events.cont = false;
	               }

	                
	            }
	            catch (IOException e) {
	                e.printStackTrace();
	            }
		 }
	 }



}

There error is on the if(list != null)

Draco18s · October 7, 2016

Because that is not how you get the i'th element of a List.

This is basic java.

We are not here to help you learn basic java.

CoalOres · October 7, 2016

Because that is not how you get the i'th element of a List.

This is basic java.

We are not here to help you learn basic java.

Got it confused with Python, I need to use list.get don't I?

larsgerrits · October 7, 2016

Try it and you'll find out.

CoalOres · October 7, 2016

Try it and you'll find out.

My New Code:

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont == true){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	            try {
	                FileReader file = new FileReader(path);
	                BufferedReader buffered = new BufferedReader(file);
	               
	                while ((line = buffered.readLine()) != null) {
	                    list.add(line);
	                    
	                }
	                int i = 0;
	                

	               if(list.get(i) != null){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + line);
	                		i ++;

	                }
	               else{
	            	   buffered.close();
	            	   com.megaparties.Events.cont = false;
	               }

	                
	            }
	            catch (IOException e) {
	                e.printStackTrace();
	            }
		 }
	 }

I can already see that it isn't going to work because i is set back to 0 every time it loops over.

larsgerrits · October 7, 2016

Then you have to save the integer outside of the method.

CoalOres · October 7, 2016

Then you have to save the integer outside of the method.

Ok, I've done that, it works, save for the fact that the loop never ends... i never equals null and so it doesn't close. I can't put it at 0 because 0 still has a value, I need to detect when it has gone through the whole list.

larsgerrits · October 7, 2016

Don't do the reading of the whitelist every 5 ticks. Do it in a method that's getting called only once on startup (postInit or something else). Reading every tick is unnecessary.

Also,

if(cont == true)

is the same as

if(cont)

... (Basic Java)

CoalOres · October 7, 2016

Don't do the reading of the whitelist every 5 ticks. Do it in a method that's getting called only once on startup (postInit or something else). Reading every tick is unnecessary.

Also,
if(cont == true)
is the same as
if(cont)
... (Basic Java)

I don't think that would quite work. You see I also have commands which write to the file and clear it whenever you activate them, so it needs to be re-read. I probably misunderstood that.

Isn't there anything simpler I could do? Like

	               if(i <= list.size()){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
	                		i ++;

	                }

I tried that and it still didn't work.

CoalOres · October 7, 2016

Also tried a ListIterator, still didn't work.

larsgerrits · October 7, 2016

You really make me think you don't know Java... Do you?

Draco18s · October 7, 2016

You really make me think you don't know Java... Do you?

I am pretty sure that the answer to that for any post involving "thread.sleep" is "no."

CoalOres · October 7, 2016

I have discovered the source of the problem, now I am getting an array index out of bounds exception:

Command:

package com.megaparties;

import java.io.BufferedReader;
import java.io.FileReader;
import java.io.IOException;

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;

public class wparty extends  CommandBase {


    


    public String getCommandName() {
        return "wparty";
    }

    public String getCommandUsage(ICommandSender sender) {
        return "wparty";
    }

    public boolean canCommandSenderUseCommand(ICommandSender icommandsender) {
        return true;
    }

    public void processCommand(ICommandSender sender, String[] args) throws CommandException {
    	
    	com.megaparties.Events.cont = true;
    	   String path = "config/whitelist.txt";
           String line;
      
           try {
               FileReader file = new FileReader(path);
               BufferedReader buffered = new BufferedReader(file);
              
              
               while ((line = buffered.readLine()) != null) {
                   com.megaparties.Events.list.add(line);
                   
               
               }
               buffered.close();
           }
               catch (IOException e) {
                e.printStackTrace();
            }
            
        
        
    }


}

Event:

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	           
            if(i < list.size()){

						Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
						i ++;
						System.out.println(i);
						System.out.println(list.size());


				}
            else{
				  
				   com.megaparties.Events.cont = false;
				   
				   i = 0;
            }
		 }
	 }

Animefan8888 · October 7, 2016

I have discovered the source of the problem, now I am getting an array index out of bounds exception:

Command:

package com.megaparties;

import java.io.BufferedReader;
import java.io.FileReader;
import java.io.IOException;

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;

public class wparty extends  CommandBase {


    


    public String getCommandName() {
        return "wparty";
    }

    public String getCommandUsage(ICommandSender sender) {
        return "wparty";
    }

    public boolean canCommandSenderUseCommand(ICommandSender icommandsender) {
        return true;
    }

    public void processCommand(ICommandSender sender, String[] args) throws CommandException {
    	
    	com.megaparties.Events.cont = true;
    	   String path = "config/whitelist.txt";
           String line;
      
           try {
               FileReader file = new FileReader(path);
               BufferedReader buffered = new BufferedReader(file);
              
              
               while ((line = buffered.readLine()) != null) {
                   com.megaparties.Events.list.add(line);
                   
               
               }
               buffered.close();
           }
               catch (IOException e) {
                e.printStackTrace();
            }
            
        
        
    }


}

Event:

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	           
            if(i < list.size()){

						Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
						i ++;
						System.out.println(i);
						System.out.println(list.size());


				}
            else{
				  
				   com.megaparties.Events.cont = false;
				   
				   i = 0;
            }
		 }
	 }

How do we help without seeing the stack trace (the log)?

Regardful · September 27, 2019

On 10/6/2016 at 4:06 PM, Draco18s said:

No no no no no no NO.

The command's only purpose is to go "oh the user told the server to do something."

The tick handler is where your file read code needs to go.

l0l u sound exactly like what ur signature says xddd

DaemonUmbra · September 28, 2019

Please don't Necro old threads.

Sign In

[1.8.9] More effective replacement for thread.sleep?

Recommended Posts

larsgerrits

CoalOres

Draco18s

CoalOres

larsgerrits

CoalOres

larsgerrits

CoalOres

larsgerrits

CoalOres

CoalOres

larsgerrits

Draco18s

CoalOres

Animefan8888

Regardful

DaemonUmbra

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information