[1.10.2] On oredict registered [Solved]

[pfgforge]

I'm looking for a way to call a function when an item is registered to the oredictionary so that I can automatically make simple dusts for my mod. Is there any way to do this, or should it be done differently?

[Animefan8888]

I dont think this is possible because items must be registered in there event which is called prior to preInit. Or it is done during preInit...And typically ore dictionary is done in init or postInit from my experience with it.

[Draco18s]

OreRegisterEvent

[pfgforge]

OreRegisterEvent

 

I saw this, but I'm not sure how to use it

[Draco18s]

Subscribe to it, do whatever you want to.

[pfgforge]

Subscribe to it, do whatever you want to.

 

I've been looking for a while, but I don't know how to subscribe to events

[Draco18s]

https://mcforge.readthedocs.io/en/latest/events/intro/

[pfgforge]

https://mcforge.readthedocs.io/en/latest/events/intro/

 

Still not fully sure how to handle the event.

 

I @SubscribeEvent, but what's it called and what are it's arguments?

@SubscribeEvent
public void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {

[Draco18s]

public void OreRegisterEvent(OreRegisterEvent e) { }

[pfgforge]

public void OreRegisterEvent(OreRegisterEvent e) { }

 

OreRegisterEvent cannot be resolved to a type

[Draco18s]

Oh sorry, you were right the first time.  I didn't realize the event was declared as a static class inside the OreDict.

What's your problem?

[pfgforge]

Oh sorry, you were right the first time.  I didn't realize the event was declared as a static class inside the OreDict.

What's your problem?

 

It never seems to get called

 

Main mod file:

    @EventHandler
    public void preInit(FMLPreInitializationEvent event){
    	System.out.println("Preinit Was Called"); // Prints
    	MinecraftForge.EVENT_BUS.register(new OreRegisterEventHandler());
    }

 

OreRegisterEventHandler:

public class OreRegisterEventhandler {

   @SubscribeEvent
   public void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
String name = e.getName();
System.out.println("An ore is being registered "+name); // Never prints
   }

}

[Animefan8888]

The @SubscribeEvent goes over the method not the class.

[pfgforge]

The @SubscribeEvent goes over the method not the class.

 

Sorry, pasted the code wrong. The subscribe event is over the method

[Animefan8888]

The @SubscribeEvent goes over the method not the class.

 

Sorry, pasted the code wrong. The subscribe event is over the method

Did you re paste the code or just fix that one error? And also are you registering something into the ore dictionary after registering the event?

[pfgforge]

The @SubscribeEvent goes over the method not the class.

 

Sorry, pasted the code wrong. The subscribe event is over the method

Did you re paste the code or just fix that one error? And also are you registering something into the ore dictionary after registering the event?

 

I went back to my post to edit it and add the class part, but accidentally put the subscribe event before the class. My actual code never had that. I am trying to register something into the oredict when the event is called (it won't loop infinitely, I have it set up right), but the event doesn't get called yet

[Animefan8888]

The @SubscribeEvent goes over the method not the class.

 

Sorry, pasted the code wrong. The subscribe event is over the method

Did you re paste the code or just fix that one error? And also are you registering something into the ore dictionary after registering the event?

 

I went back to my post to edit it and add the class part, but accidentally put the subscribe event before the class. My actual code never had that. I am trying to register something into the oredict when the event is called (it won't loop infinitely, I have it set up right), but the event doesn't get called yet

The event is fired when something is registered to the OreDictionary it is not used to register something to the OreDictionary specifically.

[pfgforge]

The @SubscribeEvent goes over the method not the class.

 

Sorry, pasted the code wrong. The subscribe event is over the method

Did you re paste the code or just fix that one error? And also are you registering something into the ore dictionary after registering the event?

 

I went back to my post to edit it and add the class part, but accidentally put the subscribe event before the class. My actual code never had that. I am trying to register something into the oredict when the event is called (it won't loop infinitely, I have it set up right), but the event doesn't get called yet

The event is fired when something is registered to the OreDictionary it is not used to register something to the OreDictionary specifically.

I know. Forge by default registers some ores, and when they are registered I want this method to be called so I can register my own based on them.

[Animefan8888]

Then instead of registering the event in preInit use the static way of registering it was in the link Dracos provided.

[pfgforge]

Then instead of registering the event in preInit use the static way of registering it was in the link Dracos provided.

 

I switched it to a static void, but it still doesn't work

 

    @EventHandler
    public void preInit(FMLPreInitializationEvent event){
    	System.out.println("This is printed, showing that the preinit is running");
    	
    	MinecraftForge.EVENT_BUS.register(OreRegisterEventhandler.class);

 

public class OreRegisterEventhandler {
@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This never gets called, and is never printed. It should get called because forge registers some ores by default"+name);

[Animefan8888]

I meant this part

Automatically Registering Static Event Handlers

[pfgforge]

I meant this part

Automatically Registering Static Event Handlers

 

Tried in both OreRegisterEventhandler and in the main mod file.

 

@Mod.EventBusSubscriber
public class OreRegisterEventhandler {
@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This doesn't get printed ever "+name);

 

@Mod(modid = modname.MODID, version = modname.VERSION)
@Mod.EventBusSubscriber
public class modname {
        // init functions and stuff...

@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This also doesn't get printed "+name);

[Animefan8888]

I meant this part

Automatically Registering Static Event Handlers

 

Tried in both OreRegisterEventhandler and in the main mod file.

 

@Mod.EventBusSubscriber
public class OreRegisterEventhandler {
@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This doesn't get printed ever "+name);

 

@Mod(modid = modname.MODID, version = modname.VERSION)
@Mod.EventBusSubscriber
public class modname {
        // init functions and stuff...

@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This also doesn't get printed "+name);

The problem now that I am looking at this class is that the method that registers vanilla is called as soon as a static{} gets called.

[pfgforge]

I meant this part

Automatically Registering Static Event Handlers

 

Tried in both OreRegisterEventhandler and in the main mod file.

 

@Mod.EventBusSubscriber
public class OreRegisterEventhandler {
@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This doesn't get printed ever "+name);

 

@Mod(modid = modname.MODID, version = modname.VERSION)
@Mod.EventBusSubscriber
public class modname {
        // init functions and stuff...

@SubscribeEvent
public static void OreRegisterEvent(OreDictionary.OreRegisterEvent e) {
	String name = e.getName();
	System.out.println("This also doesn't get printed "+name);

The problem now that I am looking at this class is that the method that registers vanilla is called as soon as a static{} gets called.

 

So... should I loop over all the oredict entries postinit?

[Animefan8888]

Depends on what you mean post update?