Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

PR Minecraft Forge Github Quick Question

Asweez

By Asweez
in Modder Support

 Share

Recommended Posts

Asweez Diamond Finder

Asweez

Posted
Posted

What are the @@ things on the minecraft forge github files?

 

For example 

@@ -59,8 +59,15 @@

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Draco18s Reality Controller

Draco18s

Posted
Posted

Those are indicators of position within the vanilla class file.

You shouldn't be needing to worry about those.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Asweez Diamond Finder

Asweez

Posted
  • Author
Posted

Thanks! And how would I become a contributor?

 

Also (sorry for all of the questions but that's why I'm here haha) like I was saying in my earlier post, I want to change the way entity updating can be modified. Would it be best to modify the CanUpdate event so you can cancel entity updates (instead of just allowing them when they are supposed to be cancelled) or should I make a new event where entity updates can be cancelled?

 

Thanks

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Draco18s Reality Controller

Draco18s

Posted
Posted
https://github.com/MinecraftForge/MinecraftForge/wiki/If-you-want-to-contribute-to-Forge

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Asweez Diamond Finder

Asweez

Posted
  • Author
Posted

And about my other question?

 

  On 11/21/2016 at 2:20 AM, Asweez said:

Also (sorry for all of the questions but that's why I'm here haha) like I was saying in my earlier post, I want to change the way entity updating can be modified. Would it be best to modify the CanUpdate event so you can cancel entity updates (instead of just allowing them when they are supposed to be cancelled) or should I make a new event where entity updates can be cancelled?

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
  On 11/21/2016 at 3:31 PM, Asweez said:

And about my other question?

 

  Quote

Also (sorry for all of the questions but that's why I'm here haha) like I was saying in my earlier post, I want to change the way entity updating can be modified. Would it be best to modify the CanUpdate event so you can cancel entity updates (instead of just allowing them when they are supposed to be cancelled) or should I make a new event where entity updates can be cancelled?

You will want to create a new event like maybe CancelEntityUpdate or OverrideCanEntityUpdate. Or even suggest a change in name for the CanUpdateEvent.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Asweez Diamond Finder

Asweez

Posted
  • Author
Posted

Thanks!

 

What is the difference between the 'Clean' and 'Forge' projects? Clean seems to be only Minecraft files, whereas Forge is both minecraft files and forge files, but the Forge minecraft files are different than the Clean minecraft files. What's going on?

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Draco18s Reality Controller

Draco18s

Posted
Posted
  On 11/22/2016 at 12:55 AM, Asweez said:

What is the difference between the 'Clean' and 'Forge' projects? Clean seems to be only Minecraft files, whereas Forge is both minecraft files and forge files, but the Forge minecraft files are different than the Clean minecraft files. What's going on?

 

One is unaltered, the other is altered?

Like, it's not that hard.  The Forge project is where Forge makes their changes.  The clean one is clean.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Asweez Diamond Finder

Asweez

Posted
  • Author
Posted

Oh alright I was way overthinking that.

 

I have another problem, whenever I run gradlew genPatches, I get this error

 

 

  Reveal hidden contents

 

 

Any help would be appreciated

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Asweez Diamond Finder

Asweez

Posted
  • Author
Posted

1) Where do I find the version that forge depends on?

 

2) How do I change the version of javax.vecmath that I use? (I use Eclipse)

Creator of the MyFit, MagiCraft, Tesseract gun, and Papa's Wingeria mod.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      Unable to update native luancher

      By TileEntity · Posted

      Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • Noureldien
      Unable to update native luancher

      By Noureldien · Posted

      can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • GPGPGold9393
      Death screen only shows the "You Died!" part

      By GPGPGold9393 · Posted

      The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept