Help with setBlockState

[Durtle02]

Hello. I'm trying to make a block where on random ticks it will grow upwards(for now), like reeds. Also it is supposed to grow upwards on player activation. I have somewhat of a clue how to to this and the current code I have isn't working. The block is registering in game and the name, texture, and creative tab are all working.

package TestMod.tutorial.block;

import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class GooBlock extends BlockBase{
    
    public GooBlock(String name){
        super(Material.ROCK, name);
        setTickRandomly(true);
        setHardness(0f);
        setResistance(1f);
    } 
    
    @Override
    public GooBlock setCreativeTab(CreativeTabs tab){
        super.setCreativeTab(tab);
        return this;
    }
    
    public void updateTick(World worldIn, BlockPos pos){
        BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());

        
        worldIn.setBlockState(pos0, ModBlocks.gooblock.getDefaultState());
    }
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ){
        BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());
        worldIn.setBlockState(pos0, ModBlocks.gooblock.getDefaultState());
    return false;}
}

 

Thanks for the help.

[Draco18s]

You can simplify this:

BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());

BlockPos pos0 = pos.up();

 

That said, what isn't working correctly?

[Durtle02]

In game nothing happens. The code should be working right?

 

[Draco18s]

In game nothing happens. The code should be working right?

 

For random ticks, you didn't specify that your block should receive random ticks).

For right-clicking, you have the wrong method signature (@Override would tell you this). You want

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ)

[Durtle02]

How do I specify for it to receive random ticks?

[Lambda]

In the constructor:

 

        this.setTickRandomly(true);

[Durtle02]

public GooBlock(String name){
        super(Material.ROCK, name);
        setTickRandomly(true);
        setHardness(0f);
        setResistance(1f);
    } 

 

It was in there. I tried adding the

this.

but it still didn't work.

[Animefan8888]

I believe they need to be scheduled.

world.scheduleBlockUpdate(pos, blockIn, delay, priority);

I would do it in onBlockPlaced and then in the update method itself when the first one happens.

[Draco18s]

I believe they need to be scheduled.

world.scheduleBlockUpdate(pos, blockIn, delay, priority);

I would do it in onBlockPlaced and then in the update method itself when the first one happens.

 

There are random update ticks. Look at BlockCrops.

Line 28, specifically.

[Animefan8888]

I believe they need to be scheduled.

world.scheduleBlockUpdate(pos, blockIn, delay, priority);

I would do it in onBlockPlaced and then in the update method itself when the first one happens.

 

There are random update ticks. Look at BlockCrops.

Line 28, specifically.

I thought they were the same thing, like you would schedule a random tick by scheduling it using Random#nextInt(...). Bu his other problem is a wrong method signature with updateTick it is Block#updateTick(World world, BlockPos pos, IBlockState state, Random rand)

[Durtle02]

Any ideas of what's wrong? None of the block changes are happening.

 

Current Code:

package TestMod.tutorial.block;

import javax.annotation.Nullable;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class GooBlock extends BlockBase{
    
    public GooBlock(String name){
        super(Material.ROCK, name);
        setTickRandomly(true);
        setHardness(0f);
        setResistance(1f);
    } 
    
    @Override
    public GooBlock setCreativeTab(CreativeTabs tab){
        super.setCreativeTab(tab);
        return this;
    }
    
    public void updateTick(World worldIn, BlockPos pos){
        BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());
        worldIn.setBlockState(pos0, ModBlocks.gooblock.getDefaultState());
    }

    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ){
        BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());
        worldIn.setBlockState(pos0, ModBlocks.gooblock.getDefaultState());
    return false;}
}

[Draco18s]

I thought they were the same thing, like you would schedule a random tick by scheduling it using Random#nextInt(...).

 

scheduled ticks are, by definition, not random.  You can use a random interval, but they are distinct from random update ticks, which are given to a fixed number of blocks in each chunk at random.

 

Any ideas of what's wrong? None of the block changes are happening.

 

Yes:

wrong method signature with updateTick it is Block#updateTick(World world, BlockPos pos, IBlockState state, Random rand)

 

Use @Override on every method that you are overriding. If Eclipse says "not valid, suggest remove" then you should fix the signature.  Eclipse can't suggest an alternate signature, its too complex of an operation.

[Durtle02]

So what does the @Override tell you? The random tick is working (Thank you) but the player activation still isn't.

@Override
    boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ){
        BlockPos pos0 = new BlockPos(pos.getX(), (pos.getY()+1) , pos.getZ());
        worldIn.setBlockState(pos0, ModBlocks.gooblock.getDefaultState());
    return false;}

It is okay with the code without the @Override but it doesn't like it with the override. (I'm using NetBeans 8.2)

[Jay Avery]

If it 'doesn't like it with the override', that means your IDE is telling you that you're not overriding correctly. Go to the superclass and find the method you want to override and copy the exact method signature to make sure it is correct.

[jeffryfisher]

It is okay with the code without the @Override but it doesn't like it with the override.

 

Stop for a moment and think about what that means... It is quiet without the assertion, but you hear about an error when you assert the truth about the method.

 

As the designer, you KNOW that a method is (supposed to) override an inherited method. Therefore, when your IDE suggests that you remove the annotation, you KNOW that it's bad advice (like "curing" a fever by removing that pesky thermometer -- all you accomplish is that you turn off the alert; you wouldn't be fixing the problem).

 

Now there are some methods that you are not allowed to override. If you are modding in unexplored territory, you might run into static and/or private (and maybe final?) methods. Then you need to get creative. However, onBlockActivated shouldn't be one of those.

 

Follow the advice above: Copy-paste the exact method header. You can then change parameter names if you like, but don't mess with the return type, qualifiers or parameter types.

 

And yes, every Java programmer should attach the @Override annotation to each and every method that's supposed be overriding an inherited method -- NO EXCEPTIONS. The first time you go through an upgrade exercise to a new MC release, you will thank your past self for pasting all those annotations where they assert the truth of your design (because they'll flag subtle inconsistencies created by vanilla code changes).