Jump to content

Recommended Posts

Posted

EDIT: Detailed

 

Hello,

 

So I have created a TE that uses 2 INPUTS for 1 OUTPUT, however, when I go to put the intended recipe in, the TE does not process it into the intended output, instead it sits and idles. What I want to have happen is for the TE to use BOTH inputs for 1 output.

 

Here is the TE:

 

 

package com.lambda.plentifulmisc.tile;

import com.lambda.plentifulmisc.recipe.AtomicDiffuserRecipes;
import com.lambda.plentifulmisc.util.StackUtil;
import com.lambda.plentifulmisc.util.misc.AtomicDiffuserRecipeRegistry;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EnumFacing;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import java.util.Stack;

/**
* Created by Blake on 11/26/2016.
*/
public class TileEntityAtomicDiffuser extends TileEntityInventoryBase implements ICustomEnergyReceiver {

    public static final int SLOT_INPUT_1 = 0;
    public static final int SLOT_INPUT_2 = 1;
    public static final int SLOT_OUTPUT_1 = 2;


    public static final int ENERGY_USE = 25;
    private static final int SMELT_TIME = 80;
    public final CustomEnergyStorage storage = new CustomEnergyStorage(50000, 80);
    public int firstSmeltTime;
    private int lastEnergy;
    private int lastFirstSmelt;

    public TileEntityAtomicDiffuser() {
        super(3, "atmoicdiffuser");
    }

    @Override
    public void writeSyncableNBT(NBTTagCompound compound, TileEntityBase.NBTType type){
        super.writeSyncableNBT(compound, type);
        if(type != TileEntityBase.NBTType.SAVE_BLOCK){
            compound.setInteger("FirstSmeltTime", this.firstSmeltTime);
        }
        this.storage.writeToNBT(compound);
    }

    @Override
    public void readSyncableNBT(NBTTagCompound compound, TileEntityBase.NBTType type){
        super.readSyncableNBT(compound, type);
        if(type != TileEntityBase.NBTType.SAVE_BLOCK){
            this.firstSmeltTime = compound.getInteger("FirstSmeltTime");
        }
        this.storage.readFromNBT(compound);
    }

    @Override
    public void updateEntity(){
        super.updateEntity();
        if(!this.worldObj.isRemote){

            boolean flag = this.firstSmeltTime > 0;

            boolean canSmeltOnFirst = this.canSmeltOn(SLOT_INPUT_1, SLOT_INPUT_2, SLOT_OUTPUT_1);

            if(canSmeltOnFirst){
                if(this.storage.getEnergyStored() >= ENERGY_USE){
                    this.firstSmeltTime++;
                    if(this.firstSmeltTime >= SMELT_TIME){
                        this.finishBurning(SLOT_INPUT_1, SLOT_INPUT_2, SLOT_OUTPUT_1);
                        this.firstSmeltTime = 0;
                    }
                    this.storage.extractEnergyInternal(ENERGY_USE, false);
                }
            }
            else{
                this.firstSmeltTime = 0;
            }

            if((this.lastEnergy != this.storage.getEnergyStored() || this.lastFirstSmelt != this.firstSmeltTime) && this.sendUpdateWithInterval()){
                this.lastEnergy = this.storage.getEnergyStored();
                this.lastFirstSmelt = this.firstSmeltTime;
            }

        }
    }

    @Override
    public boolean isItemValidForSlot(int i, ItemStack stack){
        return (i == SLOT_INPUT_1 || i == SLOT_INPUT_2) && AtomicDiffuserRecipeRegistry.getRecipeFromInput(stack, stack) != null;
    }

    public boolean canSmeltOn(int theInput, int theInputSecond, int theOutput){
        if(StackUtil.isValid(this.slots.get(theInput)) && StackUtil.isValid(this.slots.get(theInputSecond))){
            ItemStack output = AtomicDiffuserRecipeRegistry.getOutput(this.slots.get(theInput), this.slots.get(theInputSecond));
            if(StackUtil.isValid(output)){
                if(!StackUtil.isValid(this.slots.get(theOutput)) || (this.slots.get(theOutput).isItemEqual(output) && StackUtil.getStackSize(this.slots.get(theOutput)) <= this.slots.get(theOutput).getMaxStackSize()-StackUtil.getStackSize(output))){
                    return true;
                }
            }

        }
        return false;
    }

    public void finishBurning(int theInput, int theInputSecond, int theOutput){
        ItemStack output = AtomicDiffuserRecipeRegistry.getOutput(this.slots.get(theInput), this.slots.get(theInputSecond));
        if(!StackUtil.isValid(this.slots.get(theOutput))){
            this.slots.set(theOutput, output.copy());
        }
        else if(this.slots.get(theOutput).getItem() == output.getItem()){
            this.slots.set(theOutput, StackUtil.addStackSize(this.slots.get(theOutput), StackUtil.getStackSize(output)));
        }

        this.slots.set(theInput, StackUtil.addStackSize(this.slots.get(theInput), -1));
        this.slots.set(theInputSecond, StackUtil.addStackSize(this.slots.get(theInputSecond), -1));
    }

    @SideOnly(Side.CLIENT)
    public int getFirstTimeToScale(int i){
        return this.firstSmeltTime*i/SMELT_TIME;
    }

    @Override
    public boolean canInsertItem(int slot, ItemStack stack, EnumFacing side){
        return this.isItemValidForSlot(slot, stack);
    }

    @Override
    public boolean canExtractItem(int slot, ItemStack stack, EnumFacing side){
        return slot == SLOT_OUTPUT_1;
    }

    @Override
    public int receiveEnergy(EnumFacing from, int maxReceive, boolean simulate){
        return this.storage.receiveEnergy(maxReceive, simulate);
    }

    @Override
    public int getEnergyStored(EnumFacing from){
        return this.storage.getEnergyStored();
    }

    @Override
    public int getMaxEnergyStored(EnumFacing from){
        return this.storage.getMaxEnergyStored();
    }

    @Override
    public boolean canConnectEnergy(EnumFacing from){
        return true;
    }


}


 

 

Container:

 

 

package com.lambda.plentifulmisc.inventory;

/**
* Created by Blake on 11/26/2016.
*/
import com.lambda.plentifulmisc.inventory.slot.SlotOutput;
import com.lambda.plentifulmisc.tile.TileEntityAtomicDiffuser;
import com.lambda.plentifulmisc.tile.TileEntityBase;
import com.lambda.plentifulmisc.util.StackUtil;
import com.lambda.plentifulmisc.util.misc.AtomicDiffuserRecipeRegistry;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;


public class ContainerAtomicDiffuser extends Container{

    public final TileEntityAtomicDiffuser tileAtomic;


    public ContainerAtomicDiffuser(InventoryPlayer inventory, TileEntityBase tile){
        this.tileAtomic = (TileEntityAtomicDiffuser)tile;

        this.addSlotToContainer(new Slot(this.tileAtomic, TileEntityAtomicDiffuser.SLOT_INPUT_1, 80, 21));
        this.addSlotToContainer(new Slot(this.tileAtomic, TileEntityAtomicDiffuser.SLOT_INPUT_2, 66, 69));
        this.addSlotToContainer(new SlotOutput(this.tileAtomic, TileEntityAtomicDiffuser.SLOT_OUTPUT_1, 92, 69));


        for(int i = 0; i < 3; i++){
            for(int j = 0; j < 9; j++){
                this.addSlotToContainer(new Slot(inventory, j+i*9+9, 8+j*18, 97+i*18));
            }
        }
        for(int i = 0; i < 9; i++){
            this.addSlotToContainer(new Slot(inventory, i, 8+i*18, 155));
        }
    }

    @Override
    public ItemStack transferStackInSlot(EntityPlayer player, int slot){
        int inventoryStart = 3;
        int inventoryEnd = inventoryStart+26;
        int hotbarStart = inventoryEnd+1;
        int hotbarEnd = hotbarStart+8;

        Slot theSlot = this.inventorySlots.get(slot);

        if(theSlot != null && theSlot.getHasStack()){
            ItemStack newStack = theSlot.getStack();
            ItemStack otherNewSlot = theSlot.getStack();
            ItemStack currentStack = newStack.copy();

            //Slots in Inventory to shift from
            if(slot == TileEntityAtomicDiffuser.SLOT_OUTPUT_1){
                if(!this.mergeItemStack(newStack, inventoryStart, hotbarEnd+1, true)){
                    return StackUtil.getNull();
                }
                theSlot.onSlotChange(newStack, currentStack);
            }
            //Other Slots in Inventory excluded
            else if(slot >= inventoryStart){
                //Shift from Inventory
                if(AtomicDiffuserRecipeRegistry.getRecipeFromInput(newStack, otherNewSlot) != null){
                    if(!this.mergeItemStack(newStack, TileEntityAtomicDiffuser.SLOT_INPUT_1, TileEntityAtomicDiffuser.SLOT_INPUT_1+1, false)){
                            return StackUtil.getNull();
                        }
                    }
                //

                else if(slot >= inventoryStart && slot <= inventoryEnd){
                    if(!this.mergeItemStack(newStack, hotbarStart, hotbarEnd+1, false)){
                        return StackUtil.getNull();
                    }
                }
                else if(slot >= inventoryEnd+1 && slot < hotbarEnd+1 && !this.mergeItemStack(newStack, inventoryStart, inventoryEnd+1, false)){
                    return StackUtil.getNull();
                }
            }
            else if(!this.mergeItemStack(newStack, inventoryStart, hotbarEnd+1, false)){
                return StackUtil.getNull();
            }

            if(!StackUtil.isValid(newStack)){
                theSlot.putStack(StackUtil.getNull());
            }
            else{
                theSlot.onSlotChanged();
            }

            if(StackUtil.getStackSize(newStack) == StackUtil.getStackSize(currentStack)){
                return StackUtil.getNull();
            }
            theSlot.func_190901_a(player, newStack);


            return currentStack;
        }
        return StackUtil.getNull();
    }

    @Override
    public boolean canInteractWith(EntityPlayer player){
        return this.tileAtomic.isUseableByPlayer(player);
    }
}

 

 

 

RecipeRegistry:

public class AtomicDiffuserRecipeRegistry {

        public static void registerFinally(){
            int recipeStartedAt = PlentifulMiscAPI.ATOMIC_RECIPES.size();

            ArrayList<String> addedRecipes = new ArrayList<String>();
            for(int i = recipeStartedAt; i < PlentifulMiscAPI.ATOMIC_RECIPES.size(); i++){
                AtomicDiffuserRecipe recipe = PlentifulMiscAPI.ATOMIC_RECIPES.get(i);
                addedRecipes.add(recipe.firstInput+"+"+recipe.secondInput+" -> "+recipe.output);
            }
            ModUtil.LOGGER.info("Added "+addedRecipes.size()+" Atomic Recipes automatically: "+addedRecipes);
        }
/*
        public static boolean hasBlacklistedOutput(ItemStack output, String[] config){
            if(StackUtil.isValid(output)){
                Item item = output.getItem();
                if(item != null){
                    String reg = item.getRegistryName().toString();

                    for(String conf : config){
                        String confReg = conf;
                        int meta = 0;

                        if(conf.contains("@")){
                            try{
                                String[] split = conf.split("@");
                                confReg = split[0];
                                meta = Integer.parseInt(split[1]);
                            }
                            catch(Exception e){
                                ModUtil.LOGGER.warn("A config option appears to be incorrect: The entry "+conf+" can't be parsed!");
                            }
                        }

                        if(reg.equals(confReg) && output.getItemDamage() == meta){
                            return true;
                        }
                    }

                    return false;
                }
            }
            return true;
        }
*/
        private static boolean hasException(String ore){
            for(String conf : ConfigStringListValues.ATOMIC_RECIPE_EXCEPTIONS.getValue()){
                if(conf.equals(ore)){
                    return true;
                }
            }
            return false;
        }

        public static ItemStack getOutput(ItemStack input, ItemStack inputSecond){
            AtomicDiffuserRecipe recipe = getRecipeFromInput(input, inputSecond);
            return recipe == null ? null : recipe.output;
        }

        public static AtomicDiffuserRecipe getRecipeFromInput(ItemStack input, ItemStack secondInput){
            for(AtomicDiffuserRecipe recipe : PlentifulMiscAPI.ATOMIC_RECIPES){
                if(ItemUtil.areItemsEqual(recipe.firstInput, input, true) && ItemUtil.areItemsEqual(recipe.secondInput, secondInput, true)){
                    return recipe;
                }
            }
            return null;
        }
}

 

Recipes:

public final class AtomicDiffuserRecipes {

    public static final ArrayList<AtomicDiffuserRecipe> MISC_RECIPES = new ArrayList<AtomicDiffuserRecipe>();
    public void init() {

        ModUtil.LOGGER.info("Initializing Atomic Diffuser Recipes...");

        PlentifulMiscAPI.addAtomicRecipe(new ItemStack(Items.BONE), new ItemStack(Items.STICK), new ItemStack(Items.APPLE));
        MISC_RECIPES.add(RecipeUtil.lastAtomicRecipe());

        AtomicDiffuserRecipeRegistry.registerFinally();
    }
}

 

Main API:

public final class PlentifulMiscAPI{

    public static final String MOD_ID = "plentifulmisc";
    public static final String API_ID = MOD_ID+"api";
    public static final String API_VERSION = "1";

    public static IMethodHandler methodHandler;

    public static IRelayConnectionHandler connectionHandler;

    public static final List<AtomicDiffuserRecipe> ATOMIC_RECIPES = new ArrayList<AtomicDiffuserRecipe>();

    public static void addAtomicRecipe(ItemStack firstInput, ItemStack secondInput, ItemStack output){
        ATOMIC_RECIPES.add(new AtomicDiffuserRecipe(firstInput, secondInput, output));
    }

    public static boolean addAtomicRecipes(List<ItemStack> firstInput, List<ItemStack> secondInput, List<ItemStack> output)
    {
        return methodHandler.addAtomicRecipes(firstInput, secondInput, output);
    }

}

 

Recipe:

public class AtomicDiffuserRecipe {

    public ItemStack firstInput;
    public ItemStack secondInput;
    public ItemStack output;

    public AtomicDiffuserRecipe(ItemStack firstInput, ItemStack secondInput, ItemStack output) {
        this.firstInput = firstInput;
        this.secondInput = secondInput;
        this.output = output;
    }
}

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Posted

Hi Lambda

I'm running into some issues with the crafting handler and such

In order to help you, we really need a more detailed description of the problems you're having :)

 

ie.

What you expect to happen

vs

What actually happens (detailed symptoms, error logs, etc).

 

-TGG

Posted

Post your ItemUtil.areItemsEqual method.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  public static boolean areItemsEqual(ItemStack stack1, ItemStack stack2, boolean checkWildcard){
        return StackUtil.isValid(stack1) && StackUtil.isValid(stack2) && (stack1.isItemEqual(stack2) || (checkWildcard && stack1.getItem() == stack2.getItem() && (stack1.getItemDamage() == UtilBase.WILDCARD || stack2.getItemDamage() == UtilBase.WILDCARD)));
    }

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Posted

Hmm.

You might have to step through in the debugger.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Put a breakpoint on the canSmeltOn method, and step through line by line to figure out why it's not getting a result.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Just got into Intellj, would you know how to add breakpoints, google search shows ALT+INS but that isnt working :/

 

Click on the margin between the line numbers and the code.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

But the breakpoint not next to the method name, but next to the first line of code after the method.

Method breakpoints are extremely sluggish.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to create block with entity, that will have height of 3 or more(configurable) and I tried to change first VoxelShape by increasing collision box on height I want and for changing block height on visual side i tried to configure BlockModelBuilder:  base.element() .from(0, 0, 0) .to(16f, 48f, 16f) .face(Direction.UP).texture("#top").end() .face(Direction.DOWN).texture("#bottom").end() .face(Direction.NORTH).texture("#side").end() .face(Direction.SOUTH).texture("#side").end() .face(Direction.WEST).texture("#side").end() .face(Direction.EAST).texture("#side").end() .end(); but, getting crash with next error: Position y out of range, must be within [-16, 32]. Found: %d [48.0]; Looks like game wont to block height modified by more than 32. Is there any way to fix that problem?
    • As long as the packets you are sending aren't lost, there's nothing wrong with what you're currently doing. Although, this sounds like something that would benefit from you making your own datapack registry instead of trying to arbitrarily sync static maps. Check out `DataPackRegistryEvent.NewRegistry`.
    • Hey all, I've been working a lot with datapacks lately, and I'm wondering what the most efficient way to get said data from server to client is.  I'm currently using packets, but given that a lot of the data I'm storing involves maps along the lines of Map<ResourceLocation, CustomDataType>, it can easily start to get messy if I need to transmit a lot of that data all at once. Recently I started looking into the ReloadableServerResources class, which is where Minecraft stores its built-ins.  I see you can access it via the server from the server's resources.managers, and it seems like this can be done even from the client to appropriately retrieve data from the server, unless I'm misunderstanding.  However, from what I can tell, this only works via built-in methods such as getRecipeManager() or getLootTables(), etc.  These are all SimpleJsonResourceReloadListeners, just like my datapack entries are, so it seems like it could be possible for me to access my datapack entries similarly?  But I don't see anywhere in ReloadableServerResources that stores loaded modded entries, so either I'm looking in the wrong place or it doesn't seem to be a thing. Are packets really the best way of doing this, or am I missing a method that would let me use ReloadableServerResources or something similar?
    • Hi, everyone! I'm new to minecraft modding stuff and want ask you some questions. 1. I checked forge references and saw there com.mojang and net.minecraft (not net.minecraftforge) and as I understand it's original game packages with all minecraft logic inside including renderers and so on, right? 2. Does it mean that forge has a limited set of instruments which doesn't cover all the aspects of the game? If make my question more specific then does forge provide such instruments that allow me totally change minecraft itself, like base mechanics and etc.? Or I have to use "original game packages" to implement such things? 3. I actively learning basic concepts with forge documentation and tutorials. So in my plans make different inventory system like in diabloids. Is that possible with forge? 4. It is last question related to the second one. So how deeply I can change minecraft with forge? I guess all my questions above because of that I haven't globally understanding what forge is and how it works inside and how it works with minecraft. It would be great if you provide some links or topics about it or explain it by yourself but I guess it's to big to be explained in that post at once. Anyway, thank you all for any help!
    • Im trying add to block a hole in center, just a usual block and in center of it on up side, there is should be a hole. I tried to add it via BlockModelBuilder, but its not working. Problem is that it only can change block size outside. I tried it to do with VoxelShape and its working, but its has been on server side and looks like its just changed collision shape, but for client, there is a texture covering this hole. I tried to use: base.renderType("cutout"); and removed some pixels from texture. I thought its should work, but game optimization makes block inside looks transparent. So, only custom model?
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.