[1.10.2] Open Book GUI

[JimiIT92]

I'm trying to make a lectern so players can place a book in it and open its GUI when right click the block. But unfortunately the GUI doesn't show up when the player right click the block. This is the block code i'm using

package com.mineworld.blocks.decorations;

import com.mineworld.core.MWTabs;
import com.mineworld.tileentity.decorations.TileEntityLectern;
import com.mineworld.tileentity.decorations.TileEntityWeaponRack;

import net.minecraft.block.BlockHorizontal;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.item.ItemWrittenBook;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.Mirror;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockLectern extends BlockHorizontal implements ITileEntityProvider {

public BlockLectern() {
	super(Material.WOOD);
	this.setHardness(2.0F);
	this.setSoundType(SoundType.WOOD);
	this.setCreativeTab(MWTabs.tabDecorations);
	this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));
}

public IBlockState withRotation(IBlockState state, Rotation rot) {
	return state.withProperty(FACING, rot.rotate((EnumFacing) state.getValue(FACING)));
}

/**
 * Returns the blockstate with the given mirror of the passed blockstate. If
 * inapplicable, returns the passed blockstate.
 */
public IBlockState withMirror(IBlockState state, Mirror mirrorIn) {
	return state.withRotation(mirrorIn.toRotation((EnumFacing) state.getValue(FACING)));
}

/**
 * Called by ItemBlocks just before a block is actually set in the world, to
 * allow for adjustments to the IBlockstate
 */
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ,
		int meta, EntityLivingBase placer) {
	return this.getDefaultState().withProperty(FACING, placer.getHorizontalFacing());
}

/**
 * Convert the given metadata into a BlockState for this Block
 */
public IBlockState getStateFromMeta(int meta) {
	return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
}

/**
 * Convert the BlockState into the correct metadata value
 */
public int getMetaFromState(IBlockState state) {
	return ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();
}

protected BlockStateContainer createBlockState() {
	return new BlockStateContainer(this, new IProperty[] { FACING });
}

@Override
public boolean isOpaqueCube(IBlockState state) {
	return false;
}

@Override
public boolean isFullCube(IBlockState state) {
	return false;
}

@Override
public TileEntity createNewTileEntity(World worldIn, int meta) {
	return new TileEntityLectern();
}

@Override
public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,
		EnumHand hand, ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
	if (!worldIn.isRemote) {
		TileEntity te = worldIn.getTileEntity(pos);
		if (te instanceof TileEntityLectern) {
			TileEntityLectern wr = (TileEntityLectern) te;
			if (heldItem != null && heldItem.getItem() != null && heldItem.getItem() instanceof ItemWrittenBook) {
				if (wr.addItem(heldItem)) {
					playerIn.inventory.removeStackFromSlot(playerIn.inventory.currentItem);
					return true;
				}
			}
			if(playerIn.isSneaking())
				wr.removeItem();
			else {
				if(wr.item != null) {
					playerIn.openBook(wr.item, hand);
				}
			}

		}
	}
	return true;
}

public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
	TileEntity tileentity = worldIn.getTileEntity(pos);

	if (tileentity instanceof TileEntityLectern) {
		((TileEntityLectern) tileentity).removeItem();
	}

	super.breakBlock(worldIn, pos, state);
}

}

 

I'm sure the book is correctly saved into the tile entity because i can remove the book from the block if i shift-click it. So why the GUI doesn't open?

[Animefan8888]

Post your TE code.

[JimiIT92]

Here it is

package com.mineworld.tileentity.decorations;

import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;

public class TileEntityLectern extends TileEntity {

public ItemStack item = null;
public boolean render = false;

public boolean addItem(ItemStack item) {
	if (this.item == null) {
		this.item = item;
		this.render = true;
		markDirty();
		IBlockState state = worldObj.getBlockState(pos);
		worldObj.notifyBlockUpdate(pos, state, state, 3);
		return true;
	}

	return false;
}

public void removeItem() {
	if (this.item != null) {
		worldObj.spawnEntityInWorld(
			new EntityItem(worldObj, pos.getX() + 0.5, pos.getY() + 1, pos.getZ() + 0.5, this.item));
		this.item = null;
		this.render = false;
		markDirty();
		IBlockState state = worldObj.getBlockState(pos);
		worldObj.notifyBlockUpdate(pos, state, state, 3);
		return;
	}

}

public void readFromNBT(NBTTagCompound compound) {
	super.readFromNBT(compound);

	NBTTagList nbttaglist = compound.getTagList("Items", 10);

	for (int i = 0; i < nbttaglist.tagCount(); ++i) {
		NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i);
		int j = nbttagcompound.getByte("Item") & 255;

		this.item = ItemStack.loadItemStackFromNBT(nbttagcompound);
	}

	this.render = compound.getBoolean("render");
}

public NBTTagCompound writeToNBT(NBTTagCompound compound) {
	super.writeToNBT(compound);

	NBTTagList nbttaglist = new NBTTagList();
	NBTTagCompound nbttagcompound = new NBTTagCompound();
	if (this.item != null) {
		nbttagcompound.setByte("Item", (byte) 1);
		this.item.writeToNBT(nbttagcompound);

		nbttaglist.appendTag(nbttagcompound);
	}

	compound.setTag("Items", nbttaglist);
	compound.setBoolean("render", this.render);
	return compound;
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
	NBTTagCompound compound = pkt.getNbtCompound();
	readUpdateTag(compound);
}

@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	NBTTagCompound tagCom = new NBTTagCompound();
	this.writeUpdateTag(tagCom);
	return new SPacketUpdateTileEntity(pos, getBlockMetadata(), tagCom);
}

@Override
public NBTTagCompound getUpdateTag() {
	NBTTagCompound tag = super.getUpdateTag();
	writeUpdateTag(tag);
	return tag;
}

public void writeUpdateTag(NBTTagCompound tag) {
	NBTTagList nbttaglist = new NBTTagList();
	NBTTagCompound nbttagcompound = new NBTTagCompound();
	if (this.item != null) {
		nbttagcompound.setByte("Item", (byte) 1);
		this.item.writeToNBT(nbttagcompound);
		nbttaglist.appendTag(nbttagcompound);
	}

	tag.setTag("Items", nbttaglist);

	tag.setBoolean("render", this.render);
}

public void readUpdateTag(NBTTagCompound tag) {
	NBTTagList nbttaglist = tag.getTagList("Items", 10);

	for (int i = 0; i < nbttaglist.tagCount(); ++i) {
		NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i);
		int j = nbttagcompound.getByte("Item") & 255;
		this.item = ItemStack.loadItemStackFromNBT(nbttagcompound);

	}

	this.render = tag.getBoolean("render");
}

}

[Draco18s]

By the way you don't need both of these checks:

heldItem != null && heldItem.getItem() != null

The first one is sufficient, you will never have a non-null item stack of a null item.

 

Also, don't use ITileentityProvider, you should override the hasTileEntity and getTileEntity methods that are present in the Block class (which have a different signature).

[JimiIT92]

Ok, so i changed my class to this

package com.mineworld.blocks.decorations;

import com.mineworld.core.MWTabs;
import com.mineworld.tileentity.decorations.TileEntityLectern;
import com.mineworld.tileentity.decorations.TileEntityWeaponRack;

import net.minecraft.block.BlockContainer;
import net.minecraft.block.BlockHorizontal;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.item.ItemWrittenBook;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.Mirror;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockLectern extends BlockContainer{

public static final PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);

public BlockLectern() {
	super(Material.WOOD);
	this.setHardness(2.0F);
	this.setSoundType(SoundType.WOOD);
	this.setCreativeTab(MWTabs.tabDecorations);
	this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));
}

public IBlockState withRotation(IBlockState state, Rotation rot) {
	return state.withProperty(FACING, rot.rotate((EnumFacing) state.getValue(FACING)));
}

/**
 * Returns the blockstate with the given mirror of the passed blockstate. If
 * inapplicable, returns the passed blockstate.
 */
public IBlockState withMirror(IBlockState state, Mirror mirrorIn) {
	return state.withRotation(mirrorIn.toRotation((EnumFacing) state.getValue(FACING)));
}

/**
 * Called by ItemBlocks just before a block is actually set in the world, to
 * allow for adjustments to the IBlockstate
 */
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ,
		int meta, EntityLivingBase placer) {
	return this.getDefaultState().withProperty(FACING, placer.getHorizontalFacing());
}

/**
 * Convert the given metadata into a BlockState for this Block
 */
public IBlockState getStateFromMeta(int meta) {
	return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
}

/**
 * Convert the BlockState into the correct metadata value
 */
public int getMetaFromState(IBlockState state) {
	return ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();
}

protected BlockStateContainer createBlockState() {
	return new BlockStateContainer(this, new IProperty[] { FACING });
}

@Override
public boolean isOpaqueCube(IBlockState state) {
	return false;
}

@Override
public boolean isFullCube(IBlockState state) {
	return false;
}

@Override
public boolean hasTileEntity() {
	return true;
}

@Override
public TileEntity createNewTileEntity(World world, int state) {
	return new TileEntityLectern();
}

@Override
public EnumBlockRenderType getRenderType(IBlockState state) {
	return EnumBlockRenderType.MODEL;
}

@Override
public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,
		EnumHand hand, ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
	if (!worldIn.isRemote) {
		TileEntity te = worldIn.getTileEntity(pos);
		if (te instanceof TileEntityLectern) {
			TileEntityLectern wr = (TileEntityLectern) te;
			if (heldItem != null && heldItem.getItem() instanceof ItemWrittenBook) {
				if (wr.addItem(heldItem)) {
					playerIn.inventory.removeStackFromSlot(playerIn.inventory.currentItem);
					return true;
				}
			}
			if(playerIn.isSneaking())
				wr.removeItem();
			else {
				if(wr.item != null) {
					playerIn.openBook(wr.item, hand);
				}
			}

		}
	}
	return true;
}

public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
	TileEntity tileentity = worldIn.getTileEntity(pos);

	if (tileentity instanceof TileEntityLectern) {
		((TileEntityLectern) tileentity).removeItem();
	}

	super.breakBlock(worldIn, pos, state);
}

}

 

But still the book GUI doesn't show up

[Draco18s]

BlockContainer implements ITileEntityProvider:

 

Also, don't use ITileentityProvider, you should override the hasTileEntity and getTileEntity methods that are present in the Block class (which have a different signature).

[JimiIT92]

Wops, ok so now the block class extends blocks and uses the Block.class methods for the tile entity

package com.mineworld.blocks.decorations;

import com.mineworld.core.MWTabs;
import com.mineworld.tileentity.decorations.TileEntityLectern;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemWrittenBook;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.Mirror;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockLectern extends Block{

public static final PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);

public BlockLectern() {
	super(Material.WOOD);
	this.setHardness(2.0F);
	this.setSoundType(SoundType.WOOD);
	this.setCreativeTab(MWTabs.tabDecorations);
	this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));
}

public IBlockState withRotation(IBlockState state, Rotation rot) {
	return state.withProperty(FACING, rot.rotate((EnumFacing) state.getValue(FACING)));
}

/**
 * Returns the blockstate with the given mirror of the passed blockstate. If
 * inapplicable, returns the passed blockstate.
 */
public IBlockState withMirror(IBlockState state, Mirror mirrorIn) {
	return state.withRotation(mirrorIn.toRotation((EnumFacing) state.getValue(FACING)));
}

/**
 * Called by ItemBlocks just before a block is actually set in the world, to
 * allow for adjustments to the IBlockstate
 */
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ,
		int meta, EntityLivingBase placer) {
	return this.getDefaultState().withProperty(FACING, placer.getHorizontalFacing());
}

/**
 * Convert the given metadata into a BlockState for this Block
 */
public IBlockState getStateFromMeta(int meta) {
	return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
}

/**
 * Convert the BlockState into the correct metadata value
 */
public int getMetaFromState(IBlockState state) {
	return ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();
}

protected BlockStateContainer createBlockState() {
	return new BlockStateContainer(this, new IProperty[] { FACING });
}

@Override
public boolean isOpaqueCube(IBlockState state) {
	return false;
}

@Override
public boolean isFullCube(IBlockState state) {
	return false;
}

@Override
public boolean hasTileEntity(IBlockState state) {
	return true;
}

@Override
public TileEntity createTileEntity(World world, IBlockState state) {
	return new TileEntityLectern();
}


@Override
public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,
		EnumHand hand, ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
	if (!worldIn.isRemote) {
		TileEntity te = worldIn.getTileEntity(pos);
		if (te instanceof TileEntityLectern) {
			TileEntityLectern wr = (TileEntityLectern) te;
			if (heldItem != null && heldItem.getItem() instanceof ItemWrittenBook) {
				if (wr.addItem(heldItem)) {
					playerIn.inventory.removeStackFromSlot(playerIn.inventory.currentItem);
					return true;
				}
			}
			if(playerIn.isSneaking())
				wr.removeItem();
			else {
				if(wr.item != null) {
					playerIn.openBook(wr.item, hand);
				}
			}

		}
	}
	return true;
}

public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
	TileEntity tileentity = worldIn.getTileEntity(pos);

	if (tileentity instanceof TileEntityLectern) {
		((TileEntityLectern) tileentity).removeItem();
	}

	super.breakBlock(worldIn, pos, state);
}

}

 

But the behavior is not changed, i can still put a book in it, get it back if i shift click but if i right click it won't open the book gui of the book stored in it (wich i assume is correctly stored since i can get it back)

[Draco18s]

The ITileEntityProvider thing was not actually related to your problem, it was getting your class to use the more up to date method of having a TE.

 

My only suggestion is to use your debugger to step through your code and see what is not being called and why.

[JimiIT92]

So debugging looks like client side the game check if the book is a writable book (not a written one) and so the GUI doesn't show up. By adding this

Minecraft.getMinecraft().displayGuiScreen(new GuiScreenBook(playerIn, wr.item, false));

to the block code i can now show the GUI. But i'm confused on why the client check for a writable book if that code is called from the ItemWrittenBook