Hey there,

 

So I'm looking for a way to detect when a certain TE is broken.

 

I need it so that when the TE is broken, remove it from a list. Here is what I current have:

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.print(standsAround.size());
        if(!worldObj.isRemote) {
            for (EnumFacing facing : EnumFacing.HORIZONTALS) {
                for(int i = 0; i < maxSearchRange; i++) {
                    BlockPos pos = getPos().offset(facing, i);
                    TileEntity te = worldObj.getTileEntity(pos);
                    if (te instanceof TileEntityStand) {
                            standsAround.add(te);
                    }
                    if(i >= maxSearchRange) {
                        return;
                    }
                }
            }

        }


    }

 

Thanks,

Okay, I have a 'updateWithInverval' built in with my BaseTile so will switch to that..

 

Okay, I have switched to a

WeakHashMap

, and it seems to work okay, however, still wont remove from the list.

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.print(standsAround.size());
        if(!worldObj.isRemote && sendUpdateWithInterval()) {
            for (EnumFacing facing : EnumFacing.HORIZONTALS) {
                for(int i = 0; i < maxSearchRange; i++) {
                    BlockPos pos = getPos().offset(facing, i);
                    TileEntity te = worldObj.getTileEntity(pos);
                    if (te instanceof TileEntityStand) {
                        if(!te.isInvalid()) {
                            standsAround.put(te, pos);
                        }
                        else {
                            standsAround.remove(te);
                        }
                    }
                    if(i >= maxSearchRange) {
                        return;
                    }
                }
            }

        }


    }

 

 

Ah sorry:

 

Still won't remove from the list.

Ah sorry:

 

Still won't remove from the list.

Your code won't work because you are checking to see if the worlds version of the te is invalid. Really the simplest way to do this would be to loop through like you are, but without the invalid check and only add. (Side note why do you need a map? The TE stores its BlockPos). Once you have added them check through the currently a map for TEs that are invalid. Or check if the TE still exists in the World by doing World#getTileEntity(listTE.getPos()) != null. Or similar.

So something like this?

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.print(standsAround.size());
        if (!worldObj.isRemote && sendUpdateChecksWithInterval()) {
            for (EnumFacing facing : EnumFacing.HORIZONTALS) {
                for (int i = 0; i < maxSearchRange; i++) {
                    BlockPos pos = getPos().offset(facing, i);
                    TileEntity te = worldObj.getTileEntity(pos);
                    if (te instanceof TileEntityStand) {
                        this.standsAround.add(te);
                    }
                    if (i >= maxSearchRange) {
                        return;
                    }
                }
            }
            validateTEs();
        }

    }

    public void validateTEs() {
        for(int i = 0; i < standsAround.size(); i++) {
            TileEntity te = standsAround.get(i);
            if(te.getPos() == null) {
                standsAround.remove(te);
            }else {
                return;
            }

            if(i >= standsAround.size()) {
                return;
            }
        }
    }

 

Edit:

 

Oh and my list being:

    public final List<TileEntity> standsAround = new ArrayList<TileEntity>();

So something like this?

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.print(standsAround.size());
        if (!worldObj.isRemote && sendUpdateChecksWithInterval()) {
            for (EnumFacing facing : EnumFacing.HORIZONTALS) {
                for (int i = 0; i < maxSearchRange; i++) {
                    BlockPos pos = getPos().offset(facing, i);
                    TileEntity te = worldObj.getTileEntity(pos);
                    if (te instanceof TileEntityStand) {
                        this.standsAround.add(te);
                    }
                    if (i >= maxSearchRange) {
                        return;
                    }
                }
            }
            validateTEs();
        }

    }

    public void validateTEs() {
        for(int i = 0; i < standsAround.size(); i++) {
            TileEntity te = standsAround.get(i);
            if(te.getPos() == null) {
                standsAround.remove(te);
            }else {
                return;
            }

            if(i >= standsAround.size()) {
                return;
            }
        }
    }

 

Edit:

 

Oh and my list being:

    public final List<TileEntity> standsAround = new ArrayList<TileEntity>();

Close but in your validate method call worldObj.getTileEntity(te.getPos()) == null instead of if the pos is null.

Yeah that seemed to work, however, would you know how I'd get rid of duplicates? So the size isnt something crazy. just 1,2,3,4?

Yeah that seemed to work, however, would you know how I'd get rid of duplicates? So the size isnt something crazy. just 1,2,3,4?

Compare blockpos of the TEs.

Some more ideas

 

you could build built-in-obsolescence in your TEs so they don't become rogue.

Every so often check if they are still attached to a block. If the block is gone make it self destruct.

 

I tell my blocks to always kill their own TE just before they get destroyed.

I tell my blocks to always kill their own TE just before they get destroyed.

 

...You know that vanilla already does that for you, right?

 

    public void breakBlock(World worldIn, BlockPos pos, IBlockState state)
    {
        if (hasTileEntity(state) && !(this instanceof BlockContainer))
        {
            worldIn.removeTileEntity(pos);
        }
    }

I tell my blocks to always kill their own TE just before they get destroyed.

 

...You know that vanilla already does that for you, right?

 

    public void breakBlock(World worldIn, BlockPos pos, IBlockState state)
    {
        if (hasTileEntity(state) && !(this instanceof BlockContainer))
        {
            worldIn.removeTileEntity(pos);
        }
    }

 

How would I get another instance of a te to compare it to?

World#getTileEntity(BlockPos)

Yes I know that, I need to be able to grab another te and check their blockpos

Well, every

TileEntity

has a

getPos()

method which you can use.

How would I get two of the TEs from the list and compare them, thats my question

Instead of checking for duplicates when reading the values, check for duplicated when adding them to the

List

. There's

List<T>#contains(T)

which returns true if

T

is already in the

List<T>

.

Ah! That seemed to work, Thanks!