Mopop Posted December 18, 2016 Posted December 18, 2016 I want creepers and other monsters that don't normally burn at daylight to burn. I see the code in the EntityZombie and figured I could use this and rewrite it or to possible just add it into the existing creature code? Or would I better off just making a "custom" mob? public void onLivingUpdate() { if (this.worldObj.isDaytime() && !this.worldObj.isRemote && !this.isChild() && this.func_190730_o()) { float f = this.getBrightness(1.0F); if (f > 0.5F && this.rand.nextFloat() * 30.0F < (f - 0.4F) * 2.0F && this.worldObj.canSeeSky(new BlockPos(this.posX, this.posY + (double)this.getEyeHeight(), this.posZ))) { boolean flag = true; ItemStack itemstack = this.getItemStackFromSlot(EntityEquipmentSlot.HEAD); if (!itemstack.func_190926_b()) { if (itemstack.isItemStackDamageable()) { itemstack.setItemDamage(itemstack.getItemDamage() + this.rand.nextInt(2)); if (itemstack.getItemDamage() >= itemstack.getMaxDamage()) { this.renderBrokenItemStack(itemstack); this.setItemStackToSlot(EntityEquipmentSlot.HEAD, ItemStack.field_190927_a); } } flag = false; } if (flag) { this.setFire(; } } } super.onLivingUpdate(); } Quote
Draco18s Posted December 18, 2016 Posted December 18, 2016 I want creepers and other monsters that don't normally burn at daylight to burn. I see the code in the EntityZombie and figured I could use this and rewrite it or to possible just add it into the existing creature code? Or would I better off just making a "custom" mob? You can't just rewrite existing methods or add methods to existing classes. And creating a custom mob won't really solve your problem either. What you should do is subscribe to the LivingUpdateEvent and use the zombie code to set other mobs on fire. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Mopop Posted December 18, 2016 Author Posted December 18, 2016 Okay cool I almost have it all re-written and ready to go but I'm not sure what this line means? And what it wants. super.onLivingUpdate(); Once I have that figured out I can test it out. Quote
Mopop Posted December 18, 2016 Author Posted December 18, 2016 Well I'm going to head to bed. I have it working, but it keeps burning NPCs and Players. Is there a simple way of just checking what entity is what? Quote
Lambda Posted December 18, 2016 Posted December 18, 2016 instanceof might work. Quote Relatively new to modding. Currently developing: https://github.com/LambdaXV/DynamicGenerators
Draco18s Posted December 18, 2016 Posted December 18, 2016 Okay cool I almost have it all re-written and ready to go but I'm not sure what this line means? And what it wants. super.onLivingUpdate(); Once I have that figured out I can test it out. Ignore it. You aren't writing a method override in a subclass, so you don't need it. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Mopop Posted December 19, 2016 Author Posted December 19, 2016 Cool, it all seems to work when I run it in debug mode. As soon as I jar it and put it into a live game it crashes when the world loads. ava.lang.NoSuchMethodError: net.minecraft.client.Minecraft.getMinecraft()Lnet/minecraft/client/Minecraft; at com.example.examplemod.burningmobs.BurnMobs(burningmobs.java:39) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_burningmobs_BurnMobs_LivingUpdateEvent.invoke(.dynamic) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) at net.minecraftforge.common.ForgeHooks.onLivingUpdate(ForgeHooks.java:524) at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2000) at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:232) at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:303) at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:164) at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:215) at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287) at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624) at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:149) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) at java.lang.Thread.run(Thread.java:745) This is line 39 (Along with the old call I had in there, that gave me the same error) World world = Minecraft.getMinecraft().theWorld; //entity.getEntityWorld(); Why would it say the method doesn't exist? I'm sure it's probably some little nuance I'm doing wrong, but why would it work on the debug server too? I've removed all other mods too and it still crashes. -Thank you so much for all of your help so far. Quote
Animefan8888 Posted December 19, 2016 Posted December 19, 2016 Cool, it all seems to work when I run it in debug mode. As soon as I jar it and put it into a live game it crashes when the world loads. ava.lang.NoSuchMethodError: net.minecraft.client.Minecraft.getMinecraft()Lnet/minecraft/client/Minecraft; at com.example.examplemod.burningmobs.BurnMobs(burningmobs.java:39) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_burningmobs_BurnMobs_LivingUpdateEvent.invoke(.dynamic) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) at net.minecraftforge.common.ForgeHooks.onLivingUpdate(ForgeHooks.java:524) at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2000) at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:232) at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:303) at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:164) at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:215) at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287) at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624) at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:149) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) at java.lang.Thread.run(Thread.java:745) This is line 39 (Along with the old call I had in there, that gave me the same error) World world = Minecraft.getMinecraft().theWorld; //entity.getEntityWorld(); Why would it say the method doesn't exist? I'm sure it's probably some little nuance I'm doing wrong, but why would it work on the debug server too? I've removed all other mods too and it still crashes. -Thank you so much for all of your help so far. Why are you using Minecraft.getMinecraft()? Where are you using it? Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator.
Mopop Posted December 19, 2016 Author Posted December 19, 2016 I was just poking around and trying different things. I originally used entity.getEntityWorld Here is the full method. public void BurnMobs(LivingEvent.LivingUpdateEvent e) { Entity entity = e.getEntity(); World world = Minecraft.getMinecraft().theWorld; //entity.getEntityWorld(); Random rand = new Random(); if (world.isDaytime() && !world.isRemote && !(entity instanceof EntityPlayer) && !(entity instanceof EntityAnimal) && !(entity instanceof EntityVillager) ) { float f = getBrightness(1.0F, world, entity); if (f > 0.5F && rand.nextFloat() * 30.0F < (f - 0.4F) * 2.0F && world.canSeeSky(new BlockPos(entity.posX, entity.posY + (double) entity.getEyeHeight(), entity.posZ))) { boolean flag = true; if (flag) { entity.setFire(; } } } } Quote
Animefan8888 Posted December 19, 2016 Posted December 19, 2016 Couple critiques Instead of event.getEntity() use event.getEntityLiving() and use an EntityLivingBase field. Go back to using entity.getEntityWorld() Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator.
Mopop Posted December 19, 2016 Author Posted December 19, 2016 Ok I changed the code as recommended. I'm still getting the error when it's live, but it still works in debug mode on the IDE. I put a breakpoint on the line it's complaining about and it seems to run the entity.getEntityWorld() fine. However I did notice this when I looked at the crash report Description: Ticking player java.lang.NoSuchMethodError: net.minecraft.entity.EntityLivingBase.getEntityWorld()Lnet/minecraft/world/World; A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Server thread Stacktrace: at com.example.examplemod.burningmobs.BurnMobs(burningmobs.java:44) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_burningmobs_BurnMobs_LivingUpdateEvent.invoke(.dynamic) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) at net.minecraftforge.common.ForgeHooks.onLivingUpdate(ForgeHooks.java:524) at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2000) at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:232) -- Player being ticked -- Details: Entity Type: null (net.minecraft.entity.player.EntityPlayerMP) Entity ID: 541 Entity Name: Mopop27 Entity's Exact location: 668.56, 4.00, -331.37 Entity's Block location: World: (668,4,-332), Chunk: (at 12,0,4 in 41,-21; contains blocks 656,0,-336 to 671,255,-321), Region: (1,-1; contains chunks 32,-32 to 63,-1, blocks 512,0,-512 to 1023,255,-1) Entity's Momentum: 0.00, -0.08, 0.00 Entity's Passengers: [] Entity's Vehicle: ~~ERROR~~ NullPointerException: null Stacktrace: at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:303) at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:164) at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:215) at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287) -- Ticking connection -- Details: Connection: net.minecraft.network.NetworkManager@3d0aba21 Stacktrace: at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624) at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:149) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) at java.lang.Thread.run(Thread.java:745) Is the null EntityType causing this? What is different about the game when running it through the IDE? Quote
Animefan8888 Posted December 19, 2016 Posted December 19, 2016 How are you compiling your mod? Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator.
Mopop Posted December 19, 2016 Author Posted December 19, 2016 In intelliJ using the Gradle sidebar. build->clean->jar Quote
Animefan8888 Posted December 19, 2016 Posted December 19, 2016 In intelliJ using the Gradle sidebar. build->clean->jar You need to use the forge gradle building I believe. Never used intelliJ, but this should help. https://mcforge.readthedocs.io/en/latest/gettingstarted/ At the very bottom. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator.
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.