[1.11] Comparing Two ItemStack Lists.

[Lambda]

Hey there!

 

So I've ran into a bit of an issue regaurding trying to compare two lists... I've tried using .equals and methods like this.. however, none of them seem to return true... even though the lists are the EXACT same:

 

[02:31:32] [server thread/INFO]: [sTDOUT]: stackList: [1xitem.ingotIron@0, 1xitem.ingotGold@0, 1xitem.redstone@0, 1xitem.apple@0]
[02:31:32] [server thread/INFO]: [sTDOUT]: recipe List: [1xitem.ingotIron@0, 1xitem.ingotGold@0, 1xitem.redstone@0, 1xitem.apple@0]

 

Here is the code:

 

        if (!world.isRemote) {
            if (getPlayer() != null) {
                EntityPlayer boundedPlayer = getPlayer(); //Possible capability support.. I just don't know yet.. 
                itemList = this.world.getEntitiesWithinAABB(EntityItem.class, new AxisAlignedBB(this.getPos().getX() - 1, this.getPos().getY() - 1, this.getPos().getZ() - 1, this.getPos().getX() + 1, this.getPos().getY() + 3, this.getPos().getZ() + 1));

                List<ItemStack> itemStackList = new ArrayList<ItemStack>();

                for (EntityItem item : itemList) {
                    if (!itemStackList.contains(item.getEntityItem())) {
                        itemStackList.add(item.getEntityItem());
                    }
                }

                List<ConstructorRecipeHandler> recipes = getRecipesForInput(itemList);
                if (!recipes.isEmpty()) {
                    for (ConstructorRecipeHandler recipe : recipes) {
                        System.out.println("stackList: " + itemStackList);
                        System.out.println("recipe List: " + recipe.input);
                        if (itemStackList.equals(recipe.input)) {
                            if (recipe != null) {
                                System.out.println("processing");

                            }
                        }
                    }
                }
            }
        }

 

 

Thanks!

[kirinnee97]

Have you tried using

if (ItemStack.areItemStackTagsEqual(itemStackList,recipe.input) {
                            if (recipe != null) {
                                System.out.println("processing");

                            }
                        }

 

and you should put a null check, ie

if (recipe !=null){...

before the itemstack comparison, if there is a chance that recipe can be null

[Lambda]

Okay, because the areitemStacksEqual takes only a ItemStack,not a list, what would be the efficient way of iterating though both lists?

[Draco18s]

You need to loop over both lists and compare each item in one against each item in the other. Duh.

[Lambda]

Yeah I know that, I just just wondering if there was a better way than using two for loops.. Thanks.

[Lambda]

Okay would something like this work?

 

    public static boolean areItemStackListEqual(List<ItemStack> stack1, List<ItemStack> stack2) {
        for(ItemStack item1 : stack1) {
            for(ItemStack item2 : stack2) {
                if(isValid(item1) && isValid(item2)) {
                    if(ItemStack.areItemStackTagsEqual(item1, item2)) {
                        return true;
                    }
                }
            }
        }
        return false;
    }

[Draco18s]

That would return true if the two lists contain at least one item that is also in the other list.

i.e.

Passing in these arrays of characters:

a,b,s,d,e,f

q,w,e,p,l,r

Will return true (for a similar function matching characters) because they both contain an 'e'

[loordgek]

is this what you want

https://github.com/loordgek/Extragenarators/blob/b36b1fc927c7f3933a2765b30cb102419cea45d7/src/main/java/loordgek/extragenarators/util/item/InventoryUtil.java

you need to update it to your needs

[Lambda]

is this what you want

https://github.com/loordgek/Extragenarators/blob/b36b1fc927c7f3933a2765b30cb102419cea45d7/src/main/java/loordgek/extragenarators/util/item/InventoryUtil.java

you need to update it to your needs

 

Okay, I've updated it, however, it seems to only return 1 when one item is present, the others dont change the value, here is the code:

    public static List<ItemStack> getStacks(IInventory itemHandler) {
        List<ItemStack> stacks = new ArrayList<ItemStack>();
        for (int i = 0; i < itemHandler.getSizeInventory(); i++) {
            stacks.set(i, itemHandler.getStackInSlot(i));
        }
        return stacks;
    }

    public static boolean removeSets(IInventory inventory, int count, List<ItemStack> set, boolean oreDictionary, boolean doRemove) {
        List<ItemStack>stock = getStacks(inventory);
        if (doRemove) {
            List<ItemStack> removed = removeSets(inventory, count, set, oreDictionary);
            return removed != null && removed.size() >= count;
        } else {
            return containsSets(set, stock, oreDictionary) >= count;
        }
    }
    public static List<ItemStack >removeSets(IInventory inventory, int count, List<ItemStack> set, boolean oreDictionary) {
        List<ItemStack> removed = new ArrayList<ItemStack>();
        List<ItemStack> stock = getStacks(inventory);
        if (containsSets(set, stock, oreDictionary) < count) {
            return null;
        }
        for (int i = 0; i < set.size(); i++) {
            if (set.get(i) == null) {
                continue;
            }
            ItemStack stackToRemove = set.get(i).copy();
            stackToRemove.setCount(stackToRemove.getCount() * count);
            // try to remove the exact stack first
            ItemStack removedStack = removeStack(inventory, stackToRemove, false);
            if (removedStack == null) {
                // remove crafting equivalents next
                removedStack = removeStack(inventory, stackToRemove, oreDictionary);
            }
            removed.remove(removedStack);
        }
        return removed;
    }
    private static ItemStack removeStack(IInventory inventory, ItemStack stackToRemove, boolean oreDictionary) {
        for (int j = 0; j < inventory.getSizeInventory(); j++) {
            ItemStack stackInSlot = inventory.getStackInSlot(j);
            ItemStack removed = inventory.decrStackSize(j, stackToRemove.getCount());
            stackToRemove.setCount(stackInSlot.getCount() - removed.getCount());
            if (stackToRemove.getCount() == 0) {
                return removed;
            }
        }
        return null;
    }
    public static List<ItemStack> condenseStacks(List<ItemStack> stacks) {
        List<ItemStack> condensed = new ArrayList<ItemStack>();
        for (ItemStack stack : stacks) {
            if (stack == null) {
                continue;
            }
            if (stack.getCount() <= 0) {
                continue;
            }
            boolean matched = false;
            for (ItemStack cached : condensed) {
                if (cached.isItemEqual(stack) && ItemStack.areItemStackTagsEqual(cached, stack)) {
                    cached.setCount(cached.getCount() + stack.getCount());
                    matched = true;
                }
            }
            if (!matched) {
                ItemStack cached = stack.copy();
                condensed.add(cached);
            }
        }
        return condensed;
    }
    public static int containsSets(List<ItemStack> set, List<ItemStack> stock, boolean oreDictionary) {
        int totalSets = 0;
        List<ItemStack> condensedRequired = condenseStacks(set);
        List<ItemStack> condensedOffered = condenseStacks(stock);
        for (ItemStack req : condensedRequired) {
            int reqCount = 0;
            for (ItemStack offer : condensedOffered) {
                if (ItemStack.areItemStackTagsEqual(req, offer)) {
                    int stackCount = (int) Math.floor(offer.getCount() / req.getCount());
                    reqCount = Math.max(reqCount, stackCount);
                }
            }
            if (reqCount == 0) {
                return 0;
            } else if (totalSets == 0) {
                totalSets = reqCount;
            } else if (totalSets > reqCount) {
                totalSets = reqCount;
            }
        }
        return totalSets;
    }

 

Also how I'm checking it:

                        if (StackUtil.containsSets(itemStackList, recipe.input, true) >= recipe.input.size()) {

[Draco18s]

Use the debugger.

[Lambda]

I'm having an issue using the debugger, it seems not to pause when the method is called, which results in me not getting the info i need:

 

And I am using debug mode.

[Draco18s]

Your break points are in the wrong place then and/our the method is not being called.

[Choonster]

Make sure you're launching Minecraft in Debug mode rather than Run mode.

[Lambda]

Oh... 

[Lambda]

Well one thing I just noticed is the fact that it returns ones if the item on top is valid, so my method of this:

                        if (StackUtil.containsSets(itemStackList, recipe.input, true) >= recipe.input.size()) {

 

Wont work due to the method return:

1
1
1
1

depending on how many items are on top, ex: 3 items = 3 ones, etc.

 

So I'm stuck again 

[Draco18s]

Debug the containsSets method. Figure out why it only returns "1."

[loordgek]

Lambda do you have a github where i can see all the code ??

[Lambda]

Yeah here:

https://github.com/LambdaXV/PlentifulUtilities/tree/master/src/main/java/com/lambda/plentifulutilities

 

 

[loordgek]

put the gradle stuff in it plz

[Lambda]

Okay! Its updated now!

[loordgek]

will look tomorrow need zzzzzz