Search the Forums BEFORE making a new post.

NBT integer var update wrong

Posted February 28, 20178 yr

I have an integer value i add to nbt, i inticilize and declare it in the class main structure, but when nbt reads and write and my entity onUpdates it becomes 0

Quote

February 28, 20178 yr

Post you code

Apparently I'm addicted to these forums and can't help but read all the posts. So if I somehow help you, please click the "Like This" button, it helps.

Quote

February 28, 20178 yr

Author

Edited February 28, 20178 yr by clowcadia

Quote

February 28, 20178 yr

Author

package com.clowcadia.test.npc;

import com.clowcadia.test.GuiHandler;
import com.clowcadia.test.TestModHandler;
import com.clowcadia.test.utils.Utils;

import net.minecraft.block.ITileEntityProvider;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;
import scala.reflect.internal.Trees.This;

public class Basic extends EntityLiving implements  ICapabilityProvider{
	
	private ItemStackHandler handler;
	public static Basic instance;
	public static int basicID; 
	private int stomach=800;	
	private int stomachCap = 800;
	
	public Basic(World world) 
	{			
		super(world);
		this.handler = new ItemStackHandler(9); 
		
		Utils.getLogger().info("basic constructor" +this.stomach);
	}
	
	@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}	
	
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		this.readFromNBT(pkt.getNbtCompound());
	}

	public NBTTagCompound getUpdateTag() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeToNBT(compound);
		return compound;
	}
	
	public void handleUpdateTag(NBTTagCompound tag) {
		this.readFromNBT(tag);
	}

	public NBTTagCompound getTileData() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeToNBT(compound);
		return compound;
	}
	
	@Override
	public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) this.handler;		
		return super.getCapability(capability, facing);
	}
	
	@Override
	public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
		return super.hasCapability(capability, facing);
	}
	
	public boolean isUseableByPlayer(EntityPlayer player) {
		return true;
	}
	
	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}
	
	@Override
	public boolean processInteract(EntityPlayer player, EnumHand hand)
    {
		
		if (!this.world.isRemote)
		{			
			basicID = this.getEntityId(); //for inputing into x/y/z in the opne gui to pass the entety id
			System.out.println("Player has interacted with the mob");	
			player.openGui(TestModHandler.instance, GuiHandler.BASIC, this.world, basicID, (int)player.posY, (int)player.posZ);	
		}
		else
		{
			
			//player.openGui(ClowcadiaMod.modInstance, 0, this.world, (int) player.posX, (int)player.posY, (int)player.posZ);
		}
		return true;
    }




}

Quote

February 28, 20178 yr

Author

[23:52:12] [Server thread/INFO] [testmod]: basic constructor800
[23:52:13] [Server thread/INFO]: Preparing spawn area: 87%
[23:52:13] [Server thread/INFO] [testmod]: 0 800

Quote

February 28, 20178 yr

@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}

you only return the super NBTTagCompound that will not work

first read and write the super and than do the rest

Quote

February 28, 20178 yr

7 minutes ago, loordgek said:


@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}

you only return the super NBTTagCompound that will not work

first read and write the super and than do the rest

That code should work, since TileEntity#writeToNBT writes its data to and then returns its argument.

Edited February 28, 20178 yr by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

February 28, 20178 yr

EntityLiving doesn't have readFromNBT or writeToNBT. Use readEntityFromNBT and writeEntityToNBT.

Did you just copy pasted from tile entity code?

Quote

February 28, 20178 yr

I completely missed the fact that this is an Entity rather than a TileEntity.

Still, overriding Entity#readFromNBT and Entity#writeToNBT should work (though you're meant to override Entity#readEntityFromNBT and Entity#writeEntityToNBT instead).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

February 28, 20178 yr

Author

7 hours ago, Choonster said:

I completely missed the fact that this is an Entity rather than a TileEntity.

Still, overriding Entity#readFromNBT and Entity#writeToNBT should work (though you're meant to override Entity#readEntityFromNBT and Entity#writeEntityToNBT instead).

thank you.. whats going on lol

Quote

February 28, 20178 yr

Author

Write/ReadEniityToNBT methods still dont work

Quote

February 28, 20178 yr

Author

package com.clowcadia.test.npc;

import com.clowcadia.test.GuiHandler;
import com.clowcadia.test.TestModHandler;
import com.clowcadia.test.utils.Utils;

import net.minecraft.block.ITileEntityProvider;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.world.World;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;

public class Basic extends EntityLiving implements  ICapabilityProvider{
	
	private ItemStackHandler handler;
	public static Basic instance;
	public static int basicID; 
	private int stomach=800;	
	private int stomachCap = 800;
	
	public Basic(World world) 
	{			
		super(world);
		this.handler = new ItemStackHandler(9); 
		
		Utils.getLogger().info("basic constructor" +this.stomach);
	}
	
	@Override
	public void readEntityFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readEntityFromNBT(compound);
	}
	
	@Override
	public void writeEntityToNBT(NBTTagCompound compound) {
		super.writeEntityToNBT(compound);
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		
	}	
	
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		this.readEntityFromNBT(pkt.getNbtCompound());
	}

	public NBTTagCompound getUpdateTag() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeEntityToNBT(compound);
		return compound;
	}
	
	public void handleUpdateTag(NBTTagCompound tag) {
		this.readEntityFromNBT(tag);
	}

	public NBTTagCompound getTileData() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeEntityToNBT(compound);
		return compound;
	}
	
	@Override
	public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) this.handler;		
		return super.getCapability(capability, facing);
	}
	
	@Override
	public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
		return super.hasCapability(capability, facing);
	}
	
	public boolean isUseableByPlayer(EntityPlayer player) {
		return true;
	}
	
	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}
	
	@Override
	public boolean processInteract(EntityPlayer player, EnumHand hand)
    {
		
		if (!this.world.isRemote)
		{			
			basicID = this.getEntityId(); //for inputing into x/y/z in the opne gui to pass the entety id
			System.out.println("Player has interacted with the mob");	
			player.openGui(TestModHandler.instance, GuiHandler.BASIC, this.world, basicID, (int)player.posY, (int)player.posZ);	
		}
		else
		{
			
			//player.openGui(ClowcadiaMod.modInstance, 0, this.world, (int) player.posX, (int)player.posY, (int)player.posZ);
		}
		return true;
    }




}

Quote

February 28, 20178 yr

Author

yes, the entity apears and everything just the that initial 800 turns to 0 after being initilized

Quote

February 28, 20178 yr

Author

so how do i get it update to its original value

Quote

February 28, 20178 yr

Author

when i initilize the value it is 800 but then when the update method goes on it becomes 0, how can i have the value to stay at 800 rather being 0, where should i modify code and what should i do, call the write nbt there or?

Quote

February 28, 20178 yr

Author

I dont i undestand what to do about it

Quote

March 1, 20178 yr

Author

Is get/setInteger not the tag setting?

Quote

March 1, 20178 yr

Author

is "Stomach" not the tag compound.setInteger("Stomach", this.stomach);

Quote

March 1, 20178 yr

When the world is loaded TE's have readFromNBT called and if the tag doesn't exist then it will return a default value for numbers that is 0. And then when the world will call writeToNBT at certain points and then save the tag making it exist, but it will be set to 0 because it was read as 0. So to check if the tag is there use NBTTagCompound#hasTag(String)

Edited March 1, 20178 yr by Animefan8888

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

March 1, 20178 yr

Author

did not see the post above

How does one set an NTB tag, i am having a hard time understanding thigns through my research . my findings are itemstack specific

Edited March 1, 20178 yr by clowcadia

Quote

March 1, 20178 yr

Author

15 hours ago, Animefan8888 said:

When the world is loaded TE's have readFromNBT called and if the tag doesn't exist then it will return a default value for numbers that is 0. And then when the world will call writeToNBT at certain points and then save the tag making it exist, but it will be set to 0 because it was read as 0. So to check if the tag is there use NBTTagCompound#hasTag(String)

what i dont understand is why

@Override
	public void readEntityFromNBT(NBTTagCompound compound) {
		Utils.getLogger().info("basic readNBT " +this.stomach);
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");

why it does this

[16:28:51] [Server thread/INFO] [testmod]: basic readNBT 800
[16:28:51] [Server thread/INFO]: Preparing spawn area: 56%
[16:28:52] [Server thread/INFO] [testmod]: 0 800

when

	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}

Quote

March 1, 20178 yr

Author

Just now, diesieben07 said:

If compound doesn't have an entry called "Stomach", it will return 0. Meaning you will set this.stomach to 0.

Thank you for clarification, as for the hasTag method, i cant seem to find it in NBTTagCompound class

Quote

March 1, 20178 yr

Author

Maybe getCompoundTag? getTag?

Quote

March 1, 20178 yr

Author

I do, i dont understand what your implying ? Maybe i can work on ur criticism

Quote

March 1, 20178 yr

Author

Using eclipse not JIdea, i belive it has a different interface

and i am runnign into syntax error

cannot make static referrence to non static method

if(NBTTagCompound.hasKey(tagStomach)){}

and no enclosign instance of NTB blah blah is accesible in scope

if(NBTTagCompound.this.hasKey(tagStomach)){}

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/50948-nbt-integer-var-update-wrong/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

jarJar not working

Try replacing implementation with minecraftLibrary. Dependencies in the minecraftLibrary configuration are added to your compile and runtime classpaths in ForgeGradle 6.

By Jonathing · 1 hour ago1 hr
Failed loading villager cartographer registered at cartographer - frozen tick

Allocated 10 Gb of ram. Could try again with more but I read using too much can slow things down as well. Going to try another big modpack and see if i can replicate the problem. It seems like this cartographer problem is kind of popular and doesn't have a solid solution yet, but i suspect its some generation mod since it's a crash that happens when specific chunks are being loaded. so i'll still try to lookout for what mod it could be as i add. i'll report back after testing as you suggested for a bit

By chemba21 · 6 hours ago6 hr
Failed loading villager cartographer registered at cartographer - frozen tick

I have no idea - is enough RAM allocated?
Do other pre-configured modpacks work? Maybe use such a modpack as working base and add new mods one by one

By TileEntity · 6 hours ago6 hr
Minecraft Mod Gradle Build not working

<repository> looks like a placeholder
url "https://maven.minecraftforge.net/<repository>"

By TileEntity · 6 hours ago6 hr
Minecraft Mod Gradle Build not working

The settings.gradle file has been fixed. But, the build.gradle has an error now.
Error:
* Where:
Build file 'C:\Users\csonn\OneDrive\Desktop\fusionlucky\build.gradle' line: 3
* What went wrong:
Plugin [id: 'net.minecraftforge.gradle', version: '6.1.+'] was not found in any of the following sources:
- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Included Builds (No included builds contain this plugin)
- Plugin Repositories (could not resolve plugin artifact 'net.minecraftforge.gradle:net.minecraftforge.gradle.gradle.plugin:6.1.+')
Searched in the following repositories:
Gradle Central Plugin Repository
MinecraftForge
Forge Maven
Forge Maven
Maven Repository for Minecraft Forge. <br/>You should be on:)
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

Build.Gradle File:
plugins { id 'java' id 'net.minecraftforge.gradle' version '6.1.+' } group = 'io.github.csonnic03.fusionlucky' version = '1.0.0' archivesBaseName = 'fusionlucky' java { toolchain { languageVersion = JavaLanguageVersion.of(17) } } repositories { mavenCentral() maven { name "forgeMaven" url "https://maven.minecraftforge.net/<repository>" } } dependencies { minecraft 'net.minecraftforge:forge:1.20.1-47.1.0' } minecraft { mappings channel: 'official', version: '1.20.1' runs { client { workingDirectory project.file('run') } server { workingDirectory project.file('run') } } } tasks.withType(JavaCompile) { options.encoding = 'UTF-8' } jar { manifest { attributes( "Specification-Title": "Fusion Lucky Block", "Specification-Vendor": "example", "Implementation-Title": project.name, "Implementation-Version": project.version, "Implementation-Vendor": "example", "ModLauncher-TargetFMLVersion": "[47,)" ) } }

By Fairygamer03 · 8 hours ago8 hr

Ugdhar

Sign In

NBT integer var update wrong

Featured Replies

Join the conversation

Posts

jarJar not working

Failed loading villager cartographer registered at cartographer - frozen tick

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

Minecraft Mod Gradle Build not working

Topics

jarJar not working

Failed loading villager cartographer registered at cartographer - frozen tick

Minecraft Mod Gradle Build not working

[SOLVED][1.21.8 | Forge 58.0.5] How to cancel InputEvent.MouseScrollingEvent?

Mod not building

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)